Christian Bruckmayer b86ec136b6 Raise KeyError instead of ArgumentError in Registry ... to make use of did_you_mean gem. The did_you_mean gem only supports NameError, NoMethodError and KeyError. However, for NameError the message does also need to match a certain format and we can not use a custom message like 'Factory not registered ...'. Therefore using KeyError is to only logical conclusion. The did_you_mean gem makes use of the receiver attributes, but in Ruby > 2.5 it is not possible to set the receiver and key attributes on a KeyError (they are only set when the KeyError is raised in C). We explored monkey patching KeyError for earlier versions of Ruby, but it was a problematic solution. Instead we can rescue the original KeyError, take the message from it, which will already include the did_you_mean message, then customize the message and re-raise a new KeyError with that customized message. Starting in Ruby 2.6 this will not be necessary anymore https://bugs.ruby-lang.org/issues/14313, so maybe we can get rid of it for FactoryBot 6 or 7. Fixes #992 Co-authored-by: Daniel Colson <danieljamescolson@gmail.com>		2018-12-16 22:25:04 -05:00
..
factory_bot	Raise KeyError instead of ArgumentError in Registry	2018-12-16 22:25:04 -05:00
factory_bot.rb	Add option for verbose linting	2018-11-27 12:04:38 -05:00