mirror of
https://github.com/thoughtbot/factory_bot.git
synced 2022-11-09 11:43:51 -05:00
bf04aaa068
Most of this was fixed by adding the `attribute-defined-statically-cop` branch of `thoughtbot/rubocop-rspec` to the Gemfile and running: ```sh rubocop \ --require rubocop-rspec \ --only FactoryBot/AttributeDefinedStatically \ --auto-correct ``` I had to update the cucumber tests manually, and I realized our changes don't handle `ignore` blocks or blocks with arity 1 that use the yielded DefinitionProxy. I will update https://github.com/rubocop-hq/rubocop-rspec/pull/666to handle these cases.
66 lines
1.7 KiB
Ruby
66 lines
1.7 KiB
Ruby
describe "declaring attributes on a Factory that are private methods on Object" do
|
|
before do
|
|
define_model("Website", system: :boolean, link: :string, sleep: :integer)
|
|
|
|
FactoryBot.define do
|
|
factory :website do
|
|
system { false }
|
|
link { "http://example.com" }
|
|
sleep { 15 }
|
|
end
|
|
end
|
|
end
|
|
|
|
subject { FactoryBot.build(:website, sleep: -5) }
|
|
|
|
its(:system) { should eq false }
|
|
its(:link) { should eq "http://example.com" }
|
|
its(:sleep) { should eq -5 }
|
|
end
|
|
|
|
describe "assigning overrides that are also private methods on object" do
|
|
before do
|
|
define_model("Website", format: :string, y: :integer, more_format: :string, some_funky_method: :string)
|
|
|
|
Object.class_eval do
|
|
private
|
|
def some_funky_method(args)
|
|
end
|
|
end
|
|
|
|
FactoryBot.define do
|
|
factory :website do
|
|
more_format { "format: #{format}" }
|
|
end
|
|
end
|
|
end
|
|
|
|
after do
|
|
Object.send(:undef_method, :some_funky_method)
|
|
end
|
|
|
|
subject { FactoryBot.build(:website, format: "Great", y: 12345, some_funky_method: "foobar!") }
|
|
its(:format) { should eq "Great" }
|
|
its(:y) { should eq 12345 }
|
|
its(:more_format) { should eq "format: Great" }
|
|
its(:some_funky_method) { should eq "foobar!" }
|
|
end
|
|
|
|
describe "accessing methods from the instance within a dynamic attribute that is also a private method on object" do
|
|
before do
|
|
define_model("Website", more_format: :string) do
|
|
def format
|
|
"This is an awesome format"
|
|
end
|
|
end
|
|
|
|
FactoryBot.define do
|
|
factory :website do
|
|
more_format { "format: #{format}" }
|
|
end
|
|
end
|
|
end
|
|
|
|
subject { FactoryBot.build(:website) }
|
|
its(:more_format) { should eq "format: This is an awesome format" }
|
|
end
|