From 75d1f68d120261c66288761fd8b5870a8cf1882d Mon Sep 17 00:00:00 2001 From: Daniel Colson Date: Wed, 25 Jul 2018 20:19:58 -0400 Subject: [PATCH] Stop testing old Ruby and Rails versions Ruby 2.1 and 2.2 are no longer maintained, and Rails 3.2 and 4.2 are no longer maintained, so I don't want to go out of our way to continue supporting them in FactoryBot 5+. Hooray for faster test runs! --- .travis.yml | 20 -------------------- Appraisals | 11 ----------- gemfiles/rails3.2.gemfile | 22 ---------------------- gemfiles/rails4.1.gemfile | 23 ----------------------- 4 files changed, 76 deletions(-) delete mode 100644 gemfiles/rails3.2.gemfile delete mode 100644 gemfiles/rails4.1.gemfile diff --git a/.travis.yml b/.travis.yml index f38b438..96df948 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,8 +7,6 @@ before_install: - gem cleanup bundler cache: bundler rvm: - - 2.1 - - 2.2 - 2.3 - 2.4 - 2.5 @@ -19,29 +17,11 @@ branches: install: - "bundle install --retry 3 --jobs 8" gemfile: - - gemfiles/rails3.2.gemfile - - gemfiles/rails4.1.gemfile - gemfiles/rails4.2.gemfile - gemfiles/rails5.0.gemfile - gemfiles/rails5.1.gemfile - gemfiles/rails5.2.gemfile matrix: fast_finish: true - exclude: - - rvm: 2.1 - gemfile: gemfiles/rails5.0.gemfile - - rvm: 2.1 - gemfile: gemfiles/rails5.1.gemfile - - rvm: 2.1 - gemfile: gemfiles/rails5.2.gemfile - # Ruby 2.4+ doesn't work with ActiveSupport 4.1 - # https://github.com/rails/rails/pull/25161 - # https://github.com/rails/rails/pull/25737 - - rvm: 2.4 - gemfile: gemfiles/rails4.1.gemfile - - rvm: 2.5 - gemfile: gemfiles/rails4.1.gemfile - - rvm: ruby-head - gemfile: gemfiles/rails4.1.gemfile allow_failures: - rvm: ruby-head diff --git a/Appraisals b/Appraisals index 483ab1d..b9e69d5 100644 --- a/Appraisals +++ b/Appraisals @@ -1,15 +1,4 @@ # These are the versions of Rails we want to test against. -appraise 'rails3.2' do - gem 'rails', '~> 3.2.21' - gem 'sass-rails' -end - -appraise 'rails4.1' do - gem 'rails', '~> 4.1.9' - gem 'sass-rails' - gem 'spring' -end - appraise 'rails4.2' do gem 'rails', '~> 4.2.0' end diff --git a/gemfiles/rails3.2.gemfile b/gemfiles/rails3.2.gemfile deleted file mode 100644 index c93ef5a..0000000 --- a/gemfiles/rails3.2.gemfile +++ /dev/null @@ -1,22 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "appraisal" -gem "aruba" -gem "coffee-rails" -gem "cucumber", "1.3.19" -gem "jquery-rails" -gem "rake" -gem "rspec-rails" -gem "uglifier" -gem "test-unit" -gem "activerecord-jdbcsqlite3-adapter", :platforms => :jruby -gem "jdbc-sqlite3", :platforms => :jruby -gem "therubyrhino", :platforms => :jruby -gem "jruby-openssl", :platforms => :jruby -gem "sqlite3", :platforms => :ruby -gem "rails", "~> 3.2.21" -gem "sass-rails" - -gemspec :name => "factory_bot_rails", :path => "../" diff --git a/gemfiles/rails4.1.gemfile b/gemfiles/rails4.1.gemfile deleted file mode 100644 index fbf7a15..0000000 --- a/gemfiles/rails4.1.gemfile +++ /dev/null @@ -1,23 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "appraisal" -gem "aruba" -gem "coffee-rails" -gem "cucumber", "1.3.19" -gem "jquery-rails" -gem "rake" -gem "rspec-rails" -gem "uglifier" -gem "test-unit" -gem "activerecord-jdbcsqlite3-adapter", :platforms => :jruby -gem "jdbc-sqlite3", :platforms => :jruby -gem "therubyrhino", :platforms => :jruby -gem "jruby-openssl", :platforms => :jruby -gem "sqlite3", :platforms => :ruby -gem "rails", "~> 4.1.9" -gem "sass-rails" -gem "spring" - -gemspec :name => "factory_bot_rails", :path => "../"