1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot_rails.git synced 2022-11-09 11:49:18 -05:00
Commit graph

7 commits

Author SHA1 Message Date
Daniel Colson
c84e6b2aa2 Fix remaining RuboCop TODOs 2018-10-03 21:40:07 -04:00
Alex
7907b085fd Address todos generated by rubocop for files in the lib/generators directory (#299)
* Address todos generated by rubocop for files in the lib/generators directory.

This partially addresses #293. Since rubocop generated quite a few todos, the commits addressing them are split up into a few different PRs that cover different files.

* Fix underscore seperator in model_generator.rb, and change memoized instance variable name to @_source_root in lib/generators/factory_bot.rb

* get rid of memoized _source_root variable

* get rid of extraneous rubocop rules
2018-09-28 22:03:04 -04:00
Alex
879b47f70d Address todos generated by rubocop for gemfiles and gemspec files (#295)
This partially addresses #293. Since rubocop generated quite a few todos, the commits addressing them are split up into a few different PRs that cover different files.
2018-09-28 17:32:12 -04:00
Alex
124c89b264 Address todos generated by rubocop for files in the features/ directory. (#297)
This partially addresses #293. Since rubocop generated quite a few todos, the commits addressing them are split up into a few different PRs that cover different files.
2018-09-28 15:23:52 -04:00
Alex
77d707d2c7 Address todos generated by rubocop for files in Rakefile and Appraisals. (#298)
This partially addresses #293. Since rubocop generated quite a few todos, the commits addressing them are split up into a few different PRs that cover different files.
2018-09-28 14:10:19 -04:00
Alex
c6b66bbb1a Address todos generated by rubocop for files starting with lib/factory_bot_rails (#296)
This partially addresses #293. Since rubocop generated quite a few todos, the commits addressing them are split up into a few different PRs that cover different files.
2018-09-28 14:08:56 -04:00
Daniel Colson
29249b3751 Add RuboCop configuration
This is similar to the work Christian Bruckmayer is doing over on
factory_bot. I read that Hound doesn't support the
`inherited_from` key, so I put all of the todos
from the auto-generated `.rubocop_todo.yml` straight into the
`.rubocop.yml`.

fixup! Add RuboCop configuration
2018-09-18 23:09:25 -04:00