1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot_rails.git synced 2022-11-09 11:49:18 -05:00
Commit graph

32 commits

Author SHA1 Message Date
Antonis Berkakis
a5c7bf300f
Test against Rails 6.1 (#388) 2021-01-12 21:11:20 -05:00
Christina Entcheva
9de5e2b765
Skip Spring version 2.1.1 (#389)
* Skip Spring version 2.1.1

Changes introduced in spring 2.1.1
(https://github.com/rails/spring/pull/621) are breaking some tests. That
change was reverted in https://github.com/rails/spring/pull/629, but
hasn't been released yet. Until #629 is released, this PR skips Spring
version 2.1.1.

* Bump to latest standard to match CI

We are using the latest standard on CI. This bumps the version in the
dev Gemfile to match, and fixes one violation.

Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>
2021-01-11 23:06:27 -05:00
Daniel Colson
0ef3f8a2fb Bump listen to ~> 3.2
This matches a change made in a recent version of Rails 6.0.

Without this commit, CI fails because the wrong version of the gem gets
installed.
2020-05-22 17:48:03 -04:00
Daniel Colson
18acdd47d6
Avoid installing uglifier (#373)
With the changes in 4c63a12, we are building our rails apps in api mode
so we should not need uglifier anymore.

This commit also fixes one alphabetization error.
2020-04-04 10:28:48 -04:00
Alex Golubenko
4c63a128a7
Add skip options for test app creation (#371)
Prior to this commit the tests generated a full rails app, but didn't need many of the libraries included by default. Unneeded gems make the test suite slower, and increase the chance of getting errors when new versions of each gem come out.
2020-04-04 09:12:04 -04:00
Daniel Colson
5c52981fcc
Update rails versions on Travis (#367)
This commit gets the Travis build passing by:

- Removing Rails 4.2 so we don't have to deal with bundler < 2 anymore
- Bumping to latest Rails versions
- Explicitly listing all gems that appear in the default Rails Gemfile
- Avoiding bootsnap and javascript, since they aren't relevant to these tests

Co-authored-by: alex <alexandr1golubenko@gmail.com>
2020-03-29 11:51:41 -04:00
Daniel Colson
b18181444d Lock listen gem for Rails 6.0
Rails 6.0 has listen pessimistically [locked] to < 3.2

listen 3.2 was just released, causing our build to fail

[locked]: b45699cbf2/railties/lib/rails/generators/rails/app/templates/Gemfile.tt (L56)
2019-10-02 20:11:25 -04:00
Oliver Peate
064838c0e0 Appraise Rails 6.0.0
https://edgeguides.rubyonrails.org/6_0_release_notes.html
2019-08-19 16:56:55 -04:00
Daniel Colson
01051ad6ae Use pessimistic version for sass-rails
Rails 6.0.0 generates a Gemfile with sass-rails at `~> 5`. Our
Appraisals need to match, or else we end up installing version 6 on CI
and the tests fail with the wrong version.
2019-08-19 13:41:46 -04:00
Yasuo Honda
f1da3aa430 Add active_storage, action_mailer bootsnap and sass-rails gems
To address these errors:

* Address  undefined method `active_storage'

https://travis-ci.org/yahonda/factory_bot_rails/jobs/567544663#L802

```
+/home/travis/.rvm/gems/ruby-2.4.6/gems/railties-5.2.3/lib/rails/railtie/configuration.rb:97:in `method_missing': undefined method `active_storage' for #<Rails::Application::Configuration:0x000000000417d758> (NoMethodError)
```

* Address undefined_method `action_mailer'

https://travis-ci.org/thoughtbot/factory_bot_rails/jobs/548726224#L1657

```ruby
+/home/travis/.rvm/gems/ruby-2.4.6/gems/railties-5.0.7.2/lib/rails/railtie/configuration.rb:95:in `method_missing': undefined method `action_mailer' for #<Rails::Application::Configuration:0x0000000002807418> (NoMethodError)
```

* Address `undefined method `assets'`

https://travis-ci.org/yahonda/factory_bot_rails/jobs/567544663

```
+/home/travis/.rvm/gems/ruby-2.6.3/gems/railties-5.0.7.2/lib/rails/railtie/configuration.rb:95:in `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x000000000337e5f8>
+Did you mean?  asset_host (NoMethodError)
```

* Address `can not load such file -- bootsnap/setup (LoadError)`

https://travis-ci.org/thoughtbot/factory_bot_rails/jobs/548726226#L1703

```ruby
+/home/travis/build/thoughtbot/factory_bot_rails/tmp/aruba/testapp/config/boot.rb:4:in `require': cannot load such file -- bootsnap/setup (LoadError)
```

Note: this commit does not address `Bundler could not find compatible versions for gem "bundler":` for Rails 4.2
2019-08-18 21:08:12 -04:00
Daniel Colson
34982c03f1 Test against latest versions of Rails 2019-04-25 08:54:46 -04:00
Daniel Colson
8c09393993 Test against rails 6.0 2019-04-04 08:54:38 -04:00
Alex
77d707d2c7 Address todos generated by rubocop for files in Rakefile and Appraisals. (#298)
This partially addresses #293. Since rubocop generated quite a few todos, the commits addressing them are split up into a few different PRs that cover different files.
2018-09-28 14:10:19 -04:00
Daniel Colson
75d1f68d12 Stop testing old Ruby and Rails versions
Ruby 2.1 and 2.2 are no longer maintained, and Rails 3.2 and 4.2 are no
longer maintained, so I don't want to go out of our way to continue
supporting them in FactoryBot 5+. Hooray for faster test runs!
2018-09-08 01:48:42 +00:00
Daniel Colson
c9fc696325
Test against Rails 5.1 and 5.2 (#278)
- Add Rails 5.1 and 5.2 to Appraisal
- Avoid running combinations we know are going to fail by moving to
"exclude" instead of "allow_failures"
- Use updated migration class for Rails 5.1+
2018-06-22 13:33:59 -04:00
Joshua Clayton
ec478f1edc
Appraise against Rails 5.0 2016-07-01 09:04:50 -04:00
Joshua Clayton
d4d43e5af9 Bump appraised version of Rails 5 2016-05-17 10:32:41 -04:00
Joshua Clayton
1a694997c0 Appraise against Rails 5.0.0.beta3 2016-04-07 17:53:06 -04:00
Joshua Clayton
8c16ae46e8 Bump versions of Ruby and Rails to test on Travis
* support latest Ruby 2.1
* support latest Ruby 2.2
* support latest Rails 4.2
* drop testing of Ruby 2.0
* drop testing of Rails 4.0
* fix JRuby support
2015-03-14 20:14:50 -04:00
Dan Croak
00cb2eabb1 Test against Rails 3.2, 4.0, 4.1
* Remove gemfiles from version control to match same testing style as
  Clearance and Suspenders.
* MiniTest does not need to be manually included as it is automatically
  included by Rails by default.
* Add spring for Rails 4.1.
* Disable Spring to get specs to pass on Rails 4.1.
* Add therubyrhino for JRuby.
* Remove old references to Rails 3.
* Fix JRuby test where output is "1 runs", not "1 tests".
* Remove Rails 3.0 reference to "turn".
2014-05-27 00:41:24 -07:00
Joshua Clayton
aa40389c7b Remove Rails 3 from appraised versions of Rails 2013-11-03 22:46:03 -05:00
Matt Jankowski
7ce3ca02c6 Bump rails gem versions to latest for Appraisal 2013-01-29 16:39:31 -05:00
Matt Jankowski
5b099f6773 Allow Rails 3.1 to select the 'turn' gem it wants to use
Rails 3.1.x has code which checks which version of ruby is being run,
and based on the result, selects a version of turn.

For 1.9.3+, it selects "~> 0.8.3"; for everything else, it selects "0.8.2".

If we remove turn from the Appraisals, but have travis install both versions
that rails might potentially need, the in-generated-app Gemfile building should
work correctly.
2013-01-07 16:42:54 -05:00
Matt Jankowski
a179d7f366 Newer versions of activerecord-jdbcsqlite3-adapter work without a specially named db driver in database.yml 2013-01-07 15:49:11 -05:00
Matt Jankowski
f68f1c234d Allow each Appraisal version gemfile to resolve the exact gem versions needed 2013-01-07 13:03:55 -05:00
Matt Jankowski
2aa0939884 Update rails gem versions in Appraisals to use latest stable releases: 3.2.10, 3.1.9, 3.0.18 2013-01-04 11:13:58 -05:00
Matt Jankowski
ffca1ce373 Be more specific about which gems are required for which rails versions via Appraisals 2013-01-04 11:13:25 -05:00
Matt Jankowski
742f38dc9e jruby needs a separate sqlite3 adapter 2012-12-13 16:41:16 -05:00
Matt Jankowski
e43f18ddcf Bump the rails 3.2.8 appraisal to 3.2.9 2012-12-13 12:13:38 -05:00
Matt Jankowski
89a257c951 Use minitest-rails only when we actually want to test it.
Some features test the factory_girl_rails integration with minitest-rails.

Other features just test normal integration with rails generators.

When minitest-rails is *always* in our gemfiles, minitest's generator
gets run during the features which generate new rails apps.

Because minitest doesnt support namespaced models, this fails.  But, also,
we don't actually want to run minitest during anything other than the specific
areas where we are testing that integration.

Thus, we need the gem present on the system, but not in the gemfiles during
any times other than when it's pulled in specifically by those features.
2012-12-13 12:02:21 -05:00
Joshua Clayton
9d83c83b0c Add minitest-rails to appraisal 2012-12-10 12:04:39 -05:00
Joshua Clayton
402e6ed84c Use Appraisal
This allows us to test factory_girl_rails against each minor release of
Rails 3. To run the full suite, run

    $ bundle exec rake

To view all the rake tasks Appraisal provides, run

    $ bundle exec rake -T appraisal
2012-11-02 16:35:09 -04:00