1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot_rails.git synced 2022-11-09 11:49:18 -05:00
Commit graph

9 commits

Author SHA1 Message Date
Daniel Colson
68ccd9c2fd Unlock cucumber version
The version we had locked to doesn't give line numbers for each step in
Ruby 3. Instead we see a message:

`*** THIS RUBY IMPLEMENTATION DOESN'T REPORT FILE AND LINE FOR PROCS ***`

We had originally locked to this version for Ruby 2.2, which we are no
longer testing against.
2021-05-26 20:10:18 -04:00
Christina Entcheva
9de5e2b765
Skip Spring version 2.1.1 (#389)
* Skip Spring version 2.1.1

Changes introduced in spring 2.1.1
(https://github.com/rails/spring/pull/621) are breaking some tests. That
change was reverted in https://github.com/rails/spring/pull/629, but
hasn't been released yet. Until #629 is released, this PR skips Spring
version 2.1.1.

* Bump to latest standard to match CI

We are using the latest standard on CI. This bumps the version in the
dev Gemfile to match, and fixes one violation.

Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>
2021-01-11 23:06:27 -05:00
Daniel Colson
aad77ceeb6 Replace Rubocop with standard
Following an [update to the thoughtbot guide][guides PR], this commit
removes Rubocop and replaces it with [standard].

[guides PR]: https://github.com/thoughtbot/guides/pull/606
[standard]: https://github.com/testdouble/standard
2020-06-10 17:13:56 -04:00
Alex Golubenko
4c63a128a7
Add skip options for test app creation (#371)
Prior to this commit the tests generated a full rails app, but didn't need many of the libraries included by default. Unneeded gems make the test suite slower, and increase the chance of getting errors when new versions of each gem come out.
2020-04-04 09:12:04 -04:00
Daniel Colson
5c52981fcc
Update rails versions on Travis (#367)
This commit gets the Travis build passing by:

- Removing Rails 4.2 so we don't have to deal with bundler < 2 anymore
- Bumping to latest Rails versions
- Explicitly listing all gems that appear in the default Rails Gemfile
- Avoiding bootsnap and javascript, since they aren't relevant to these tests

Co-authored-by: alex <alexandr1golubenko@gmail.com>
2020-03-29 11:51:41 -04:00
Yasuo Honda
f1da3aa430 Add active_storage, action_mailer bootsnap and sass-rails gems
To address these errors:

* Address  undefined method `active_storage'

https://travis-ci.org/yahonda/factory_bot_rails/jobs/567544663#L802

```
+/home/travis/.rvm/gems/ruby-2.4.6/gems/railties-5.2.3/lib/rails/railtie/configuration.rb:97:in `method_missing': undefined method `active_storage' for #<Rails::Application::Configuration:0x000000000417d758> (NoMethodError)
```

* Address undefined_method `action_mailer'

https://travis-ci.org/thoughtbot/factory_bot_rails/jobs/548726224#L1657

```ruby
+/home/travis/.rvm/gems/ruby-2.4.6/gems/railties-5.0.7.2/lib/rails/railtie/configuration.rb:95:in `method_missing': undefined method `action_mailer' for #<Rails::Application::Configuration:0x0000000002807418> (NoMethodError)
```

* Address `undefined method `assets'`

https://travis-ci.org/yahonda/factory_bot_rails/jobs/567544663

```
+/home/travis/.rvm/gems/ruby-2.6.3/gems/railties-5.0.7.2/lib/rails/railtie/configuration.rb:95:in `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x000000000337e5f8>
+Did you mean?  asset_host (NoMethodError)
```

* Address `can not load such file -- bootsnap/setup (LoadError)`

https://travis-ci.org/thoughtbot/factory_bot_rails/jobs/548726226#L1703

```ruby
+/home/travis/build/thoughtbot/factory_bot_rails/tmp/aruba/testapp/config/boot.rb:4:in `require': cannot load such file -- bootsnap/setup (LoadError)
```

Note: this commit does not address `Bundler could not find compatible versions for gem "bundler":` for Rails 4.2
2019-08-18 21:08:12 -04:00
Daniel Colson
34982c03f1 Test against latest versions of Rails 2019-04-25 08:54:46 -04:00
Daniel Colson
ba7f5ef327 Update Appraisals
Get rid of the deprecated appraisal rake tasks in favor of running
appraisal directly. To run the whole suite, we can run
`bundle exec appraisal rake`.

I also went ahead and updated all the gemfiles.
2018-10-31 16:22:15 -04:00
Daniel Colson
c9fc696325
Test against Rails 5.1 and 5.2 (#278)
- Add Rails 5.1 and 5.2 to Appraisal
- Avoid running combinations we know are going to fail by moving to
"exclude" instead of "allow_failures"
- Use updated migration class for Rails 5.1+
2018-06-22 13:33:59 -04:00