1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot_rails.git synced 2022-11-09 11:49:18 -05:00
Commit graph

13 commits

Author SHA1 Message Date
Christina Entcheva
9de5e2b765
Skip Spring version 2.1.1 (#389)
* Skip Spring version 2.1.1

Changes introduced in spring 2.1.1
(https://github.com/rails/spring/pull/621) are breaking some tests. That
change was reverted in https://github.com/rails/spring/pull/629, but
hasn't been released yet. Until #629 is released, this PR skips Spring
version 2.1.1.

* Bump to latest standard to match CI

We are using the latest standard on CI. This bumps the version in the
dev Gemfile to match, and fixes one violation.

Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>
2021-01-11 23:06:27 -05:00
Daniel Colson
ce8bfb409b Run standardrb
This commit applies the changes from running `standardrb --fix`
2020-06-10 17:13:56 -04:00
Daniel Colson
5c52981fcc
Update rails versions on Travis (#367)
This commit gets the Travis build passing by:

- Removing Rails 4.2 so we don't have to deal with bundler < 2 anymore
- Bumping to latest Rails versions
- Explicitly listing all gems that appear in the default Rails Gemfile
- Avoiding bootsnap and javascript, since they aren't relevant to these tests

Co-authored-by: alex <alexandr1golubenko@gmail.com>
2020-03-29 11:51:41 -04:00
yuuji.yaginuma
e6509920a6 Use compatible sqlite3 version in test application
Currently, the `sqlite3` in `Gemfile` generated by `rails new` is not
compatible with Rails.

To solve this issue, modified it to use compatible `sqlite3` using
template.
Ref: https://github.com/rails/rails/issues/35161
2019-02-06 09:18:41 -05:00
Daniel Colson
c84e6b2aa2 Fix remaining RuboCop TODOs 2018-10-03 21:40:07 -04:00
Alex
124c89b264 Address todos generated by rubocop for files in the features/ directory. (#297)
This partially addresses #293. Since rubocop generated quite a few todos, the commits addressing them are split up into a few different PRs that cover different files.
2018-09-28 15:23:52 -04:00
Joshua Clayton
9e0b178c6f Correctly configure Aruba command timeout
This removes the misconfiguration of Aruba timeout by instance variable
2016-04-07 17:52:00 -04:00
Joshua Clayton
8f48234356 Optimize for JRuby 32/64 bit differences 2013-12-16 08:35:06 -05:00
Matt Jankowski
b34a554506 Speed up performance on jruby 2012-12-19 14:29:51 -05:00
Mike Burns
c4eab793e3 Extend the Aruba timeout to an hour because bundler takes too long. 2011-07-12 09:50:31 -04:00
Joshua Clayton
a5aee1abed Update gem dependency versions 2011-06-29 12:30:28 -04:00
Joe Ferris
98b00ce10a Use aruba (based on patches from Mike Gehard) 2010-11-11 11:44:41 -05:00
Joe Ferris
dd737af03e Added Rails 3 integration 2010-06-09 11:42:48 -04:00