1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot_rails.git synced 2022-11-09 11:49:18 -05:00
Commit graph

10 commits

Author SHA1 Message Date
Christina Entcheva
9de5e2b765
Skip Spring version 2.1.1 (#389)
* Skip Spring version 2.1.1

Changes introduced in spring 2.1.1
(https://github.com/rails/spring/pull/621) are breaking some tests. That
change was reverted in https://github.com/rails/spring/pull/629, but
hasn't been released yet. Until #629 is released, this PR skips Spring
version 2.1.1.

* Bump to latest standard to match CI

We are using the latest standard on CI. This bumps the version in the
dev Gemfile to match, and fixes one violation.

Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>
2021-01-11 23:06:27 -05:00
Daniel Colson
aad77ceeb6 Replace Rubocop with standard
Following an [update to the thoughtbot guide][guides PR], this commit
removes Rubocop and replaces it with [standard].

[guides PR]: https://github.com/thoughtbot/guides/pull/606
[standard]: https://github.com/testdouble/standard
2020-06-10 17:13:56 -04:00
Daniel Colson
0ef3f8a2fb Bump listen to ~> 3.2
This matches a change made in a recent version of Rails 6.0.

Without this commit, CI fails because the wrong version of the gem gets
installed.
2020-05-22 17:48:03 -04:00
Alex Golubenko
4c63a128a7
Add skip options for test app creation (#371)
Prior to this commit the tests generated a full rails app, but didn't need many of the libraries included by default. Unneeded gems make the test suite slower, and increase the chance of getting errors when new versions of each gem come out.
2020-04-04 09:12:04 -04:00
Daniel Colson
5c52981fcc
Update rails versions on Travis (#367)
This commit gets the Travis build passing by:

- Removing Rails 4.2 so we don't have to deal with bundler < 2 anymore
- Bumping to latest Rails versions
- Explicitly listing all gems that appear in the default Rails Gemfile
- Avoiding bootsnap and javascript, since they aren't relevant to these tests

Co-authored-by: alex <alexandr1golubenko@gmail.com>
2020-03-29 11:51:41 -04:00
Daniel Colson
b18181444d Lock listen gem for Rails 6.0
Rails 6.0 has listen pessimistically [locked] to < 3.2

listen 3.2 was just released, causing our build to fail

[locked]: b45699cbf2/railties/lib/rails/generators/rails/app/templates/Gemfile.tt (L56)
2019-10-02 20:11:25 -04:00
Oliver Peate
064838c0e0 Appraise Rails 6.0.0
https://edgeguides.rubyonrails.org/6_0_release_notes.html
2019-08-19 16:56:55 -04:00
Daniel Colson
01051ad6ae Use pessimistic version for sass-rails
Rails 6.0.0 generates a Gemfile with sass-rails at `~> 5`. Our
Appraisals need to match, or else we end up installing version 6 on CI
and the tests fail with the wrong version.
2019-08-19 13:41:46 -04:00
Daniel Colson
34982c03f1 Test against latest versions of Rails 2019-04-25 08:54:46 -04:00
Daniel Colson
8c09393993 Test against rails 6.0 2019-04-04 08:54:38 -04:00