1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot_rails.git synced 2022-11-09 11:49:18 -05:00
thoughtbot--factory_bot_rails/features
Daniel Colson dd1b1ced77 Add missing test coverage for using spring
Previously our tests were not covering the line where we [add the
factory_bot_rails reloader to the list of Rails reloaders][reloaders
push]. [Spring checks this reloaders list][spring] to decide whether it
needs to reload the rails application. Without adding our reloader to
this list changes to factory_bot definitions would only get picked up
by running `spring stop` (or disabling spring entirely).

This test will ensure we don't accidentally break this interaction
between factory_bot_rails and spring.

While adding this test this commit pulls out a bit of shared background for
the tests in this file, and also removes some Rails 4.2 logic that isn't
necessary anymore since we won't support Rails 4.2 for factory_bot_rails
6.

[reloaders push]: https://github.com/thoughtbot/factory_bot_rails/blob/master/lib/factory_bot_rails/reloader.rb#L42
[spring]: 647b8c3135/lib/spring/application.rb (L165)
2020-05-22 16:47:27 -04:00
..
step_definitions Add skip options for test app creation (#371) 2020-04-04 09:12:04 -04:00
support Update rails versions on Travis (#367) 2020-03-29 11:51:41 -04:00
fixture_replacement_config.feature Update rails versions on Travis (#367) 2020-03-29 11:51:41 -04:00
generators.feature Fix for factory class naming (#366) 2020-04-03 21:50:47 -04:00
load_definitions.feature Update rails versions on Travis (#367) 2020-03-29 11:51:41 -04:00
reloading.feature Add missing test coverage for using spring 2020-05-22 16:47:27 -04:00