thoughtbot--shoulda-matchers/CONTRIBUTING.md

We love contributions from the community! Here's a quick guide to making a pull
request:

1. Fork the repo.

2. Run the tests. We only take pull requests with passing tests, and it's great
to know that you have a clean slate: `bundle && bundle exec rake`

3. If you're adding functionality or fixing a bug, add a failing test for the
issue first.

4. Make the test pass.

5. If you're adding a new feature, ensure that the documentation is up to date
(see the README for instructions on previewing documentation live).

6. Finally, push to your fork and submit a pull request.

At this point you're waiting on us. We try to respond to issues and pull
requests within a few business days. We may suggest some changes to make to your
code to fit with our [code style] or the project style, or discuss alternate
ways of addressing the issue in question. When we're happy with everything,
we'll bring your changes into master. Now you're a contributor!

[code style]: https://github.com/thoughtbot/guides/tree/master/style
Update guide on CONTRIBUTING As a contributor you're no longer required to add NEWS items. We'll do that ourselves :) 2014-10-16 15:59:07 +00:00			`We love contributions from the community! Here's a quick guide to making a pull`
			`request:`
Update contribution guidelines. 2012-03-19 00:39:15 +00:00
			`1. Fork the repo.`

			`2. Run the tests. We only take pull requests with passing tests, and it's great`
Install appraisals before running the test suite Currently, `rake` does run the `appraise` task before running tests. If you run `rake appraise` on its own, it runs `rake appraise:install` beforehand. However, the way that `rake` runs `appraise` is by executing, not invoking, it. Hence, `appraisal:install` will actually not be run (as #execute does not run dependencies for the task being executed). This fix is mostly useful when running tests locally -- on Travis this isn't a problem b/c we are running `rake spec cucumber` instead of just `rake`. 2014-01-20 18:35:10 +00:00			to know that you have a clean slate: `bundle && bundle exec rake`
Update contribution guidelines. 2012-03-19 00:39:15 +00:00
Update guide on CONTRIBUTING As a contributor you're no longer required to add NEWS items. We'll do that ourselves :) 2014-10-16 15:59:07 +00:00			`3. If you're adding functionality or fixing a bug, add a failing test for the`
			`issue first.`
Update contribution guidelines. 2012-03-19 00:39:15 +00:00
			`4. Make the test pass.`

Update guide on CONTRIBUTING As a contributor you're no longer required to add NEWS items. We'll do that ourselves :) 2014-10-16 15:59:07 +00:00			`5. If you're adding a new feature, ensure that the documentation is up to date`
			`(see the README for instructions on previewing documentation live).`
Include step to update NEWS in contribution guidelines 2013-03-27 13:34:05 +00:00
Update guide on CONTRIBUTING As a contributor you're no longer required to add NEWS items. We'll do that ourselves :) 2014-10-16 15:59:07 +00:00			`6. Finally, push to your fork and submit a pull request.`
Update contribution guidelines. 2012-03-19 00:39:15 +00:00
Update guide on CONTRIBUTING As a contributor you're no longer required to add NEWS items. We'll do that ourselves :) 2014-10-16 15:59:07 +00:00			`At this point you're waiting on us. We try to respond to issues and pull`
			`requests within a few business days. We may suggest some changes to make to your`
			`code to fit with our [code style] or the project style, or discuss alternate`
			`ways of addressing the issue in question. When we're happy with everything,`
			`we'll bring your changes into master. Now you're a contributor!`
Update contribution guidelines. 2012-03-19 00:39:15 +00:00
Update guide on CONTRIBUTING As a contributor you're no longer required to add NEWS items. We'll do that ourselves :) 2014-10-16 15:59:07 +00:00			`[code style]: https://github.com/thoughtbot/guides/tree/master/style`