kotovalexarian-likes-github
/
thoughtbot--shoulda-matchers
mirror of https://github.com/thoughtbot/shoulda-matchers.git
1
0
Fork 0
Code Releases Activity
thoughtbot--shoulda-matchers/spec/support/unit/helpers/rails_versions.rb

29 lines
495 B
Ruby
Raw Normal View History

Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
module UnitTests
module RailsVersions
def self.configure_example_group(example_group)
example_group.include(self)
example_group.extend(self)
end
Fix converting association options to a Relation Under Rails 3 when using an association matcher in conjunction with a submatcher such as #order, we have to take the options on the association (:conditions, :order, etc.) and convert them to an ActiveRecord::Relation object. This happens in ModelReflector. Unfortunately, converting an :includes option was broken. This is in part due to ModelReflector not having proper tests, but also, the method that does the conversion to Relation is rather complex and could be broken up so it can be tested better. In fact I noticed that there's a lot of stuff in ModelReflector that does stuff around a Reflection object, so it would be better to define a ModelReflection class that simply decorates a Reflection. That's what I've done and also added proper tests.
2013-10-21 00:41:30 +00:00
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
def rails_version
Handle RangeErrors emitted now in ActiveRecord 4.2 In Rails 4.2, ActiveRecord was changed such that if you attempt to set an attribute to a value and that value is outside the range of the column, then it will raise a RangeError. For instance, an integer column with a limit of 2 (i.e. a smallint) only accepts values between -32768 and +32767. This means that if you try to do any of these three things, a RangeError could be raised: * Use validate_numericality_of along with any of the comparison submatchers and a value that sits on either side of the boundary. * Use allow_value with a value that sits outside the range. * Use validates_inclusion_of against an integer column. (Here we attempt to set that column to a non-integer value to verify that the attribute does not allow said value. That value is really a string version of a large number, so if the column does not take large numbers then the matcher could blow up.) Ancillary changes in this commit: * Remove ValidationMessageFinder and ExceptionMessageFinder in favor of Validator, StrictValidator, and ValidatorWithCapturedRangeError. * The allow_value matcher now uses an instance of Validator under the hood. StrictValidator and/or ValidatorWithCapturedRangeError may be mixed into the Validator object as needed.
2015-01-21 22:46:26 +00:00
Tests::Version.new(Rails::VERSION::STRING)
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
end
Fix converting association options to a Relation Under Rails 3 when using an association matcher in conjunction with a submatcher such as #order, we have to take the options on the association (:conditions, :order, etc.) and convert them to an ActiveRecord::Relation object. This happens in ModelReflector. Unfortunately, converting an :includes option was broken. This is in part due to ModelReflector not having proper tests, but also, the method that does the conversion to Relation is rather complex and could be broken up so it can be tested better. In fact I noticed that there's a lot of stuff in ModelReflector that does stuff around a Reflection object, so it would be better to define a ModelReflection class that simply decorates a Reflection. That's what I've done and also added proper tests.
2013-10-21 00:41:30 +00:00
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
def rails_3_x?
Handle RangeErrors emitted now in ActiveRecord 4.2 In Rails 4.2, ActiveRecord was changed such that if you attempt to set an attribute to a value and that value is outside the range of the column, then it will raise a RangeError. For instance, an integer column with a limit of 2 (i.e. a smallint) only accepts values between -32768 and +32767. This means that if you try to do any of these three things, a RangeError could be raised: * Use validate_numericality_of along with any of the comparison submatchers and a value that sits on either side of the boundary. * Use allow_value with a value that sits outside the range. * Use validates_inclusion_of against an integer column. (Here we attempt to set that column to a non-integer value to verify that the attribute does not allow said value. That value is really a string version of a large number, so if the column does not take large numbers then the matcher could blow up.) Ancillary changes in this commit: * Remove ValidationMessageFinder and ExceptionMessageFinder in favor of Validator, StrictValidator, and ValidatorWithCapturedRangeError. * The allow_value matcher now uses an instance of Validator under the hood. StrictValidator and/or ValidatorWithCapturedRangeError may be mixed into the Validator object as needed.
2015-01-21 22:46:26 +00:00
rails_version =~ '~> 3.0'
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
end
Fix several issues with strong parameters matcher * Instead of decorating controller params, use our "Doublespeak" mini-library to stub ActionController::Parameters. This prevents from interfering with the params object if it is used in various ways, i.e. if `params.fetch(...).permit(...)` is used instead of `params.require(...).permit(...)`. * Fix compat with Rails 4.1, where the verb for #update is PATCH not PUT * Track multiple calls to #permit within a given controller action * Fix so that if the route for your action requires params (such as :id) then you can specify those params
2014-04-20 02:48:43 +00:00
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
def rails_4_x?
Handle RangeErrors emitted now in ActiveRecord 4.2 In Rails 4.2, ActiveRecord was changed such that if you attempt to set an attribute to a value and that value is outside the range of the column, then it will raise a RangeError. For instance, an integer column with a limit of 2 (i.e. a smallint) only accepts values between -32768 and +32767. This means that if you try to do any of these three things, a RangeError could be raised: * Use validate_numericality_of along with any of the comparison submatchers and a value that sits on either side of the boundary. * Use allow_value with a value that sits outside the range. * Use validates_inclusion_of against an integer column. (Here we attempt to set that column to a non-integer value to verify that the attribute does not allow said value. That value is really a string version of a large number, so if the column does not take large numbers then the matcher could blow up.) Ancillary changes in this commit: * Remove ValidationMessageFinder and ExceptionMessageFinder in favor of Validator, StrictValidator, and ValidatorWithCapturedRangeError. * The allow_value matcher now uses an instance of Validator under the hood. StrictValidator and/or ValidatorWithCapturedRangeError may be mixed into the Validator object as needed.
2015-01-21 22:46:26 +00:00
rails_version =~ '~> 4.0'
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
end
Create the define_enum_for matcher
2013-12-31 19:54:21 +00:00
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
def rails_gte_4_1?
Handle RangeErrors emitted now in ActiveRecord 4.2 In Rails 4.2, ActiveRecord was changed such that if you attempt to set an attribute to a value and that value is outside the range of the column, then it will raise a RangeError. For instance, an integer column with a limit of 2 (i.e. a smallint) only accepts values between -32768 and +32767. This means that if you try to do any of these three things, a RangeError could be raised: * Use validate_numericality_of along with any of the comparison submatchers and a value that sits on either side of the boundary. * Use allow_value with a value that sits outside the range. * Use validates_inclusion_of against an integer column. (Here we attempt to set that column to a non-integer value to verify that the attribute does not allow said value. That value is really a string version of a large number, so if the column does not take large numbers then the matcher could blow up.) Ancillary changes in this commit: * Remove ValidationMessageFinder and ExceptionMessageFinder in favor of Validator, StrictValidator, and ValidatorWithCapturedRangeError. * The allow_value matcher now uses an instance of Validator under the hood. StrictValidator and/or ValidatorWithCapturedRangeError may be mixed into the Validator object as needed.
2015-01-21 22:46:26 +00:00
rails_version >= 4.1
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
end
Fix failure message for numericality matcher Secondary author: Mauro George <maurogot@gmail.com> Sometimes the failure message did not always provide the reason for failure. For instance, given this validation: validates :ano, numericality: { only_integer: true, greater_than_or_equal_to: 1900 } this test: it { should validate_numericality_of(:ano).is_greater_than_or_equal_to(1900) } would fail with the following: Did not expect errors when ano is set to 1900.000000000001, got error: as you can see, the failure message doesn't contain the validation error. In the process of making this fix, we changed how the matcher fails so that it will so when the first submatcher fails, not the last. This changes what the failure message looks like, but not the basic functionality of the matcher itself.
2015-04-09 14:27:26 +00:00
def rails_gte_4_2?
rails_version >= 4.2
end
Reorganize unit tests, part II * Change 'spec' Rake task to 'spec:unit' * Require unit_spec_helper.rb in unit tests, not spec_helper.rb * Re-namespace files in spec/support/unit under UnitTests * Files in spec/support/unit/helpers no longer automatically add themselves to RSpec - this happens in unit_spec_helper.rb * Extract RecordWithDifferentErrorAttributeBuilder and RecordValidatingConfirmationBuilder to separate files
2014-10-27 00:51:42 +00:00
end
Fix converting association options to a Relation Under Rails 3 when using an association matcher in conjunction with a submatcher such as #order, we have to take the options on the association (:conditions, :order, etc.) and convert them to an ActiveRecord::Relation object. This happens in ModelReflector. Unfortunately, converting an :includes option was broken. This is in part due to ModelReflector not having proper tests, but also, the method that does the conversion to Relation is rather complex and could be broken up so it can be tested better. In fact I noticed that there's a lot of stuff in ModelReflector that does stuff around a Reflection object, so it would be better to define a ModelReflection class that simply decorates a Reflection. That's what I've done and also added proper tests.
2013-10-21 00:41:30 +00:00
end