kotovalexarian-likes-github/thoughtbot--shoulda-matchers
1
0
Fork 0
mirror of https://github.com/thoughtbot/shoulda-matchers.git synced 2022-11-09 12:01:38 -05:00
Code Releases Activity
thoughtbot--shoulda-matchers/Appraisals

73 lines
1.6 KiB
Text
Raw Normal View History

Add missing test dependences to Appraisals Since as of commit 2748b750873faf587c78d7a71f6c725b0fd4252a, we no longer install dependencies inside of the Rails app that is generated and used to run all of the tests, we have to require all of the dependencies that the app would install inside of the appropriate Appraisals. This was mostly straightforward except for some workarounds with the turn gem: * Rails 3.1 requires two versions of turn depending on which Ruby version you're using. On 1.9.2, it uses turn 0.9.2; after 1.9.2, it uses ~> 0.9.3. To accommodate this we have to have two versions of the Rails 3.1 appraisal which declare the different turn versions. * Rails 3.1 also loads the turn gem even if, in the Gemfile for the app, turn is declared with `require: false`. This causes a problem while running our tests because turn actually requires minitest/autorun, which adds a hook so when Ruby exits, Minitest tests are run. Because we're already using RSpec, Minitest will try to re-run the `rspec` command we ran within a Minitest environment. This will fail since we are using RSpec-specific command line options to run the tests. Unfortunately there's no way to shut off minitest/autorun after it's been required, so we have to monkey-patch Minitest's #run method so it's a no-op.
2014-05-16 11:57:19 -04:00
ruby_version = Gem::Version.new(RUBY_VERSION + '')
Clean up Gemfile * Remove Aruba and Bourne since we don't use them anymore * Remove Rails from main Gemfile as it's already a dependency in each of the appraisals * Tighten dependency on Rake to 10.x * Move dependencies shared among appraisals to Appraisals
2015-02-05 20:01:20 -05:00
shared_dependencies = proc do
Add support for Ruby 2.2 Secondary author: Luciano Sousa <ls@lucianosousa.net> Also, upgrade to rspec-rails 3.2.0 explicitly. (See b7fe87ae915f6b1f99d64e847fea536ad0f78024 for an explanation of why 3.2.0 is necessary here.)
2014-12-28 12:54:33 -05:00
gem 'rspec-rails', '>= 3.2.0', '< 4'
Clean up Gemfile * Remove Aruba and Bourne since we don't use them anymore * Remove Rails from main Gemfile as it's already a dependency in each of the appraisals * Tighten dependency on Rake to 10.x * Move dependencies shared among appraisals to Appraisals
2015-02-05 20:01:20 -05:00
gem 'shoulda-context', '~> 1.2.0'
gem 'sqlite3', platform: :ruby
gem 'activerecord-jdbc-adapter', platform: :jruby
gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
gem 'jdbc-sqlite3', platform: :jruby
gem 'jruby-openssl', platform: :jruby
gem 'therubyrhino', platform: :jruby
end
Use same assertion class as Rails, if loaded Given this scenario: * Using Rails 4.1 * Gemfile has `gem 'shoulda-matchers', require: false` * spec_helper has `require 'shoulda/matchers'` following `require 'rspec/rails'` * Using Spring to run tests matchers that delegate to assertions in Rails (e.g. `render_template` and `route`) will fail in the wrong way if used. They fail because in order to use these assertions, we expect that the assertions will raise a specific exception, an exception that corresponds to whichever test framework that Rails is using. For Rails versions that used Test::Unit, this is Test::Unit::AssertionFailedError. For current Rails versions, which now use Minitest, this exception is Minitest::Assertion. The problem is that instead of asking Rails which exception class it's using, we are trying to detect this exception class ourselves (for cases in which Rails is not being used). This leads to the wrong class being detected: when using a Rails version that uses Minitest, we choose Test::Unit::AssertionFailedError as the class. This happens using the exact scenario above because even though shoulda-matchers is loaded after rspec-rails, rspec-rails itself defines Test::Unit::AssertionFailedError. Also add Cucumber tests that confirms this exact scenario works.
2014-06-21 23:24:22 -04:00
spring = proc do
gem 'spring'
gem 'spring-commands-rspec'
end
Add missing test dependences to Appraisals Since as of commit 2748b750873faf587c78d7a71f6c725b0fd4252a, we no longer install dependencies inside of the Rails app that is generated and used to run all of the tests, we have to require all of the dependencies that the app would install inside of the appropriate Appraisals. This was mostly straightforward except for some workarounds with the turn gem: * Rails 3.1 requires two versions of turn depending on which Ruby version you're using. On 1.9.2, it uses turn 0.9.2; after 1.9.2, it uses ~> 0.9.3. To accommodate this we have to have two versions of the Rails 3.1 appraisal which declare the different turn versions. * Rails 3.1 also loads the turn gem even if, in the Gemfile for the app, turn is declared with `require: false`. This causes a problem while running our tests because turn actually requires minitest/autorun, which adds a hook so when Ruby exits, Minitest tests are run. Because we're already using RSpec, Minitest will try to re-run the `rspec` command we ran within a Minitest environment. This will fail since we are using RSpec-specific command line options to run the tests. Unfortunately there's no way to shut off minitest/autorun after it's been required, so we have to monkey-patch Minitest's #run method so it's a no-op.
2014-05-16 11:57:19 -04:00
rails_4 = proc do
Clean up Gemfile * Remove Aruba and Bourne since we don't use them anymore * Remove Rails from main Gemfile as it's already a dependency in each of the appraisals * Tighten dependency on Rake to 10.x * Move dependencies shared among appraisals to Appraisals
2015-02-05 20:01:20 -05:00
instance_eval(&shared_dependencies)
Use same assertion class as Rails, if loaded Given this scenario: * Using Rails 4.1 * Gemfile has `gem 'shoulda-matchers', require: false` * spec_helper has `require 'shoulda/matchers'` following `require 'rspec/rails'` * Using Spring to run tests matchers that delegate to assertions in Rails (e.g. `render_template` and `route`) will fail in the wrong way if used. They fail because in order to use these assertions, we expect that the assertions will raise a specific exception, an exception that corresponds to whichever test framework that Rails is using. For Rails versions that used Test::Unit, this is Test::Unit::AssertionFailedError. For current Rails versions, which now use Minitest, this exception is Minitest::Assertion. The problem is that instead of asking Rails which exception class it's using, we are trying to detect this exception class ourselves (for cases in which Rails is not being used). This leads to the wrong class being detected: when using a Rails version that uses Minitest, we choose Test::Unit::AssertionFailedError as the class. This happens using the exact scenario above because even though shoulda-matchers is loaded after rspec-rails, rspec-rails itself defines Test::Unit::AssertionFailedError. Also add Cucumber tests that confirms this exact scenario works.
2014-06-21 23:24:22 -04:00
instance_eval(&spring)
Add missing test dependences to Appraisals Since as of commit 2748b750873faf587c78d7a71f6c725b0fd4252a, we no longer install dependencies inside of the Rails app that is generated and used to run all of the tests, we have to require all of the dependencies that the app would install inside of the appropriate Appraisals. This was mostly straightforward except for some workarounds with the turn gem: * Rails 3.1 requires two versions of turn depending on which Ruby version you're using. On 1.9.2, it uses turn 0.9.2; after 1.9.2, it uses ~> 0.9.3. To accommodate this we have to have two versions of the Rails 3.1 appraisal which declare the different turn versions. * Rails 3.1 also loads the turn gem even if, in the Gemfile for the app, turn is declared with `require: false`. This causes a problem while running our tests because turn actually requires minitest/autorun, which adds a hook so when Ruby exits, Minitest tests are run. Because we're already using RSpec, Minitest will try to re-run the `rspec` command we ran within a Minitest environment. This will fail since we are using RSpec-specific command line options to run the tests. Unfortunately there's no way to shut off minitest/autorun after it's been required, so we have to monkey-patch Minitest's #run method so it's a no-op.
2014-05-16 11:57:19 -04:00
gem 'uglifier', '>= 1.3.0'
gem 'coffee-rails', '~> 4.0.0'
gem 'jquery-rails'
gem 'turbolinks'
gem 'sdoc'
Add Appraisal for Rails 4.0.1
2013-12-01 17:57:03 -05:00
gem 'activeresource', '4.0.0'
# Test suite makes heavy use of attr_accessible
gem 'protected_attributes'
Add Cucumber setup for testing standalone Ruby applications
2014-09-12 18:39:00 -04:00
gem 'minitest-reporters'
Add Appraisal for Rails 4.0.1
2013-12-01 17:57:03 -05:00
end
#---
Remove Rails 3.x, Ruby 1.9.2, Ruby 1.9.3 Ruby 1.9.3 will be end-of-lifed on February 23, 2015. We might as well remove support for it now.
2014-10-22 00:35:12 -04:00
appraise '4.0.0' do
instance_eval(&rails_4)
gem 'rails', '4.0.0'
gem 'jbuilder', '~> 1.2'
gem 'sass-rails', '~> 4.0.0'
gem 'bcrypt-ruby', '~> 3.0.0'
Add Appraisals to the project to handle testing against multiple Rails version Note that we also bump RSpec to 2.6.1.beta1 because the incompatibility with Rails 3.1.0.rc1
2011-05-25 14:38:07 -04:00
end
Test against Rails 3.2.
2012-03-09 10:53:23 -05:00
Remove Rails 3.x, Ruby 1.9.2, Ruby 1.9.3 Ruby 1.9.3 will be end-of-lifed on February 23, 2015. We might as well remove support for it now.
2014-10-22 00:35:12 -04:00
appraise '4.0.1' do
instance_eval(&rails_4)
gem 'rails', '4.0.1'
gem 'jbuilder', '~> 1.2'
gem 'sass-rails', '~> 4.0.0'
gem 'bcrypt-ruby', '~> 3.1.2'
Add Rails 4 Appraisal Rails 4 includes strong parameters and removed attr_accessible (protected attributes). I removed the strong_parameters development dependency and added it to all non-4.0 appraisals. I also added the 'protected_attributes' gem to the 4.0 appraisal because the test suite examples make heavy use of attr_accessible.
2013-05-10 13:13:48 -04:00
end
Remove Rails 3.x, Ruby 1.9.2, Ruby 1.9.3 Ruby 1.9.3 will be end-of-lifed on February 23, 2015. We might as well remove support for it now.
2014-10-22 00:35:12 -04:00
appraise '4.1' do
instance_eval(&rails_4)
gem 'rails', '~> 4.1.0'
gem 'jbuilder', '~> 2.0'
gem 'sass-rails', '~> 4.0.3'
gem 'sdoc', '~> 0.4.0'
gem 'bcrypt', '~> 3.1.7'
gem 'protected_attributes', "~> 1.0.6"
gem 'spring'
end
Add Appraisal for Rails 4.2
2014-12-24 16:27:51 -05:00
Remove Rails 3.x, Ruby 1.9.2, Ruby 1.9.3 Ruby 1.9.3 will be end-of-lifed on February 23, 2015. We might as well remove support for it now.
2014-10-22 00:35:12 -04:00
appraise '4.2' do
instance_eval(&rails_4)
gem 'rails', '~> 4.2.0'
gem 'sass-rails', '~> 5.0'
gem 'coffee-rails', '~> 4.1.0'
gem 'jbuilder', '~> 2.0'
gem 'sdoc', '~> 0.4.0'
gem 'bcrypt', '~> 3.1.7'
gem 'spring'
gem 'protected_attributes', "~> 1.0.6"
Add support to rails 4.1.0
2013-12-31 14:54:21 -05:00
end
Copy permalink