1
0
Fork 0
mirror of https://github.com/thoughtbot/shoulda-matchers.git synced 2022-11-09 12:01:38 -05:00

Drop support for RSpec 2

This commit is contained in:
Mauro George 2015-06-25 19:06:21 -03:00 committed by Elliot Winkler
parent 2af1004afe
commit 32c0e62596
25 changed files with 2 additions and 59 deletions

View file

@ -3,10 +3,7 @@
### Backward-incompatible changes
* We've dropped support for Rails 3.x, Ruby 1.9.2, and Ruby 1.9.3, and RSpec 2.
All of these things have been end-of-lifed. This doesn't mean that the gem
will stop working immediately, but we won't accept any pull requests to fix
any compatibility issues, so you're encouraged to upgrade.
([a4045a1], [b7fe87a])
All of these have been end-of-lifed. ([a4045a1], [b7fe87a])
* The gem no longer detects the test framework you're using or mixes itself into
that framework automatically. [History][no-auto-integration-1] has

View file

@ -169,12 +169,10 @@ module Shoulda
def failure_message
"Expected that #{controller_class.name} would have :#{method_name} as a #{kind}_#{callback_type}"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Expected that #{controller_class.name} would not have :#{method_name} as a #{kind}_#{callback_type}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
"have :#{method_name} as a #{kind}_#{callback_type}"

View file

@ -38,12 +38,10 @@ module Shoulda
def failure_message
"Expected #{@key} to be filtered; filtered keys: #{filtered_keys.join(', ')}"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{@key} to be filtered"
end
alias failure_message_for_should_not failure_message_when_negated
def description
"filter #{@key}"

View file

@ -257,12 +257,10 @@ module Shoulda
def failure_message
"Expected #{verb.upcase} ##{action} to #{expectation},\nbut #{reality}."
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Expected #{verb.upcase} ##{action} not to #{expectation},\nbut it did."
end
alias failure_message_for_should_not failure_message_when_negated
protected

View file

@ -43,9 +43,6 @@ module Shoulda
class RedirectToMatcher
attr_reader :failure_message, :failure_message_when_negated
alias failure_message_for_should failure_message
alias failure_message_for_should_not failure_message_when_negated
def initialize(url_or_description, context, &block)
@url_block = nil
@url = nil

View file

@ -34,7 +34,7 @@ module Shoulda
# end
# end
#
#
#
#
# @return [RenderTemplateMatcher]
#
@ -46,9 +46,6 @@ module Shoulda
class RenderTemplateMatcher
attr_reader :failure_message, :failure_message_when_negated
alias failure_message_for_should failure_message
alias failure_message_for_should_not failure_message_when_negated
def initialize(options, message, context)
@options = options
@message = message

View file

@ -88,12 +88,10 @@ module Shoulda
def failure_message
"Expected #{expectation}, but #{result}"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}, but #{result}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
description = 'render with '

View file

@ -62,12 +62,10 @@ module Shoulda
def failure_message
"Expected #{expectation}"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}"
end
alias failure_message_for_should_not failure_message_when_negated
protected

View file

@ -102,12 +102,10 @@ module Shoulda
def failure_message
"Expected #{expectation}"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
"respond with #{@status}"

View file

@ -99,9 +99,6 @@ module Shoulda
attr_reader :failure_message, :failure_message_when_negated
alias failure_message_for_should failure_message
alias failure_message_for_should_not failure_message_when_negated
def to(*args)
@params = RouteParams.new(args).normalize
self

View file

@ -75,9 +75,6 @@ module Shoulda
class AllowMassAssignmentOfMatcher
attr_reader :failure_message, :failure_message_when_negated
alias failure_message_for_should failure_message
alias failure_message_for_should_not failure_message_when_negated
def initialize(attribute)
@attribute = attribute.to_s
@options = {}

View file

@ -272,12 +272,10 @@ module Shoulda
def failure_message
"Did not expect #{expectation},\ngot#{error_description}"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Expected #{expectation},\ngot#{error_description}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
validator.allow_description(allowed_values)

View file

@ -34,12 +34,10 @@ module Shoulda
def failure_message
@allow_matcher.failure_message_when_negated
end
alias failure_message_for_should failure_message
def failure_message_when_negated
@allow_matcher.failure_message
end
alias failure_message_for_should_not failure_message_when_negated
def strict
@allow_matcher.strict

View file

@ -34,8 +34,6 @@ module Shoulda
class HaveSecurePasswordMatcher
attr_reader :failure_message
alias failure_message_for_should failure_message
CORRECT_PASSWORD = "aBcDe12345"
INCORRECT_PASSWORD = "password"

View file

@ -45,12 +45,10 @@ module Shoulda
def failure_message
last_failing_submatcher.failure_message
end
alias failure_message_for_should failure_message
def failure_message_when_negated
last_failing_submatcher.failure_message_when_negated
end
alias failure_message_for_should_not failure_message_when_negated
private

View file

@ -38,12 +38,10 @@ module Shoulda
def failure_message
@disallow_value_matcher.failure_message
end
alias failure_message_for_should failure_message
def failure_message_when_negated
@disallow_value_matcher.failure_message_when_negated
end
alias failure_message_for_should_not failure_message_when_negated
end
end
end

View file

@ -412,12 +412,10 @@ module Shoulda
def failure_message
first_failing_submatcher.failure_message
end
alias failure_message_for_should failure_message
def failure_message_when_negated
first_failing_submatcher.failure_message_when_negated
end
alias failure_message_for_should_not failure_message_when_negated
private

View file

@ -5,8 +5,6 @@ module Shoulda
class ValidationMatcher
attr_reader :failure_message
alias failure_message_for_should failure_message
def initialize(attribute)
@attribute = attribute
@strict = false
@ -27,7 +25,6 @@ module Shoulda
def failure_message_when_negated
@failure_message_when_negated || @failure_message
end
alias failure_message_for_should_not failure_message_when_negated
def matches?(subject)
@subject = subject

View file

@ -127,12 +127,10 @@ module Shoulda
def failure_message
"Expected #{expectation} (#{@problem})"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
description = "accepts_nested_attributes_for :#{@name}"

View file

@ -961,12 +961,10 @@ module Shoulda
def failure_message
"Expected #{expectation} (#{missing_options})"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}"
end
alias failure_message_for_should_not failure_message_when_negated
def matches?(subject)
@subject = subject

View file

@ -118,12 +118,10 @@ module Shoulda
def failure_message
"Expected #{expectation} (#{@missing})"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
desc = "have db column named #{@column}"

View file

@ -89,12 +89,10 @@ module Shoulda
def failure_message
"Expected #{expectation} (#{@missing})"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
if @options.key?(:unique)

View file

@ -32,9 +32,6 @@ module Shoulda
attr_reader :failure_message, :failure_message_when_negated
alias failure_message_for_should failure_message
alias failure_message_for_should_not failure_message_when_negated
def matches?(subject)
@subject = subject
if readonly_attributes.include?(@attribute)

View file

@ -114,12 +114,10 @@ module Shoulda
def failure_message
"Expected #{expectation} (#{@missing})"
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Did not expect #{expectation}"
end
alias failure_message_for_should_not failure_message_when_negated
def description
description = "serialize :#{@name}"

View file

@ -230,12 +230,10 @@ module Shoulda
"#{formatted_delegate_object_reader_method_name(include_module: true)}:" +
formatted_calls_on_delegate_object
end
alias failure_message_for_should failure_message
def failure_message_when_negated
"Expected #{class_under_test} not to #{description}, but it did"
end
alias failure_message_for_should_not failure_message_when_negated
protected