1
0
Fork 0
mirror of https://github.com/thoughtbot/shoulda-matchers.git synced 2022-11-09 12:01:38 -05:00
Commit graph

5 commits

Author SHA1 Message Date
Elliot Winkler
db7723d925 Add minitest to Rails 3.x appraisals
The minitest dependency is necessary in order to write Cucumber tests
that depend on Minitest.
2014-10-08 01:04:20 -06:00
Elliot Winkler
eb4d9e5cb2 Bump version to 2.7.0 2014-09-03 00:38:41 -06:00
Pedro Nascimento
1f24f04da3 Using RSpec 3 for development. 2014-08-14 12:16:54 -04:00
Elliot Winkler
888665745f Bump version to 2.6.2 2014-07-18 18:08:30 -06:00
Elliot Winkler
12543ede2e Use same assertion class as Rails, if loaded
Given this scenario:

* Using Rails 4.1
* Gemfile has `gem 'shoulda-matchers', require: false`
* spec_helper has `require 'shoulda/matchers'` following
  `require 'rspec/rails'`
* Using Spring to run tests

matchers that delegate to assertions in Rails (e.g. `render_template`
and `route`) will fail in the wrong way if used. They fail because in
order to use these assertions, we expect that the assertions will
raise a specific exception, an exception that corresponds to whichever
test framework that Rails is using. For Rails versions that used
Test::Unit, this is Test::Unit::AssertionFailedError. For current Rails
versions, which now use Minitest, this exception is Minitest::Assertion.

The problem is that instead of asking Rails which exception class it's
using, we are trying to detect this exception class ourselves (for
cases in which Rails is not being used). This leads to the wrong class
being detected: when using a Rails version that uses Minitest, we choose
Test::Unit::AssertionFailedError as the class. This happens using the
exact scenario above because even though shoulda-matchers is loaded
after rspec-rails, rspec-rails itself defines
Test::Unit::AssertionFailedError.

Also add Cucumber tests that confirms this exact scenario works.
2014-06-27 14:06:47 -06:00