Commit Graph

18 Commits

Author SHA1 Message Date
Pedro Paiva d39685139f
Add Appraisal for Rails 6.1 (#1418)
* Add Appraisal for Rails 6.1

* Upgrade Rails

* fix: standardize error message of association matcher

* Bump listen version to v3.5.1

* Fix the wrong number of arguments (given 2, expected 1)

* Remove deprecated method

* Update Rails to 6.1.3.2

* Remove test for ActiveModel::Errors#generate_message

* Missing ':through' option for has_many association.

* Fix the actual_foreign_key method that is returning a string instead of an array of foreign keys

* Fix Bundler::GemNotFound: Could not find gem 'puma (~> 5.0)'

* Fix Bundler::GemNotFound: Could not find gem 'rack-mini-profiler (~> 2.0)'

* Bump rspec-rails to 4.1.2

* Fix 'rails generate' not working with Rails 6.1
2021-06-03 17:41:27 -03:00
Pedro Paiva 3da09563b1
Upgrade Rails (#1440) 2021-05-05 20:20:45 -03:00
Pedro Paiva 8dea981df0
Add Ruby 3.0 support (#1427)
* Fix warning: Using the last argument as keyword parameters is deprecated

* Add ruby 3.0 support

* Update listen to support ruby 3.0

* Prevent CI testing Ruby 3.0 with Rails 5.x

* Fix action/cache key

* Update nokogiri

* Use Ruby 3.0.1 for development

* Remove webdrivers gem
2021-04-09 22:56:49 -03:00
Pedro Paiva 21bc474674
Upgrade Rails (#1434) 2021-03-31 15:30:50 -03:00
Pedro Paiva 178df4970c
Update dependencies (#1411) 2021-02-28 04:24:06 -03:00
Kapil Sachdev b7e02184d9 fix(rubocop): Fix Layout/LineLength
- bump rubocop to v1.0
- Fix Layout/MultilineAssignmentLayout and other remaining offences
- Exculde appraisal generated gemfiles in rubocop
- Replace NON_NUMERIC_VALUE constant with instance method against 
failing test case in  rails <= 5.1 and postgres adapter.
This is a defect in rails where a frozen string is modified in 
https://github.com/rails/rails/blob/v5.1.7/activerecord/lib/active_record/connection_adapters/postgresql/oid/money.rb#L25
2020-11-03 10:05:25 -07:00
Kapil Sachdev 278a381ae8 fix(docs): Migrate to rouge [ci skip] 2020-09-01 09:20:16 -06:00
Pedro Paiva 9733122ce3 Bump Rubocop from 0.71.0 to 0.89.1
Fix warning: The Metrics/LineLength has the wrong namespace - should be Layout

Fix warning: The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`.

Fix warning: The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`.

Fix warning: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`.

Fix warning: The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`.

Set new cops as disable for default
2020-08-31 16:39:04 -06:00
Elliot Winkler 412ea1f936 Use warnings_logger instead of warnings_spy
`warnings_spy` was a little library I wrote to report warnings that came
up during test runs and fail the CI build. A while back I extracted it
to `warnings_logger`, so the version that exists here is obsolete.
2020-08-23 22:58:51 -06:00
Adam Hanna 47ca444120 Remove webpacker from CI
- Remove webpacker gem from Appraisals for version 6.0.
 - Remove nvm installation before running CI tests
 - On acceptance tests, generate apps without webpacker

Conditionally include --skip-javascript in rails 6.0
2020-07-24 22:54:11 -06:00
Elliot Winkler f50f70e9c8 Upgrade pry, pry-byebug, and method_source for Zeus 2020-07-07 23:31:02 -06:00
Elliot Winkler 693c2976c3 Update rack to 2.2.2
This includes a fix for CVE-2020-8161.
2020-06-13 23:32:59 -06:00
Pedro Paiva 0b23942feb Add have_rich_text_matcher
The `have_rich_text` matcher tests usage of the `has_rich_text` macro that was added in Rails 6.
2020-01-23 09:29:57 -07:00
Gui Vieira d97bdd6cab
Update test versions and dependencies (#1269) 2020-01-01 12:20:50 -08:00
Vít Ondruch 984ce7340b Remove minitest reporters (#1251) 2019-11-18 18:45:13 -08:00
Elliot Winkler ceeca818e0 Update RSpec to 3.8.x 2019-07-25 23:47:50 -07:00
Elliot Winkler d77cba3521 Update Rubocop across Appraisals 2019-06-09 12:19:21 -06:00
Elliot Winkler ae9bf4a735 Add minimal support for Rails 6
* Add Rails 6 appraisal to start testing against it.
* Fix usage of Module#parent as this is deprecated in Rails 6 in favor
  of Module#module_parent.
* Ensure that we're using the correct version of `sqlite3` and `pg` at
  all times
* When creating classes within tests, ensure that they are removed
  correctly
* Fix detection of has_secure_password in models: Check that
  InstanceMethodsOnActivation is specifically defined, as Rails 6 no
  longer has such a module.

Co-authored-by: Lee Machin <me@mrl.ee>
2019-04-22 00:10:18 -04:00