mirror of
https://github.com/thoughtbot/shoulda-matchers.git
synced 2022-11-09 12:01:38 -05:00
2e35b3730e
This is part of a collection of commits that aim to improve failure messages across the board, in order to make matchers easier to debug when something goes wrong. * Make the description of the matcher more readable. * Add boolean methods to check whether `allow_nil` or `allow_blank` have been specified, to conform to the interface that ValidationMatcher introduces. * Fix or fill in tests involving failure messages and descriptions to match these changes and recent changes to ValidationMatcher and allow_value.
208 lines
5.8 KiB
Ruby
208 lines
5.8 KiB
Ruby
module Shoulda
|
|
module Matchers
|
|
module ActiveModel
|
|
# The `validate_exclusion_of` matcher tests usage of the
|
|
# `validates_exclusion_of` validation, asserting that an attribute cannot
|
|
# take a blacklist of values, and inversely, can take values outside of
|
|
# this list.
|
|
#
|
|
# If your blacklist is an array of values, use `in_array`:
|
|
#
|
|
# class Game
|
|
# include ActiveModel::Model
|
|
# attr_accessor :supported_os
|
|
#
|
|
# validates_exclusion_of :supported_os, in: ['Mac', 'Linux']
|
|
# end
|
|
#
|
|
# # RSpec
|
|
# describe Game do
|
|
# it do
|
|
# should validate_exclusion_of(:supported_os).
|
|
# in_array(['Mac', 'Linux'])
|
|
# end
|
|
# end
|
|
#
|
|
# # Minitest (Shoulda)
|
|
# class GameTest < ActiveSupport::TestCase
|
|
# should validate_exclusion_of(:supported_os).
|
|
# in_array(['Mac', 'Linux'])
|
|
# end
|
|
#
|
|
# If your blacklist is a range of values, use `in_range`:
|
|
#
|
|
# class Game
|
|
# include ActiveModel::Model
|
|
# attr_accessor :supported_os
|
|
#
|
|
# validates_exclusion_of :supported_os, in: ['Mac', 'Linux']
|
|
# end
|
|
#
|
|
# # RSpec
|
|
# describe Game do
|
|
# it do
|
|
# should validate_exclusion_of(:floors_with_enemies).
|
|
# in_range(5..8)
|
|
# end
|
|
# end
|
|
#
|
|
# # Minitest (Shoulda)
|
|
# class GameTest < ActiveSupport::TestCase
|
|
# should validate_exclusion_of(:floors_with_enemies).
|
|
# in_range(5..8)
|
|
# end
|
|
#
|
|
# #### Qualifiers
|
|
#
|
|
# ##### on
|
|
#
|
|
# Use `on` if your validation applies only under a certain context.
|
|
#
|
|
# class Game
|
|
# include ActiveModel::Model
|
|
# attr_accessor :weapon
|
|
#
|
|
# validates_exclusion_of :weapon,
|
|
# in: ['pistol', 'paintball gun', 'stick'],
|
|
# on: :create
|
|
# end
|
|
#
|
|
# # RSpec
|
|
# describe Game do
|
|
# it do
|
|
# should validate_exclusion_of(:weapon).
|
|
# in_array(['pistol', 'paintball gun', 'stick']).
|
|
# on(:create)
|
|
# end
|
|
# end
|
|
#
|
|
# # Minitest (Shoulda)
|
|
# class GameTest < ActiveSupport::TestCase
|
|
# should validate_exclusion_of(:weapon).
|
|
# in_array(['pistol', 'paintball gun', 'stick']).
|
|
# on(:create)
|
|
# end
|
|
#
|
|
# ##### with_message
|
|
#
|
|
# Use `with_message` if you are using a custom validation message.
|
|
#
|
|
# class Game
|
|
# include ActiveModel::Model
|
|
# attr_accessor :weapon
|
|
#
|
|
# validates_exclusion_of :weapon,
|
|
# in: ['pistol', 'paintball gun', 'stick'],
|
|
# message: 'You chose a puny weapon'
|
|
# end
|
|
#
|
|
# # RSpec
|
|
# describe Game do
|
|
# it do
|
|
# should validate_exclusion_of(:weapon).
|
|
# in_array(['pistol', 'paintball gun', 'stick']).
|
|
# with_message('You chose a puny weapon')
|
|
# end
|
|
# end
|
|
#
|
|
# # Minitest (Shoulda)
|
|
# class GameTest < ActiveSupport::TestCase
|
|
# should validate_exclusion_of(:weapon).
|
|
# in_array(['pistol', 'paintball gun', 'stick']).
|
|
# with_message('You chose a puny weapon')
|
|
# end
|
|
#
|
|
# @return [ValidateExclusionOfMatcher]
|
|
#
|
|
def validate_exclusion_of(attr)
|
|
ValidateExclusionOfMatcher.new(attr)
|
|
end
|
|
|
|
# @private
|
|
class ValidateExclusionOfMatcher < ValidationMatcher
|
|
def initialize(attribute)
|
|
super(attribute)
|
|
@expected_message = :exclusion
|
|
@array = nil
|
|
@range = nil
|
|
end
|
|
|
|
def in_array(array)
|
|
@array = array
|
|
self
|
|
end
|
|
|
|
def in_range(range)
|
|
@range = range
|
|
@minimum = range.first
|
|
@maximum = range.max
|
|
self
|
|
end
|
|
|
|
def simple_description
|
|
if @range
|
|
"validate that :#{@attribute} lies outside the range #{@range.inspect}"
|
|
else
|
|
description = "validate that :#{@attribute}"
|
|
|
|
if @array.many?
|
|
description << " is neither " + @array.map(&:inspect).to_sentence(
|
|
two_words_connector: " nor ",
|
|
last_word_connector: ", nor "
|
|
)
|
|
else
|
|
description << " is not #{@array.first.inspect}"
|
|
end
|
|
|
|
description
|
|
end
|
|
end
|
|
|
|
def matches?(subject)
|
|
super(subject)
|
|
|
|
if @range
|
|
allows_lower_value &&
|
|
disallows_minimum_value &&
|
|
allows_higher_value &&
|
|
disallows_maximum_value
|
|
elsif @array
|
|
disallows_all_values_in_array?
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def disallows_all_values_in_array?
|
|
@array.all? do |value|
|
|
disallows_value_of(value, @expected_message)
|
|
end
|
|
end
|
|
|
|
def allows_lower_value
|
|
@minimum == 0 || allows_value_of(@minimum - 1, @expected_message)
|
|
end
|
|
|
|
def allows_higher_value
|
|
allows_value_of(@maximum + 1, @expected_message)
|
|
end
|
|
|
|
def disallows_minimum_value
|
|
disallows_value_of(@minimum, @expected_message)
|
|
end
|
|
|
|
def disallows_maximum_value
|
|
disallows_value_of(@maximum, @expected_message)
|
|
end
|
|
|
|
def inspect_message
|
|
if @range
|
|
@range.inspect
|
|
else
|
|
@array.inspect
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|