kotovalexarian-likes-github
/
twbs--bootstrap
mirror of https://github.com/twbs/bootstrap.git
1
0
Fork 0
Code Releases Activity

Remove `Manipulator.toggleClass` (#31842) 

It's only used in one place so it makes more sense to remove it for the time being.
This commit is contained in:
XhmikosR 2020-10-05 18:07:49 +03:00 committed by GitHub
parent 00dd55269a
commit 0c1651ee9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/src/dom/manipulator.js
View File

@ -72,18 +72,6 @@ const Manipulator = {
top: element.offsetTop,
left: element.offsetLeft
}
},
toggleClass(element, className) {
if (!element) {
return
}
if (element.classList.contains(className)) {
element.classList.remove(className)
} else {
element.classList.add(className)
}
}
}

8
js/src/dropdown.js
View File

@ -197,8 +197,8 @@ class Dropdown {
this._element.focus()
this._element.setAttribute('aria-expanded', true)
Manipulator.toggleClass(this._menu, CLASS_NAME_SHOW)
Manipulator.toggleClass(this._element, CLASS_NAME_SHOW)
this._menu.classList.toggle(CLASS_NAME_SHOW)
this._element.classList.toggle(CLASS_NAME_SHOW)
EventHandler.trigger(parent, EVENT_SHOWN, relatedTarget)
}
@ -222,8 +222,8 @@ class Dropdown {
this._popper.destroy()
}
Manipulator.toggleClass(this._menu, CLASS_NAME_SHOW)
Manipulator.toggleClass(this._element, CLASS_NAME_SHOW)
this._menu.classList.toggle(CLASS_NAME_SHOW)
this._element.classList.toggle(CLASS_NAME_SHOW)
EventHandler.trigger(parent, EVENT_HIDDEN, relatedTarget)
}

26
js/tests/unit/dom/manipulator.spec.js
View File

@ -129,30 +129,4 @@ describe('Manipulator', () => {
expect(position.left).toEqual(jasmine.any(Number))
})
})
describe('toggleClass', () => {
it('should not error out if element is null or undefined', () => {
Manipulator.toggleClass(null, 'test')
Manipulator.toggleClass(undefined, 'test')
expect().nothing()
})
it('should add class if it is missing', () => {
fixtureEl.innerHTML = '<div></div>'
const div = fixtureEl.querySelector('div')
Manipulator.toggleClass(div, 'test')
expect(div.classList.contains('test')).toEqual(true)
})
it('should remove class if it is set', () => {
fixtureEl.innerHTML = '<div class="test"></div>'
const div = fixtureEl.querySelector('div')
Manipulator.toggleClass(div, 'test')
expect(div.classList.contains('test')).toEqual(false)
})
})
})