From f2344962396727fd9ec4b8d2023d60e711506f0a Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sat, 1 Feb 2014 23:19:16 -0800 Subject: [PATCH 1/2] add note to CONTRIBUTING.md about `outline: none` --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7d7b0fb6a6..9460c8db7a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -174,6 +174,7 @@ license your work under the terms of the [MIT License](LICENSE.md). - Series of classes for a component should include a base class (e.g., `.component`) and use the base class as a prefix for modifier and sub-components (e.g., `.component-lg`). - Avoid inheritance and over nesting—use single, explicit classes whenever possible. - When feasible, default color palettes should comply with [WCAG color contrast guidelines](http://www.w3.org/TR/WCAG20/#visual-audio-contrast). +- Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](http://a11yproject.com/posts/never-remove-css-outlines/) for more details. ### JS From b16efebc8eadb4e57899c80b19cd9cf25af3bfa8 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Tue, 4 Feb 2014 01:51:40 -0800 Subject: [PATCH 2/2] disable OS X Chrome in Selenium tests to fix the build --- browserstack.json | 6 ------ test-infra/sauce_browsers.yml | 10 +++++----- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/browserstack.json b/browserstack.json index beab742e1f..6ca781e5fc 100644 --- a/browserstack.json +++ b/browserstack.json @@ -16,12 +16,6 @@ "os": "OS X", "os_version": "Mavericks" }, - { - "browser": "chrome", - "browser_version": "latest", - "os": "OS X", - "os_version": "Mavericks" - }, { "browser": "firefox", "browser_version": "latest", diff --git a/test-infra/sauce_browsers.yml b/test-infra/sauce_browsers.yml index 9ec9c4cb1e..4c1e011d30 100644 --- a/test-infra/sauce_browsers.yml +++ b/test-infra/sauce_browsers.yml @@ -5,11 +5,11 @@ browserName: "safari", platform: "OS X 10.9" }, - { - browserName: "chrome", - platform: "OS X 10.9", - version: "31" - }, + # { + # browserName: "chrome", + # platform: "OS X 10.9", + # version: "31" + # }, { browserName: "firefox", platform: "OS X 10.9"