From 1f490ec165be0271b739053f8f5c7af3a75e63e9 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Mon, 15 Jan 2018 20:51:01 +0000 Subject: [PATCH] Consistently use `:disabled` rather than `[disabled]` selector (#25317) Closes https://github.com/twbs/bootstrap/issues/25316 --- scss/_buttons.scss | 8 ++++---- scss/_close.scss | 2 +- scss/_navbar.scss | 2 +- scss/_pagination.scss | 2 +- scss/mixins/_buttons.scss | 8 ++++---- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/scss/_buttons.scss b/scss/_buttons.scss index 3a5f5ee85b..41b7068224 100644 --- a/scss/_buttons.scss +++ b/scss/_buttons.scss @@ -34,12 +34,12 @@ } // Opinionated: add "hand" cursor to non-disabled .btn elements - &:not([disabled]):not(.disabled) { + &:not(:disabled):not(.disabled) { cursor: pointer; } - &:not([disabled]):not(.disabled):active, - &:not([disabled]):not(.disabled).active { + &:not(:disabled):not(.disabled):active, + &:not(:disabled):not(.disabled).active { background-image: none; @include box-shadow($btn-active-box-shadow); @@ -51,7 +51,7 @@ // Future-proof disabling of clicks on `` elements a.btn.disabled, -fieldset[disabled] a.btn { +fieldset:disabled a.btn { pointer-events: none; } diff --git a/scss/_close.scss b/scss/_close.scss index f1763cc224..871cb08fd8 100644 --- a/scss/_close.scss +++ b/scss/_close.scss @@ -14,7 +14,7 @@ } // Opinionated: add "hand" cursor to non-disabled .close elements - &:not([disabled]):not(.disabled) { + &:not(:disabled):not(.disabled) { cursor: pointer; } } diff --git a/scss/_navbar.scss b/scss/_navbar.scss index 677a2753f6..8d68c6c8c4 100644 --- a/scss/_navbar.scss +++ b/scss/_navbar.scss @@ -118,7 +118,7 @@ } // Opinionated: add "hand" cursor to non-disabled .navbar-toggler elements - &:not([disabled]):not(.disabled) { + &:not(:disabled):not(.disabled) { cursor: pointer; } } diff --git a/scss/_pagination.scss b/scss/_pagination.scss index b0193d170e..959b2eb4ba 100644 --- a/scss/_pagination.scss +++ b/scss/_pagination.scss @@ -28,7 +28,7 @@ } // Opinionated: add "hand" cursor to non-disabled .page-link elements - &:not([disabled]):not(.disabled) { + &:not(:disabled):not(.disabled) { cursor: pointer; } } diff --git a/scss/mixins/_buttons.scss b/scss/mixins/_buttons.scss index e6ccbc6d48..1cbe671221 100644 --- a/scss/mixins/_buttons.scss +++ b/scss/mixins/_buttons.scss @@ -33,8 +33,8 @@ border-color: $border; } - &:not([disabled]):not(.disabled):active, - &:not([disabled]):not(.disabled).active, + &:not(:disabled):not(.disabled):active, + &:not(:disabled):not(.disabled).active, .show > &.dropdown-toggle { color: color-yiq($active-background); background-color: $active-background; @@ -77,8 +77,8 @@ background-color: transparent; } - &:not([disabled]):not(.disabled):active, - &:not([disabled]):not(.disabled).active, + &:not(:disabled):not(.disabled):active, + &:not(:disabled):not(.disabled).active, .show > &.dropdown-toggle { color: color-yiq($active-background); background-color: $active-background;