Use ref instead of label when checking branches in issue-guidelines
This commit is contained in:
parent
31b30ab88e
commit
1f70dd71c8
|
@ -24,11 +24,11 @@ module.exports = {
|
||||||
'pull-requests': {
|
'pull-requests': {
|
||||||
|
|
||||||
'should always be made against -wip branches': function (pull) {
|
'should always be made against -wip branches': function (pull) {
|
||||||
assert.ok(/\-wip$/.test(pull.base.label))
|
assert.ok(/\-wip$/.test(pull.base.ref))
|
||||||
},
|
},
|
||||||
|
|
||||||
'should always be made from feature branches': function (pull) {
|
'should always be made from feature branches': function (pull) {
|
||||||
assert.ok(pull.head.label != 'master')
|
assert.notEqual(pull.head.ref, 'master')
|
||||||
},
|
},
|
||||||
|
|
||||||
'should always include a unit test if changing js files': function (pull) {
|
'should always include a unit test if changing js files': function (pull) {
|
||||||
|
@ -36,7 +36,7 @@ module.exports = {
|
||||||
var hasTests = false
|
var hasTests = false
|
||||||
|
|
||||||
pull.files.forEach(function (file) {
|
pull.files.forEach(function (file) {
|
||||||
if (/^js\/[^./]+.js/.test(file.filename)) hasJS = true
|
if (/^js\/[^./]+.js/.test(file.filename)) hasJS = true
|
||||||
if (/^js\/tests\/unit\/[^.]+.js/.test(file.filename)) hasTests = true
|
if (/^js\/tests\/unit\/[^.]+.js/.test(file.filename)) hasTests = true
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue