Dropdown: rename vars

This commit is contained in:
GeoSot 2021-10-10 16:39:47 +03:00 committed by XhmikosR
parent 0686fa00f0
commit 21e5618ba7
1 changed files with 8 additions and 6 deletions

View File

@ -405,21 +405,23 @@ class Dropdown extends BaseComponent {
// - If trigger inside the menu => not a dropdown command
const isInput = /input|textarea/i.test(event.target.tagName)
const eventKey = event.key
if (!isInput && ![ARROW_UP_KEY, ARROW_DOWN_KEY, ESCAPE_KEY].includes(eventKey)) {
const isEscapeEvent = event.key === ESCAPE_KEY
const isUpOrDownEvent = [ARROW_UP_KEY, ARROW_DOWN_KEY].includes(event.key)
if (!isInput && !(isUpOrDownEvent || isEscapeEvent)) {
return
}
if (isInput) {
// eslint-disable-next-line unicorn/no-lonely-if
if (eventKey !== ESCAPE_KEY && (![ARROW_UP_KEY, ARROW_DOWN_KEY].includes(eventKey) || event.target.closest(SELECTOR_MENU))) {
if (!isEscapeEvent && (!isUpOrDownEvent || event.target.closest(SELECTOR_MENU))) {
return
}
}
const isActive = this.classList.contains(CLASS_NAME_SHOW)
if (!isActive && event.key === ESCAPE_KEY) {
if (!isActive && isEscapeEvent) {
return
}
@ -433,12 +435,12 @@ class Dropdown extends BaseComponent {
const getToggleButton = this.matches(SELECTOR_DATA_TOGGLE) ? this : SelectorEngine.prev(this, SELECTOR_DATA_TOGGLE)[0]
const instance = Dropdown.getOrCreateInstance(getToggleButton)
if (event.key === ESCAPE_KEY) {
if (isEscapeEvent) {
instance.hide()
return
}
if (event.key === ARROW_UP_KEY || event.key === ARROW_DOWN_KEY) {
if (isUpOrDownEvent) {
instance.show()
instance._selectMenuItem(event)
}