From 2732a60ecdc23578f6f0c0113271fbd047b707a2 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 10 Mar 2021 18:47:42 +0200 Subject: [PATCH] @rollup/plugin-replace: specify `preventAssignment: true` (#33329) This is to fix a warning since the option will be set to true in the next major version of the plugin --- build/rollup.config.js | 8 +++++++- js/tests/integration/rollup.bundle.js | 3 ++- js/tests/karma.conf.js | 3 ++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/build/rollup.config.js b/build/rollup.config.js index 7f9c1c7e11..8cecec9aa2 100644 --- a/build/rollup.config.js +++ b/build/rollup.config.js @@ -28,7 +28,13 @@ if (BUNDLE) { // Remove last entry in external array to bundle Popper external.pop() delete globals['@popperjs/core'] - plugins.push(replace({ 'process.env.NODE_ENV': '"production"' }), nodeResolve()) + plugins.push( + replace({ + 'process.env.NODE_ENV': '"production"', + preventAssignment: true + }), + nodeResolve() + ) } const rollupConfig = { diff --git a/js/tests/integration/rollup.bundle.js b/js/tests/integration/rollup.bundle.js index 288f40961d..caddcab484 100644 --- a/js/tests/integration/rollup.bundle.js +++ b/js/tests/integration/rollup.bundle.js @@ -12,7 +12,8 @@ module.exports = { }, plugins: [ replace({ - 'process.env.NODE_ENV': '"production"' + 'process.env.NODE_ENV': '"production"', + preventAssignment: true }), nodeResolve(), babel({ diff --git a/js/tests/karma.conf.js b/js/tests/karma.conf.js index c13413449d..67b60f15ee 100644 --- a/js/tests/karma.conf.js +++ b/js/tests/karma.conf.js @@ -77,7 +77,8 @@ const conf = { rollupPreprocessor: { plugins: [ replace({ - 'process.env.NODE_ENV': '"dev"' + 'process.env.NODE_ENV': '"dev"', + preventAssignment: true }), istanbul({ exclude: [