From 28ba9d69c82895bbd9a1d66cea855119f4aba349 Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sat, 28 Jan 2012 11:21:39 -0800 Subject: [PATCH] nav, buttons, and docs updates to account for outline: 0; on :active --- docs/assets/css/bootstrap.css | 18 ++++++++---------- docs/assets/css/docs.css | 17 +++++++++++++++-- less/button-groups.less | 7 +++++++ less/buttons.less | 1 + less/dropdowns.less | 6 +++++- less/mixins.less | 4 ---- 6 files changed, 36 insertions(+), 17 deletions(-) diff --git a/docs/assets/css/bootstrap.css b/docs/assets/css/bootstrap.css index 7a55680417..bc4961b054 100644 --- a/docs/assets/css/bootstrap.css +++ b/docs/assets/css/bootstrap.css @@ -36,9 +36,6 @@ a:focus { outline: thin dotted; outline: 5px auto -webkit-focus-ring-color; outline-offset: -2px; - -moz-outline: 5px auto -moz-mac-focusring; - -moz-outline-radius: 6px; - -moz-outline-offset: 0; } a:hover, a:active { outline: 0; @@ -627,9 +624,6 @@ input[type="file"]:focus, input[type="checkbox"]:focus, select:focus { outline: thin dotted; outline: 5px auto -webkit-focus-ring-color; outline-offset: -2px; - -moz-outline: 5px auto -moz-mac-focusring; - -moz-outline-radius: 6px; - -moz-outline-offset: 0; } .input-mini { width: 60px; @@ -1490,9 +1484,12 @@ table .span12 { .dropdown { position: relative; } -.dropdown .dropdown-toggle { +.dropdown-toggle { *margin-bottom: -3px; } +.dropdown-toggle:active, .open .dropdown-toggle { + outline: 0; +} .caret { display: inline-block; width: 0; @@ -2641,9 +2638,6 @@ table .span12 { outline: thin dotted; outline: 5px auto -webkit-focus-ring-color; outline-offset: -2px; - -moz-outline: 5px auto -moz-mac-focusring; - -moz-outline-radius: 6px; - -moz-outline-offset: 0; } .btn.active, .btn:active { background-image: none; @@ -2653,6 +2647,7 @@ table .span12 { background-color: #e6e6e6; background-color: #d9d9d9 \9; color: rgba(0, 0, 0, 0.5); + outline: 0; } .btn.disabled, .btn[disabled] { cursor: default; @@ -2776,6 +2771,9 @@ button.btn.small, input[type="submit"].btn.small { .btn-group .btn.active { z-index: 2; } +.btn-group .dropdown-toggle:active, .btn-group.open .dropdown-toggle { + outline: 0; +} .btn-group .dropdown-toggle { padding-left: 8px; padding-right: 8px; diff --git a/docs/assets/css/docs.css b/docs/assets/css/docs.css index 0b221e3b26..8c92f087f1 100644 --- a/docs/assets/css/docs.css +++ b/docs/assets/css/docs.css @@ -173,10 +173,9 @@ hr.soften { } .subnav .nav > li > a { margin: 0; - padding-top: 11px; + padding-top: 11px; padding-bottom: 11px; font-size: 13px; - text-shadow: 0 1px 0 rgba(255,255,255,.5); border-left: 1px solid #f5f5f5; border-right: 1px solid #e5e5e5; -webkit-border-radius: 0; @@ -202,10 +201,18 @@ hr.soften { .subnav .nav > li:first-child > a:hover { border-left: 0; padding-left: 12px; + -webkit-border-radius: 4px 0 0 4px; + -moz-border-radius: 4px 0 0 4px; + border-radius: 4px 0 0 4px; } .subnav .nav > li:last-child > a { border-right: 0; } +.subnav .dropdown-menu { + -webkit-border-radius: 0 0 4px 4px; + -moz-border-radius: 0 0 4px 4px; + border-radius: 0 0 4px 4px; +} /* Fixed subnav on scroll, but only for 940px and up (sorry IE!) */ @media (min-width: 940px) { @@ -229,6 +236,12 @@ hr.soften { margin: 0 auto; padding: 0 1px; } + .subnav .nav > li:first-child > a, + .subnav .nav > li:first-child > a:hover { + -webkit-border-radius: 0; + -moz-border-radius: 0; + border-radius: 0; + } } diff --git a/less/button-groups.less b/less/button-groups.less index 3e08e6b092..7367103caa 100644 --- a/less/button-groups.less +++ b/less/button-groups.less @@ -78,6 +78,13 @@ z-index: 2; } +// On active and open, don't show outline +.btn-group .dropdown-toggle:active, +.btn-group.open .dropdown-toggle { + outline: 0; +} + + // Split button dropdowns // ---------------------- diff --git a/less/buttons.less b/less/buttons.less index f1060dc6bb..54d00a13ac 100644 --- a/less/buttons.less +++ b/less/buttons.less @@ -88,6 +88,7 @@ background-color: darken(@white, 10%); background-color: darken(@white, 15%) e("\9"); color: rgba(0,0,0,.5); + outline: 0; } &.disabled, &[disabled] { diff --git a/less/dropdowns.less b/less/dropdowns.less index e73b056e96..83f535ae86 100644 --- a/less/dropdowns.less +++ b/less/dropdowns.less @@ -5,10 +5,14 @@ .dropdown { position: relative; } -.dropdown .dropdown-toggle { +.dropdown-toggle { // The caret makes the toggle a bit too tall in IE7 *margin-bottom: -3px; } +.dropdown-toggle:active, +.open .dropdown-toggle { + outline: 0; +} // Dropdown arrow/caret .caret { display: inline-block; diff --git a/less/mixins.less b/less/mixins.less index 2ed28ac3f3..ddf1003599 100644 --- a/less/mixins.less +++ b/less/mixins.less @@ -29,10 +29,6 @@ // Webkit outline: 5px auto -webkit-focus-ring-color; outline-offset: -2px; - // Firefox - -moz-outline: 5px auto -moz-mac-focusring; - -moz-outline-radius: 6px; - -moz-outline-offset: 0; } // Center-align a block level element