From 5fd7bc1554d492bdd5794d35fce515fe951439a6 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 2 Jun 2015 09:41:40 +0100 Subject: [PATCH] generalize dropdowns / drop role="menu" as role="menu" is a very specific (and strict) ARIA pattern for desktop-like application menus, and our dropdowns are often used as pure navigation dropdowns, this change abandons ARIA menus for a more open-ended and light-weight approach (see http://heydonworks.com/practical_aria_examples/#submenus and http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria) note that in dropdown.js, switched to now target ``.dropdown-menu`` instead of ``role["menu"]`` - this also prevents bootstrap scripts from "bleeding" into non-bootstrap components on the same page. also removed the ``role=["listbox"]`` part, which appears to be vestigial/unused (only place in bootstrap that uses that role are carousels, and their key handling is done separately) --- .../components/button-dropdowns.html | 92 ++++++++--------- docs/_includes/components/button-groups.html | 28 +++--- docs/_includes/components/dropdowns.html | 98 +++++++++---------- docs/_includes/components/input-groups.html | 24 ++--- docs/_includes/components/navbar.html | 16 +-- docs/_includes/components/navs.html | 16 +-- docs/_includes/js/dropdowns.html | 78 +++++++-------- docs/_includes/js/scrollspy.html | 10 +- docs/_includes/js/tabs.html | 6 +- docs/examples/carousel/index.html | 4 +- docs/examples/navbar-fixed-top/index.html | 4 +- docs/examples/navbar-static-top/index.html | 4 +- docs/examples/navbar/index.html | 4 +- docs/examples/non-responsive/index.html | 4 +- docs/examples/sticky-footer-navbar/index.html | 4 +- docs/examples/theme/index.html | 24 ++--- js/dropdown.js | 2 +- js/tests/unit/dropdown.js | 10 +- js/tests/visual/dropdown.html | 70 ++++++------- js/tests/visual/scrollspy.html | 12 +-- js/tests/visual/tab.html | 32 +++--- 21 files changed, 271 insertions(+), 271 deletions(-) diff --git a/docs/_includes/components/button-dropdowns.html b/docs/_includes/components/button-dropdowns.html index 5f7b7d94f0..6f621086ea 100644 --- a/docs/_includes/components/button-dropdowns.html +++ b/docs/_includes/components/button-dropdowns.html @@ -12,8 +12,8 @@

Turn a button into a dropdown toggle with some basic markup changes.

- -
- -
- -
- -
- -
- -