From bcfb7ed159ee79b1d362c8ce0ef09fd53bef27f3 Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Thu, 7 Feb 2019 18:19:00 +0100 Subject: [PATCH] Deprecate `invisible()` mixin (#28066) --- scss/mixins/_visibility.scss | 1 + scss/utilities/_visibility.scss | 6 ++++-- site/docs/4.2/utilities/visibility.md | 5 +++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/scss/mixins/_visibility.scss b/scss/mixins/_visibility.scss index fe523d0ee3..f174673117 100644 --- a/scss/mixins/_visibility.scss +++ b/scss/mixins/_visibility.scss @@ -4,4 +4,5 @@ @mixin invisible($visibility) { visibility: $visibility !important; + @include deprecate("`invisible()`", "v4.3.0", "v5"); } diff --git a/scss/utilities/_visibility.scss b/scss/utilities/_visibility.scss index 823406dc3c..7756c3bfac 100644 --- a/scss/utilities/_visibility.scss +++ b/scss/utilities/_visibility.scss @@ -1,11 +1,13 @@ +// stylelint-disable declaration-no-important + // // Visibility utilities // .visible { - @include invisible(visible); + visibility: visible !important; } .invisible { - @include invisible(hidden); + visibility: hidden !important; } diff --git a/site/docs/4.2/utilities/visibility.md b/site/docs/4.2/utilities/visibility.md index cb02e1b88c..bbfc0cbbc6 100644 --- a/site/docs/4.2/utilities/visibility.md +++ b/site/docs/4.2/utilities/visibility.md @@ -17,13 +17,14 @@ Apply `.visible` or `.invisible` as needed. {% highlight scss %} // Class .visible { - visibility: visible; + visibility: visible !important; } .invisible { - visibility: hidden; + visibility: hidden !important; } // Usage as a mixin +// Warning: The `invisible()` mixin has been deprecated as of v4.3.0. It will be removed entirely in v5. .element { @include invisible(visible); }