From be1232c5800a7d3f26c4b618a7d84f65f43a1b85 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Thu, 5 Nov 2015 13:18:42 -0800 Subject: [PATCH] Add comments explaining why we don't make ``s responsive by default Refs #18178 [ci skip] --- scss/_images.scss | 6 ++++++ scss/_reboot.scss | 2 ++ 2 files changed, 8 insertions(+) diff --git a/scss/_images.scss b/scss/_images.scss index eb7b4ce184..4f1ce65077 100644 --- a/scss/_images.scss +++ b/scss/_images.scss @@ -1,4 +1,10 @@ // Responsive images (ensure images don't scale beyond their parents) +// +// This is purposefully opt-in via an explicit class rather than being the default for all ``s. +// We previously tried the "images are responsive by default" approach in Bootstrap v2, +// and abandoned it in Bootstrap v3 because it breaks lots of third-party widgets (including Google Maps) +// which weren't expecting the images within themselves to be involuntarily resized. +// See also https://github.com/twbs/bootstrap/issues/18178 .img-fluid { @include img-fluid(); } diff --git a/scss/_reboot.scss b/scss/_reboot.scss index 7c52785196..0da7e5ea6b 100644 --- a/scss/_reboot.scss +++ b/scss/_reboot.scss @@ -191,6 +191,8 @@ img { // By default, ``s are `inline-block`. This assumes that, and vertically // centers them. This won't apply should you reset them to `block` level. vertical-align: middle; + // Note: ``s are deliberately not made responsive by default. + // For the rationale behind this, see the comments on the `.img-fluid` class. }