From f2f2e39a45039658c3ed7a39af834ca8dd802bdc Mon Sep 17 00:00:00 2001 From: Johann Date: Sun, 19 Mar 2017 01:42:11 +0100 Subject: [PATCH] Fix getSelectorFromElement when # is a selector (#21615) * Fix getSelectorFromElement when # is a selector * Thanks to @vanduynslagerp remove regex to validate selector --- js/src/util.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/js/src/util.js b/js/src/util.js index 515eba6d9b..3c0d022513 100644 --- a/js/src/util.js +++ b/js/src/util.js @@ -112,13 +112,16 @@ const Util = (($) => { getSelectorFromElement(element) { let selector = element.getAttribute('data-target') - - if (!selector) { + if (!selector || selector === '#') { selector = element.getAttribute('href') || '' - selector = /^#[a-z]/i.test(selector) ? selector : null } - return selector + try { + const $selector = $(selector) + return $selector.length > 0 ? selector : null + } catch (error) { + return null + } }, reflow(element) {