Commit Graph

17 Commits

Author SHA1 Message Date
Martijn Cuppens 7a01f3c41b Selector improvement (#27219) 2018-09-14 09:31:48 -03:00
ysds d1de8737aa Move CSS of hover underline to base from color variants 2018-09-02 16:25:21 -07:00
Patrick Yeo ac69547314 Badges add Sass variable to configure `$badge-border-radius` (#24213) 2017-10-02 21:11:11 -07:00
Jon Wolski f07d870381
Remove `color` property from `badge` class
I suggest removing `color: #FFF` from the `badge` class, because it is
provided by the `badge-<modifier>` classes along with a
background-color, whereas there is no corresponding background-color
provided on the `badge` class itself.

Background
----------

According to the documentation:

> [badge] Requires one of the contextual, color modifier classes for `color` and
> `background-color`.

That is, color and background color should be provided by a modifier
class, rather than the badge class itself.

e.g. `<span class='badge badge-primary'>4</span>`

In general, providing a `color` property without also providing a
`background-color` should be avoided. [W3 QA tips]

In this context, this is a problem only if someone creates a `badge`
without providing a modifier. Such an omition may be difficult to trouble-shoot,
because this will most likely yield white text on a white background.

[W3 QA tips](https://www.w3.org/QA/Tips/color)
2017-08-18 09:35:00 -05:00
Mark Otto aa83c4f417 update badges to use the theme colors sass map 2017-06-25 18:15:32 -07:00
Mark Otto 02e0fdbd52 Remove `cursor: pointer;` (#21812)
* Remove most of custom cursor: pointer; implementations

* turns out that's not so much of a thing
2017-01-23 22:15:28 -08:00
Quy 88a6b1c3d4 Rename tags to badges in comments 2016-12-26 13:06:34 -08:00
Mark Otto d9fa3fd797 Rename .tag to .badge to avoid conflicting with WordPress 2016-10-26 18:33:58 -07:00
Mark Otto 97bcfb9e7f rip badges 2015-08-05 00:48:42 -07:00
Mark Otto ed42fc9b76 line-height-base to line-height var 2015-06-22 23:24:32 -07:00
Mark Otto eaa67a82d3 fix scss linting 2015-06-19 00:14:36 -07:00
Mark Otto 169d2a4a78 Merge branch 'master' into v4 2015-06-18 23:56:43 -07:00
Mark Otto 933639729f enforce line-height on badges at all times 2015-05-29 14:05:02 -07:00
Mark Otto b88c05d564 clean up comments and spacing 2015-04-18 11:15:40 -07:00
Chris Rebert 8e374bd010 put all :hover styles within @media (hover: hover) 2015-01-22 11:37:37 -08:00
Mark Otto fef873a840 fix all validation, turn off some settings, add sort order 2014-12-11 12:05:29 -08:00
Mark Otto 27df020852 convert to scss 2014-12-02 14:02:35 -08:00