2012-11-19 07:02:42 -05:00
|
|
|
require "pundit"
|
|
|
|
require "pry"
|
2013-06-17 19:13:07 -04:00
|
|
|
require "active_support/core_ext"
|
2012-11-19 07:02:42 -05:00
|
|
|
require "active_model/naming"
|
|
|
|
|
|
|
|
class PostPolicy < Struct.new(:user, :post)
|
|
|
|
def update?
|
|
|
|
post.user == user
|
|
|
|
end
|
|
|
|
def destroy?
|
|
|
|
false
|
|
|
|
end
|
|
|
|
def show?
|
|
|
|
true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
class PostPolicy::Scope < Struct.new(:user, :scope)
|
|
|
|
def resolve
|
|
|
|
scope.published
|
|
|
|
end
|
|
|
|
end
|
|
|
|
class Post < Struct.new(:user)
|
|
|
|
def self.published
|
|
|
|
:published
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
class CommentPolicy < Struct.new(:user, :comment); end
|
|
|
|
class CommentPolicy::Scope < Struct.new(:user, :scope)
|
|
|
|
def resolve
|
|
|
|
scope
|
|
|
|
end
|
|
|
|
end
|
|
|
|
class Comment; extend ActiveModel::Naming; end
|
|
|
|
|
|
|
|
class Article; end
|
|
|
|
|
2012-11-30 10:21:46 -05:00
|
|
|
class BlogPolicy < Struct.new(:user, :blog); end
|
|
|
|
class Blog; end
|
|
|
|
class ArtificialBlog < Blog
|
|
|
|
def self.policy_class
|
|
|
|
BlogPolicy
|
|
|
|
end
|
|
|
|
end
|
2012-12-13 18:20:12 -05:00
|
|
|
class ArticleTag
|
|
|
|
def self.policy_class
|
|
|
|
Struct.new(:user, :tag) do
|
|
|
|
def show?
|
|
|
|
true
|
|
|
|
end
|
|
|
|
def destroy?
|
|
|
|
false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2012-11-30 10:21:46 -05:00
|
|
|
|
2012-11-19 07:02:42 -05:00
|
|
|
describe Pundit do
|
2013-08-26 04:04:15 -04:00
|
|
|
let(:user) { double }
|
2012-11-19 07:02:42 -05:00
|
|
|
let(:post) { Post.new(user) }
|
|
|
|
let(:comment) { Comment.new }
|
|
|
|
let(:article) { Article.new }
|
2013-08-26 04:04:15 -04:00
|
|
|
let(:controller) { double(:current_user => user, :params => { :action => "update" }).tap { |c| c.extend(Pundit) } }
|
2012-11-30 10:21:46 -05:00
|
|
|
let(:artificial_blog) { ArtificialBlog.new }
|
2012-12-13 18:20:12 -05:00
|
|
|
let(:article_tag) { ArticleTag.new }
|
2012-11-19 07:02:42 -05:00
|
|
|
|
|
|
|
describe ".policy_scope" do
|
|
|
|
it "returns an instantiated policy scope given a plain model class" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(Pundit.policy_scope(user, Post)).to eq :published
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy scope given an active model class" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(Pundit.policy_scope(user, Comment)).to eq Comment
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns nil if the given policy scope can't be found" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(Pundit.policy_scope(user, Article)).to be_nil
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe ".policy_scope!" do
|
|
|
|
it "returns an instantiated policy scope given a plain model class" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(Pundit.policy_scope!(user, Post)).to eq :published
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy scope given an active model class" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(Pundit.policy_scope!(user, Comment)).to eq Comment
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "throws an exception if the given policy scope can't be found" do
|
|
|
|
expect { Pundit.policy_scope!(user, Article) }.to raise_error(Pundit::NotDefinedError)
|
|
|
|
end
|
2012-12-13 18:20:12 -05:00
|
|
|
|
|
|
|
it "throws an exception if the given policy scope can't be found" do
|
|
|
|
expect { Pundit.policy_scope!(user, ArticleTag) }.to raise_error(Pundit::NotDefinedError)
|
|
|
|
end
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe ".policy" do
|
|
|
|
it "returns an instantiated policy given a plain model instance" do
|
|
|
|
policy = Pundit.policy(user, post)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.post).to eq post
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given an active model instance" do
|
|
|
|
policy = Pundit.policy(user, comment)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.comment).to eq comment
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given a plain model class" do
|
|
|
|
policy = Pundit.policy(user, Post)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.post).to eq Post
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given an active model class" do
|
|
|
|
policy = Pundit.policy(user, Comment)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.comment).to eq Comment
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns nil if the given policy can't be found" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(Pundit.policy(user, article)).to be_nil
|
|
|
|
expect(Pundit.policy(user, Article)).to be_nil
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
2012-12-13 18:20:12 -05:00
|
|
|
|
|
|
|
describe "with .policy_class set on the model" do
|
|
|
|
it "returns an instantiated policy given a plain model instance" do
|
|
|
|
policy = Pundit.policy(user, artificial_blog)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.blog).to eq artificial_blog
|
2012-12-13 18:20:12 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given a plain model class" do
|
|
|
|
policy = Pundit.policy(user, ArtificialBlog)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.blog).to eq ArtificialBlog
|
2012-12-13 18:20:12 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given a plain model instance providing an anonymous class" do
|
|
|
|
policy = Pundit.policy(user, article_tag)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.tag).to eq article_tag
|
2012-12-13 18:20:12 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given a plain model class providing an anonymous class" do
|
|
|
|
policy = Pundit.policy(user, ArticleTag)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.tag).to eq ArticleTag
|
2012-12-13 18:20:12 -05:00
|
|
|
end
|
|
|
|
end
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe ".policy!" do
|
|
|
|
it "returns an instantiated policy given a plain model instance" do
|
|
|
|
policy = Pundit.policy!(user, post)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.post).to eq post
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given an active model instance" do
|
|
|
|
policy = Pundit.policy!(user, comment)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.comment).to eq comment
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given a plain model class" do
|
|
|
|
policy = Pundit.policy!(user, Post)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.post).to eq Post
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "returns an instantiated policy given an active model class" do
|
|
|
|
policy = Pundit.policy!(user, Comment)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.comment).to eq Comment
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "throws an exception if the given policy can't be found" do
|
|
|
|
expect { Pundit.policy!(user, article) }.to raise_error(Pundit::NotDefinedError)
|
|
|
|
expect { Pundit.policy!(user, Article) }.to raise_error(Pundit::NotDefinedError)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "#verify_authorized" do
|
|
|
|
it "does nothing when authorized" do
|
|
|
|
controller.authorize(post)
|
|
|
|
controller.verify_authorized
|
|
|
|
end
|
|
|
|
|
|
|
|
it "raises an exception when not authorized" do
|
2014-02-14 07:57:13 -05:00
|
|
|
expect { controller.verify_authorized }.to raise_error(Pundit::AuthorizationNotPerformedError)
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-04-18 01:05:24 -04:00
|
|
|
describe "#verify_policy_scoped" do
|
|
|
|
it "does nothing when policy_scope is used" do
|
|
|
|
controller.policy_scope(Post)
|
|
|
|
controller.verify_policy_scoped
|
|
|
|
end
|
|
|
|
|
|
|
|
it "raises an exception when policy_scope is not used" do
|
2014-02-14 07:57:13 -05:00
|
|
|
expect { controller.verify_policy_scoped }.to raise_error(Pundit::AuthorizationNotPerformedError)
|
2013-04-18 01:05:24 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-11-19 07:02:42 -05:00
|
|
|
describe "#authorize" do
|
|
|
|
it "infers the policy name and authorized based on it" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(controller.authorize(post)).to be_truthy
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "can be given a different permission to check" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(controller.authorize(post, :show?)).to be_truthy
|
2012-11-19 07:02:42 -05:00
|
|
|
expect { controller.authorize(post, :destroy?) }.to raise_error(Pundit::NotAuthorizedError)
|
|
|
|
end
|
|
|
|
|
2012-12-13 18:20:12 -05:00
|
|
|
it "works with anonymous class policies" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(controller.authorize(article_tag, :show?)).to be_truthy
|
2012-12-13 18:20:12 -05:00
|
|
|
expect { controller.authorize(article_tag, :destroy?) }.to raise_error(Pundit::NotAuthorizedError)
|
|
|
|
end
|
|
|
|
|
2012-11-19 07:02:42 -05:00
|
|
|
it "raises an error when the permission check fails" do
|
|
|
|
expect { controller.authorize(Post.new) }.to raise_error(Pundit::NotAuthorizedError)
|
|
|
|
end
|
2014-02-25 21:54:22 -05:00
|
|
|
|
|
|
|
it "raises an error with a query and action" do
|
|
|
|
expect { controller.authorize(post, :destroy?) }.to raise_error do |error|
|
|
|
|
expect(error.query).to eq :destroy?
|
|
|
|
expect(error.record).to eq post
|
|
|
|
expect(error.policy).to eq controller.policy(post)
|
|
|
|
end
|
|
|
|
end
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
2013-07-12 23:42:34 -04:00
|
|
|
describe "#pundit_user" do
|
|
|
|
it 'returns the same thing as current_user' do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(controller.pundit_user).to eq controller.current_user
|
2013-07-12 23:42:34 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-11-19 07:02:42 -05:00
|
|
|
describe ".policy" do
|
|
|
|
it "returns an instantiated policy" do
|
|
|
|
policy = controller.policy(post)
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(policy.user).to eq user
|
|
|
|
expect(policy.post).to eq post
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "throws an exception if the given policy can't be found" do
|
|
|
|
expect { controller.policy(article) }.to raise_error(Pundit::NotDefinedError)
|
|
|
|
end
|
2013-08-11 20:38:50 -04:00
|
|
|
|
|
|
|
it "allows policy to be injected" do
|
|
|
|
new_policy = OpenStruct.new
|
|
|
|
controller.policy = new_policy
|
|
|
|
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(controller.policy(post)).to eq new_policy
|
2013-08-11 20:38:50 -04:00
|
|
|
end
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe ".policy_scope" do
|
|
|
|
it "returns an instantiated policy scope" do
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(controller.policy_scope(Post)).to eq :published
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it "throws an exception if the given policy can't be found" do
|
|
|
|
expect { controller.policy_scope(Article) }.to raise_error(Pundit::NotDefinedError)
|
|
|
|
end
|
2013-08-11 20:38:50 -04:00
|
|
|
|
|
|
|
it "allows policy_scope to be injected" do
|
|
|
|
new_scope = OpenStruct.new
|
|
|
|
controller.policy_scope = new_scope
|
|
|
|
|
2014-02-08 07:19:24 -05:00
|
|
|
expect(controller.policy_scope(post)).to eq new_scope
|
2013-08-11 20:38:50 -04:00
|
|
|
end
|
2012-11-19 07:02:42 -05:00
|
|
|
end
|
|
|
|
end
|