kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/support/helpers/stub_feature_flags.rb

12 lines
448 B
Ruby
Raw Normal View History

Enable all feature flags by default in specs Otherwise some features would go untested in non-specific contexts I did need to disable the `gitlab_git_diff_size_limit_increase`-feature in some specs since we depend on diffs being expandable while the file we are testing on is smaller than the increased limit.
2017-07-13 03:58:05 -04:00
module StubFeatureFlags
Fixed `stub_feature_flag behavior` for `disabled?` flags. Previous code would not work with `disabled?` because that method would send two parameters (second always `nil`) which we are not mocking. Instead of mock yet another state, I decide to fix it where it belongs.
2018-08-20 14:52:56 -04:00
# Stub Feature flags with `flag_name: true/false`
#
# @param [Hash] features where key is feature name and value is boolean whether enabled or not
Enable all feature flags by default in specs Otherwise some features would go untested in non-specific contexts I did need to disable the `gitlab_git_diff_size_limit_increase`-feature in some specs since we depend on diffs being expandable while the file we are testing on is smaller than the increased limit.
2017-07-13 03:58:05 -04:00
def stub_feature_flags(features)
features.each do |feature_name, enabled|
add 'default_enabled' to feature flags This allows you to default a feature flag to 'on' when checking whether it's enabled/disabled.
2018-09-04 14:34:37 -04:00
allow(Feature).to receive(:enabled?).with(feature_name, any_args) { enabled }
allow(Feature).to receive(:enabled?).with(feature_name.to_s, any_args) { enabled }
Enable all feature flags by default in specs Otherwise some features would go untested in non-specific contexts I did need to disable the `gitlab_git_diff_size_limit_increase`-feature in some specs since we depend on diffs being expandable while the file we are testing on is smaller than the increased limit.
2017-07-13 03:58:05 -04:00
end
end
end
Copy permalink