2020-02-06 19:09:12 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 14:09:03 -04:00
|
|
|
RSpec.describe X509SerialNumberAttribute do
|
2020-02-06 19:09:12 -05:00
|
|
|
let(:model) { Class.new { include X509SerialNumberAttribute } }
|
|
|
|
|
|
|
|
before do
|
|
|
|
columns = [
|
|
|
|
double(:column, name: 'name', type: :text),
|
|
|
|
double(:column, name: 'serial_number', type: :binary)
|
|
|
|
]
|
|
|
|
|
|
|
|
allow(model).to receive(:columns).and_return(columns)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#x509_serial_number_attribute' do
|
|
|
|
context 'when in non-production' do
|
|
|
|
before do
|
|
|
|
stub_rails_env('development')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the table exists' do
|
|
|
|
before do
|
|
|
|
allow(model).to receive(:table_exists?).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'defines a x509 serial number attribute for a binary column' do
|
|
|
|
expect(model).to receive(:attribute)
|
|
|
|
.with(:serial_number, an_instance_of(Gitlab::Database::X509SerialNumberAttribute))
|
|
|
|
|
|
|
|
model.x509_serial_number_attribute(:serial_number)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises ArgumentError when the column type is not :binary' do
|
|
|
|
expect { model.x509_serial_number_attribute(:name) }.to raise_error(ArgumentError)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the table does not exist' do
|
|
|
|
it 'allows the attribute to be added and issues a warning' do
|
|
|
|
allow(model).to receive(:table_exists?).and_return(false)
|
|
|
|
|
|
|
|
expect(model).not_to receive(:columns)
|
|
|
|
expect(model).to receive(:attribute)
|
|
|
|
expect(model).to receive(:warn)
|
|
|
|
|
|
|
|
model.x509_serial_number_attribute(:name)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the column does not exist' do
|
|
|
|
it 'allows the attribute to be added and issues a warning' do
|
|
|
|
allow(model).to receive(:table_exists?).and_return(true)
|
|
|
|
|
|
|
|
expect(model).to receive(:columns)
|
|
|
|
expect(model).to receive(:attribute)
|
|
|
|
expect(model).to receive(:warn)
|
|
|
|
|
|
|
|
model.x509_serial_number_attribute(:no_name)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when other execeptions are raised' do
|
|
|
|
it 'logs and re-rasises the error' do
|
|
|
|
allow(model).to receive(:table_exists?).and_raise(ActiveRecord::NoDatabaseError.new('does not exist'))
|
|
|
|
|
|
|
|
expect(model).not_to receive(:columns)
|
|
|
|
expect(model).not_to receive(:attribute)
|
|
|
|
expect(Gitlab::AppLogger).to receive(:error)
|
|
|
|
|
|
|
|
expect { model.x509_serial_number_attribute(:name) }.to raise_error(ActiveRecord::NoDatabaseError)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when in production' do
|
|
|
|
before do
|
|
|
|
stub_rails_env('production')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'defines a x509 serial number attribute' do
|
|
|
|
expect(model).not_to receive(:table_exists?)
|
|
|
|
expect(model).not_to receive(:columns)
|
|
|
|
expect(model).to receive(:attribute).with(:serial_number, an_instance_of(Gitlab::Database::X509SerialNumberAttribute))
|
|
|
|
|
|
|
|
model.x509_serial_number_attribute(:serial_number)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|