2019-07-25 01:24:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-01-20 16:41:03 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-16 14:09:01 -04:00
|
|
|
RSpec.describe 'Merge Request button' do
|
2021-02-22 10:10:48 -05:00
|
|
|
include ProjectForksHelper
|
|
|
|
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:project) { create(:project, :public, :repository) }
|
2021-04-21 02:09:28 -04:00
|
|
|
|
2021-02-22 10:10:48 -05:00
|
|
|
let(:forked_project) { fork_project(project, user, repository: true) }
|
2017-01-20 16:41:03 -05:00
|
|
|
|
2021-02-22 10:10:48 -05:00
|
|
|
shared_examples 'Merge request button only shown when allowed' do
|
2017-01-20 16:41:03 -05:00
|
|
|
context 'not logged in' do
|
2017-04-06 09:55:11 -04:00
|
|
|
it 'does not show Create merge request button' do
|
2017-01-20 16:41:03 -05:00
|
|
|
visit url
|
|
|
|
|
2021-04-01 05:09:05 -04:00
|
|
|
within '.content-wrapper' do
|
|
|
|
expect(page).not_to have_link(label)
|
|
|
|
end
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'logged in as developer' do
|
|
|
|
before do
|
2017-06-21 19:44:10 -04:00
|
|
|
sign_in(user)
|
2017-07-14 09:36:37 -04:00
|
|
|
project.add_developer(user)
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
|
2021-02-24 16:11:16 -05:00
|
|
|
it 'shows Create merge request button', :js do
|
2021-02-22 10:10:48 -05:00
|
|
|
href = project_new_merge_request_path(
|
|
|
|
project,
|
|
|
|
merge_request: {
|
|
|
|
source_project_id: project.id,
|
|
|
|
source_branch: 'feature',
|
|
|
|
target_project_id: project.id,
|
|
|
|
target_branch: 'master'
|
|
|
|
}
|
|
|
|
)
|
2017-01-20 16:41:03 -05:00
|
|
|
|
|
|
|
visit url
|
|
|
|
|
2017-07-14 09:36:37 -04:00
|
|
|
within('#content-body') do
|
2017-01-25 05:07:02 -05:00
|
|
|
expect(page).to have_link(label, href: href)
|
|
|
|
end
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
2017-01-25 05:11:12 -05:00
|
|
|
|
|
|
|
context 'merge requests are disabled' do
|
|
|
|
before do
|
|
|
|
project.project_feature.update!(merge_requests_access_level: ProjectFeature::DISABLED)
|
|
|
|
end
|
|
|
|
|
2017-04-06 09:55:11 -04:00
|
|
|
it 'does not show Create merge request button' do
|
2017-01-25 05:11:12 -05:00
|
|
|
visit url
|
|
|
|
|
2017-07-14 09:36:37 -04:00
|
|
|
within('#content-body') do
|
2017-01-25 05:11:12 -05:00
|
|
|
expect(page).not_to have_link(label)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-04-06 06:47:52 -04:00
|
|
|
|
|
|
|
context 'when the project is archived' do
|
|
|
|
it 'hides the link' do
|
|
|
|
project.update!(archived: true)
|
|
|
|
|
|
|
|
visit url
|
|
|
|
|
|
|
|
within("#content-body") do
|
|
|
|
expect(page).not_to have_link(label)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'logged in as non-member' do
|
|
|
|
before do
|
2017-06-21 19:44:10 -04:00
|
|
|
sign_in(user)
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
|
2017-04-06 09:55:11 -04:00
|
|
|
it 'does not show Create merge request button' do
|
2017-01-20 16:41:03 -05:00
|
|
|
visit url
|
|
|
|
|
2017-07-14 09:36:37 -04:00
|
|
|
within('#content-body') do
|
2017-01-25 05:07:02 -05:00
|
|
|
expect(page).not_to have_link(label)
|
|
|
|
end
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'on own fork of project' do
|
2021-02-24 16:11:16 -05:00
|
|
|
it 'shows Create merge request button', :js do
|
2021-02-22 10:10:48 -05:00
|
|
|
href = project_new_merge_request_path(
|
|
|
|
forked_project,
|
|
|
|
merge_request: {
|
|
|
|
source_project_id: forked_project.id,
|
|
|
|
source_branch: 'feature',
|
|
|
|
target_project_id: forked_project.id,
|
|
|
|
target_branch: 'master'
|
|
|
|
}
|
|
|
|
)
|
2017-01-20 16:41:03 -05:00
|
|
|
|
|
|
|
visit fork_url
|
|
|
|
|
2017-01-25 05:07:02 -05:00
|
|
|
within("#content-body") do
|
|
|
|
expect(page).to have_link(label, href: href)
|
|
|
|
end
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on branches page' do
|
2017-04-06 09:55:11 -04:00
|
|
|
it_behaves_like 'Merge request button only shown when allowed' do
|
|
|
|
let(:label) { 'Merge request' }
|
2017-11-15 09:56:36 -05:00
|
|
|
let(:url) { project_branches_filtered_path(project, state: 'all', search: 'feature') }
|
|
|
|
let(:fork_url) { project_branches_filtered_path(forked_project, state: 'all', search: 'feature') }
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on compare page' do
|
2021-02-22 10:10:48 -05:00
|
|
|
let(:label) { 'Create merge request' }
|
|
|
|
|
2017-04-06 09:55:11 -04:00
|
|
|
it_behaves_like 'Merge request button only shown when allowed' do
|
2017-07-06 12:20:50 -04:00
|
|
|
let(:url) { project_compare_path(project, from: 'master', to: 'feature') }
|
|
|
|
let(:fork_url) { project_compare_path(forked_project, from: 'master', to: 'feature') }
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
2021-02-22 10:10:48 -05:00
|
|
|
|
2021-02-24 16:11:16 -05:00
|
|
|
it 'shows the correct merge request button when viewing across forks', :js do
|
2021-02-22 10:10:48 -05:00
|
|
|
sign_in(user)
|
|
|
|
project.add_developer(user)
|
|
|
|
|
|
|
|
href = project_new_merge_request_path(
|
|
|
|
project,
|
|
|
|
merge_request: {
|
|
|
|
source_project_id: forked_project.id,
|
|
|
|
source_branch: 'feature',
|
|
|
|
target_project_id: project.id,
|
|
|
|
target_branch: 'master'
|
|
|
|
}
|
|
|
|
)
|
|
|
|
|
|
|
|
visit project_compare_path(forked_project, from: 'master', to: 'feature', from_project_id: project.id)
|
|
|
|
|
|
|
|
within("#content-body") do
|
|
|
|
expect(page).to have_link(label, href: href)
|
|
|
|
end
|
|
|
|
end
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'on commits page' do
|
2017-04-06 09:55:11 -04:00
|
|
|
it_behaves_like 'Merge request button only shown when allowed' do
|
|
|
|
let(:label) { 'Create merge request' }
|
2017-07-06 12:20:50 -04:00
|
|
|
let(:url) { project_commits_path(project, 'feature') }
|
|
|
|
let(:fork_url) { project_commits_path(forked_project, 'feature') }
|
2017-01-20 16:41:03 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|