2012-11-24 23:04:13 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2013-06-23 17:25:06 +00:00
|
|
|
describe Projects::MergeRequestsController do
|
2014-01-22 19:03:52 +00:00
|
|
|
let(:project) { create(:project) }
|
2012-11-24 23:04:13 +00:00
|
|
|
let(:user) { create(:user) }
|
2014-08-06 06:07:11 +00:00
|
|
|
let(:merge_request) { create(:merge_request_with_diffs, target_project: project, source_project: project) }
|
2012-11-24 23:04:13 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
2013-01-04 16:50:31 +00:00
|
|
|
project.team << [user, :master]
|
2012-11-24 23:04:13 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "#show" do
|
2013-04-07 20:58:25 +00:00
|
|
|
shared_examples "export merge as" do |format|
|
2012-11-24 23:04:13 +00:00
|
|
|
it "should generally work" do
|
2015-01-24 18:02:58 +00:00
|
|
|
get(:show, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: format)
|
2012-11-24 23:04:13 +00:00
|
|
|
|
|
|
|
expect(response).to be_success
|
|
|
|
end
|
|
|
|
|
|
|
|
it "should generate it" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect_any_instance_of(MergeRequest).to receive(:"to_#{format}")
|
2012-11-24 23:04:13 +00:00
|
|
|
|
2015-01-24 18:02:58 +00:00
|
|
|
get(:show, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: format)
|
2012-11-24 23:04:13 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should render it" do
|
2015-01-24 18:02:58 +00:00
|
|
|
get(:show, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: format)
|
2012-11-24 23:04:13 +00:00
|
|
|
|
2013-04-25 14:15:33 +00:00
|
|
|
expect(response.body).to eq((merge_request.send(:"to_#{format}",user)).to_s)
|
2012-11-24 23:04:13 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should not escape Html" do
|
2015-02-12 18:32:58 +00:00
|
|
|
allow_any_instance_of(MergeRequest).to receive(:"to_#{format}").
|
|
|
|
and_return('HTML entities &<>" ')
|
2012-11-24 23:04:13 +00:00
|
|
|
|
2015-01-24 18:02:58 +00:00
|
|
|
get(:show, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: format)
|
2012-11-24 23:04:13 +00:00
|
|
|
|
|
|
|
expect(response.body).to_not include('&')
|
|
|
|
expect(response.body).to_not include('>')
|
|
|
|
expect(response.body).to_not include('<')
|
|
|
|
expect(response.body).to_not include('"')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "as diff" do
|
2013-04-07 20:58:25 +00:00
|
|
|
include_examples "export merge as", :diff
|
2012-11-24 23:04:13 +00:00
|
|
|
let(:format) { :diff }
|
|
|
|
|
|
|
|
it "should really only be a git diff" do
|
2015-01-24 18:02:58 +00:00
|
|
|
get(:show, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: format)
|
2012-11-24 23:04:13 +00:00
|
|
|
|
|
|
|
expect(response.body).to start_with("diff --git")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "as patch" do
|
2013-04-07 20:58:25 +00:00
|
|
|
include_examples "export merge as", :patch
|
2012-11-24 23:04:13 +00:00
|
|
|
let(:format) { :patch }
|
|
|
|
|
|
|
|
it "should really be a git email patch with commit" do
|
2015-01-24 18:02:58 +00:00
|
|
|
get(:show, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: format)
|
2012-11-24 23:04:13 +00:00
|
|
|
|
2014-08-06 06:07:11 +00:00
|
|
|
expect(response.body[0..100]).to start_with("From #{merge_request.commits.last.id}")
|
2012-11-24 23:04:13 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should contain git diffs" do
|
2015-01-24 18:02:58 +00:00
|
|
|
get(:show, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: format)
|
2012-11-24 23:04:13 +00:00
|
|
|
|
|
|
|
expect(response.body).to match(/^diff --git/)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-04-13 05:27:45 +00:00
|
|
|
|
|
|
|
context '#diffs with forked projects with submodules' do
|
|
|
|
render_views
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:fork_project) { create(:forked_project_with_submodules) }
|
|
|
|
let(:merge_request) { create(:merge_request_with_diffs, source_project: fork_project, source_branch: 'add-submodule-version-bump', target_branch: 'master', target_project: project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
fork_project.build_forked_project_link(forked_to_project_id: fork_project.id, forked_from_project_id: project.id)
|
|
|
|
fork_project.save
|
|
|
|
merge_request.reload
|
|
|
|
end
|
|
|
|
|
|
|
|
it '#diffs' do
|
|
|
|
get(:diffs, namespace_id: project.namespace.to_param,
|
|
|
|
project_id: project.to_param, id: merge_request.iid, format: 'json')
|
|
|
|
expect(response).to be_success
|
|
|
|
expect(response.body).to have_content('Subproject commit')
|
|
|
|
end
|
|
|
|
end
|
2012-11-24 23:04:13 +00:00
|
|
|
end
|