2017-05-03 18:51:55 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Groups::VariablesController do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
group.add_master(user)
|
|
|
|
end
|
|
|
|
|
2018-01-23 18:24:55 +00:00
|
|
|
describe 'POST #save_multiple' do
|
|
|
|
let!(:variable) { create(:ci_group_variable, group: group) }
|
|
|
|
|
|
|
|
context 'with invalid new variable parameters' do
|
|
|
|
subject do
|
|
|
|
post :save_multiple,
|
|
|
|
group_id: group,
|
2018-01-23 18:53:29 +00:00
|
|
|
variables_attributes: [{ id: variable.id, key: variable.key,
|
|
|
|
value: 'other_value',
|
|
|
|
protected: variable.protected?.to_s },
|
|
|
|
{ key: '..?', value: 'dummy_value',
|
|
|
|
protected: 'false' }],
|
2018-01-23 18:24:55 +00:00
|
|
|
format: :json
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update the existing variable' do
|
|
|
|
expect { subject }.not_to change { variable.reload.value }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create the new variable' do
|
|
|
|
expect { subject }.not_to change { group.variables.count }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a bad request response' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:bad_request)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with valid new variable parameters' do
|
|
|
|
subject do
|
|
|
|
post :save_multiple,
|
|
|
|
group_id: group,
|
2018-01-23 18:53:29 +00:00
|
|
|
variables_attributes: [{ id: variable.id, key: variable.key,
|
|
|
|
value: 'other_value',
|
|
|
|
protected: variable.protected?.to_s },
|
|
|
|
{ key: 'new_key', value: 'dummy_value',
|
|
|
|
protected: 'false' }],
|
2018-01-23 18:24:55 +00:00
|
|
|
format: :json
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the existing variable' do
|
|
|
|
expect { subject }.to change { variable.reload.value }.to('other_value')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates the new variable' do
|
|
|
|
expect { subject }.to change { group.variables.count }.by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a successful response' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a deleted variable' do
|
|
|
|
subject do
|
|
|
|
post :save_multiple,
|
|
|
|
group_id: group,
|
|
|
|
variables_attributes: [{ id: variable.id, key: variable.key,
|
2018-01-23 18:53:29 +00:00
|
|
|
value: variable.value,
|
|
|
|
protected: variable.protected?.to_s,
|
|
|
|
_destroy: 'true' }],
|
2018-01-23 18:24:55 +00:00
|
|
|
format: :json
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'destroys the variable' do
|
|
|
|
expect { subject }.to change { group.variables.count }.by(-1)
|
|
|
|
expect { variable.reload }.to raise_error ActiveRecord::RecordNotFound
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a successful response' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-05-03 18:51:55 +00:00
|
|
|
end
|