2011-10-08 17:36:38 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe "Issues" do
|
2012-11-05 22:31:55 -05:00
|
|
|
let(:project) { create(:project) }
|
2011-10-08 17:36:38 -04:00
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
before do
|
2011-10-08 17:36:38 -04:00
|
|
|
login_as :user
|
2012-11-13 19:20:37 -05:00
|
|
|
user2 = create(:user)
|
2011-11-01 16:51:20 -04:00
|
|
|
|
2013-01-04 01:43:25 -05:00
|
|
|
project.team << [[@user, user2], :developer]
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
2012-12-18 22:14:05 -05:00
|
|
|
describe "Edit issue" do
|
2012-11-13 19:20:37 -05:00
|
|
|
let!(:issue) do
|
|
|
|
create(:issue,
|
|
|
|
author: @user,
|
|
|
|
assignee: @user,
|
|
|
|
project: project)
|
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
before do
|
2011-10-08 17:36:38 -04:00
|
|
|
visit project_issues_path(project)
|
|
|
|
click_link "Edit"
|
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
it "should open new issue popup" do
|
2013-10-20 11:29:11 -04:00
|
|
|
page.should have_content("Issue ##{issue.iid}")
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
describe "fill in" do
|
2011-10-08 17:36:38 -04:00
|
|
|
before do
|
2012-08-10 18:07:50 -04:00
|
|
|
fill_in "issue_title", with: "bug 345"
|
|
|
|
fill_in "issue_description", with: "bug description"
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
2012-03-25 12:44:29 -04:00
|
|
|
it { expect { click_button "Save changes" }.to_not change {Issue.count} }
|
2011-10-08 17:36:38 -04:00
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
it "should update issue fields" do
|
2012-03-25 12:44:29 -04:00
|
|
|
click_button "Save changes"
|
2011-10-08 17:36:38 -04:00
|
|
|
|
|
|
|
page.should have_content @user.name
|
|
|
|
page.should have_content "bug 345"
|
|
|
|
page.should have_content project.name
|
|
|
|
end
|
|
|
|
end
|
2014-03-02 12:29:01 -05:00
|
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Editing issue assignee" do
|
|
|
|
let!(:issue) do
|
|
|
|
create(:issue,
|
|
|
|
author: @user,
|
|
|
|
assignee: @user,
|
|
|
|
project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows user to select unasigned', :js => true do
|
|
|
|
visit edit_project_issue_path(project, issue)
|
|
|
|
|
|
|
|
page.should have_content "Assign to #{@user.name}"
|
|
|
|
|
|
|
|
page.first('#s2id_issue_assignee_id').click
|
|
|
|
sleep 2 # wait for ajax stuff to complete
|
|
|
|
page.first('.user-result').click
|
|
|
|
|
|
|
|
click_button "Save changes"
|
|
|
|
|
|
|
|
page.should have_content "Assignee: Select assignee"
|
|
|
|
issue.reload.assignee.should be_nil
|
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
2011-10-22 00:06:38 -04:00
|
|
|
|
2012-08-13 01:38:00 -04:00
|
|
|
describe "Filter issue" do
|
|
|
|
before do
|
|
|
|
['foobar', 'barbaz', 'gitlab'].each do |title|
|
2012-11-13 19:20:37 -05:00
|
|
|
create(:issue,
|
|
|
|
author: @user,
|
|
|
|
assignee: @user,
|
|
|
|
project: project,
|
|
|
|
title: title)
|
2012-08-13 01:38:00 -04:00
|
|
|
end
|
|
|
|
|
2012-12-18 13:43:44 -05:00
|
|
|
@issue = Issue.first # with title 'foobar'
|
|
|
|
@issue.milestone = create(:milestone, project: project)
|
|
|
|
@issue.assignee = nil
|
|
|
|
@issue.save
|
2012-08-13 01:38:00 -04:00
|
|
|
end
|
|
|
|
|
2012-12-18 13:43:44 -05:00
|
|
|
let(:issue) { @issue }
|
2012-11-13 19:20:37 -05:00
|
|
|
|
2012-08-13 01:38:00 -04:00
|
|
|
it "should allow filtering by issues with no specified milestone" do
|
|
|
|
visit project_issues_path(project, milestone_id: '0')
|
|
|
|
|
|
|
|
page.should_not have_content 'foobar'
|
|
|
|
page.should have_content 'barbaz'
|
|
|
|
page.should have_content 'gitlab'
|
|
|
|
end
|
|
|
|
|
|
|
|
it "should allow filtering by a specified milestone" do
|
2012-11-13 19:20:37 -05:00
|
|
|
visit project_issues_path(project, milestone_id: issue.milestone.id)
|
2012-08-13 01:38:00 -04:00
|
|
|
|
|
|
|
page.should have_content 'foobar'
|
|
|
|
page.should_not have_content 'barbaz'
|
|
|
|
page.should_not have_content 'gitlab'
|
|
|
|
end
|
2012-08-13 20:49:18 -04:00
|
|
|
|
|
|
|
it "should allow filtering by issues with no specified assignee" do
|
|
|
|
visit project_issues_path(project, assignee_id: '0')
|
|
|
|
|
|
|
|
page.should have_content 'foobar'
|
|
|
|
page.should_not have_content 'barbaz'
|
|
|
|
page.should_not have_content 'gitlab'
|
|
|
|
end
|
|
|
|
|
|
|
|
it "should allow filtering by a specified assignee" do
|
|
|
|
visit project_issues_path(project, assignee_id: @user.id)
|
|
|
|
|
|
|
|
page.should_not have_content 'foobar'
|
|
|
|
page.should have_content 'barbaz'
|
|
|
|
page.should have_content 'gitlab'
|
|
|
|
end
|
2012-08-13 01:38:00 -04:00
|
|
|
end
|
2013-11-20 17:59:50 -05:00
|
|
|
|
|
|
|
describe 'filter issue' do
|
|
|
|
titles = ['foo','bar','baz']
|
|
|
|
titles.each_with_index do |title, index|
|
|
|
|
let!(title.to_sym) { create(:issue, title: title, project: project, created_at: Time.now - (index * 60)) }
|
|
|
|
end
|
2013-11-27 03:04:00 -05:00
|
|
|
let(:newer_due_milestone) { create(:milestone, due_date: '2013-12-11') }
|
|
|
|
let(:later_due_milestone) { create(:milestone, due_date: '2013-12-12') }
|
2013-11-20 17:59:50 -05:00
|
|
|
|
|
|
|
it 'sorts by newest' do
|
|
|
|
visit project_issues_path(project, sort: 'newest')
|
2013-11-27 03:04:00 -05:00
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
first_issue.should include("foo")
|
|
|
|
last_issue.should include("baz")
|
2013-11-20 17:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'sorts by oldest' do
|
|
|
|
visit project_issues_path(project, sort: 'oldest')
|
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
first_issue.should include("baz")
|
|
|
|
last_issue.should include("foo")
|
2013-11-20 17:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'sorts by most recently updated' do
|
|
|
|
baz.updated_at = Time.now + 100
|
|
|
|
baz.save
|
|
|
|
visit project_issues_path(project, sort: 'recently_updated')
|
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
first_issue.should include("baz")
|
2013-11-20 17:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'sorts by least recently updated' do
|
|
|
|
baz.updated_at = Time.now - 100
|
|
|
|
baz.save
|
|
|
|
visit project_issues_path(project, sort: 'last_updated')
|
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
first_issue.should include("baz")
|
2013-11-20 17:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'sorting by milestone' do
|
2013-11-27 03:04:00 -05:00
|
|
|
before :each do
|
2013-11-20 17:59:50 -05:00
|
|
|
foo.milestone = newer_due_milestone
|
|
|
|
foo.save
|
|
|
|
bar.milestone = later_due_milestone
|
|
|
|
bar.save
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sorts by recently due milestone' do
|
|
|
|
visit project_issues_path(project, sort: 'milestone_due_soon')
|
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
first_issue.should include("foo")
|
2013-11-20 17:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'sorts by least recently due milestone' do
|
|
|
|
visit project_issues_path(project, sort: 'milestone_due_later')
|
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
first_issue.should include("bar")
|
2013-11-20 17:59:50 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'combine filter and sort' do
|
|
|
|
let(:user2) { create(:user) }
|
|
|
|
|
|
|
|
before :each do
|
|
|
|
foo.assignee = user2
|
|
|
|
foo.save
|
|
|
|
bar.assignee = user2
|
|
|
|
bar.save
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sorts with a filter applied' do
|
|
|
|
visit project_issues_path(project, sort: 'oldest', assignee_id: user2.id)
|
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
first_issue.should include("bar")
|
|
|
|
last_issue.should include("foo")
|
2013-11-20 17:59:50 -05:00
|
|
|
page.should_not have_content 'baz'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2013-11-27 08:00:57 -05:00
|
|
|
|
2013-12-17 09:39:39 -05:00
|
|
|
describe 'update assignee from issue#show' do
|
|
|
|
let(:issue) { create(:issue, project: project, author: @user) }
|
|
|
|
|
|
|
|
context 'by autorized user' do
|
|
|
|
|
|
|
|
it 'with dropdown menu' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
2014-02-18 09:21:13 -05:00
|
|
|
find('.edit-issue.inline-update #issue_assignee_id').set project.team.members.first.id
|
2013-12-17 09:39:39 -05:00
|
|
|
click_button 'Update Issue'
|
|
|
|
|
2014-02-19 03:35:24 -05:00
|
|
|
page.should have_content "Assignee:"
|
2013-12-17 09:39:39 -05:00
|
|
|
page.has_select?('issue_assignee_id', :selected => project.team.members.first.name)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'by unauthorized user' do
|
2013-12-20 01:56:39 -05:00
|
|
|
|
2013-12-17 09:39:39 -05:00
|
|
|
let(:guest) { create(:user) }
|
2013-12-20 01:56:39 -05:00
|
|
|
|
2013-12-17 09:39:39 -05:00
|
|
|
before :each do
|
|
|
|
project.team << [[guest], :guest]
|
|
|
|
issue.assignee = @user
|
|
|
|
issue.save
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows assignee text' do
|
|
|
|
logout
|
|
|
|
login_with guest
|
|
|
|
|
|
|
|
visit project_issue_path(project, issue)
|
2014-02-19 03:35:24 -05:00
|
|
|
page.should have_content issue.assignee.name
|
2013-12-17 09:39:39 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'update milestone from issue#show' do
|
|
|
|
let!(:issue) { create(:issue, project: project, author: @user) }
|
|
|
|
let!(:milestone) { create(:milestone, project: project) }
|
|
|
|
|
|
|
|
context 'by authorized user' do
|
|
|
|
|
|
|
|
it 'with dropdown menu' do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
|
|
|
|
find('.edit-issue.inline-update').select(milestone.title, from: 'issue_milestone_id')
|
|
|
|
click_button 'Update Issue'
|
|
|
|
|
2014-02-19 03:35:24 -05:00
|
|
|
page.should have_content "Milestone"
|
2013-12-17 09:39:39 -05:00
|
|
|
page.has_select?('issue_assignee_id', :selected => milestone.title)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'by unauthorized user' do
|
|
|
|
let(:guest) { create(:user) }
|
2013-12-20 01:56:39 -05:00
|
|
|
|
2013-12-17 09:39:39 -05:00
|
|
|
before :each do
|
2014-02-19 03:35:24 -05:00
|
|
|
project.team << [guest, :guest]
|
2013-12-17 09:39:39 -05:00
|
|
|
issue.milestone = milestone
|
|
|
|
issue.save
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows milestone text' do
|
|
|
|
logout
|
|
|
|
login_with guest
|
|
|
|
|
|
|
|
visit project_issue_path(project, issue)
|
2014-02-19 03:35:24 -05:00
|
|
|
page.should have_content milestone.title
|
2013-12-17 09:39:39 -05:00
|
|
|
end
|
|
|
|
end
|
2014-03-02 12:29:01 -05:00
|
|
|
|
|
|
|
describe 'removing assignee' do
|
|
|
|
let(:user2) { create(:user) }
|
|
|
|
|
|
|
|
before :each do
|
|
|
|
issue.assignee = user2
|
|
|
|
issue.save
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows user to remove assignee', :js => true do
|
|
|
|
visit project_issue_path(project, issue)
|
|
|
|
page.should have_content "Assignee: #{user2.name}"
|
|
|
|
|
|
|
|
page.first('#s2id_issue_assignee_id').click
|
|
|
|
sleep 2 # wait for ajax stuff to complete
|
|
|
|
page.first('.user-result').click
|
|
|
|
|
|
|
|
page.should have_content "Assignee: Unassigned"
|
|
|
|
sleep 2 # wait for ajax stuff to complete
|
|
|
|
issue.reload.assignee.should be_nil
|
|
|
|
end
|
|
|
|
end
|
2013-12-17 09:39:39 -05:00
|
|
|
end
|
|
|
|
|
2013-11-27 08:00:57 -05:00
|
|
|
def first_issue
|
|
|
|
all("ul.issues-list li").first.text
|
|
|
|
end
|
|
|
|
|
|
|
|
def last_issue
|
|
|
|
all("ul.issues-list li").last.text
|
|
|
|
end
|
2014-02-19 03:35:24 -05:00
|
|
|
end
|