gitlab-org--gitlab-foss/app/helpers/performance_bar_helper.rb

# frozen_string_literal: true

module PerformanceBarHelper
  def performance_bar_enabled?
    Gitlab::PerformanceBar.enabled_for_request?
  end
end
Enable frozen string for app/helpers/*/.rb Partially addresses #47424. 2018-08-18 11:19:57 +00:00			`# frozen_string_literal: true`

Improve & fix the performance bar UI and behavior 2017-07-06 19:37:31 +00:00			`module PerformanceBarHelper`
			`def performance_bar_enabled?`
Make performance bar enabled checks consistent Previously, we called the `peek_enabled?` method like so: prepend_before_action :set_peek_request_id, if: :peek_enabled? Now we don't have a `set_peek_request_id` method, so we don't need that line. However, the `peek_enabled?` part had a side-effect: it would also populate the request store cache for whether the performance bar was enabled for the current request or not. This commit makes that side-effect explicit, and replaces all uses of `peek_enabled?` with the more explicit `Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that still sets `SafeRequestStore[:peek_enabled]` directly, because it is contrasting behaviour with and without a request store enabled. The upshot is: 1. We still set the value in one place. We make it more explicit that that's what we're doing. 2. Reading that value uses a consistent method so it's easier to find in future. 2019-08-27 11:40:44 +00:00			`Gitlab::PerformanceBar.enabled_for_request?`
Improve & fix the performance bar UI and behavior 2017-07-06 19:37:31 +00:00			`end`
			`end`