2017-05-29 01:49:17 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 10:24:02 -04:00
|
|
|
describe API::Events do
|
2017-05-29 01:49:17 -04:00
|
|
|
include ApiHelpers
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:non_member) { create(:user) }
|
|
|
|
let(:other_user) { create(:user, username: 'otheruser') }
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:private_project) { create(:project, :private, creator_id: user.id, namespace: user.namespace) }
|
2017-05-29 01:49:17 -04:00
|
|
|
let(:closed_issue) { create(:closed_issue, project: private_project, author: user) }
|
|
|
|
let!(:closed_issue_event) { create(:event, project: private_project, author: user, target: closed_issue, action: Event::CLOSED, created_at: Date.new(2016, 12, 30)) }
|
|
|
|
|
|
|
|
describe 'GET /events' do
|
|
|
|
context 'when unauthenticated' do
|
|
|
|
it 'returns authentication error' do
|
|
|
|
get api('/events')
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(401)
|
2017-05-29 01:49:17 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when authenticated' do
|
|
|
|
it 'returns users events' do
|
|
|
|
get api('/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31', user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-05-29 01:49:17 -04:00
|
|
|
expect(response).to include_pagination_headers
|
|
|
|
expect(json_response).to be_an Array
|
|
|
|
expect(json_response.size).to eq(1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET /users/:id/events' do
|
|
|
|
context "as a user that cannot see the event's project" do
|
|
|
|
it 'returns no events' do
|
|
|
|
get api("/users/#{user.id}/events", other_user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-05-29 01:49:17 -04:00
|
|
|
expect(json_response).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "as a user that can see the event's project" do
|
2017-06-01 23:41:47 -04:00
|
|
|
it 'accepts a username' do
|
|
|
|
get api("/users/#{user.username}/events", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-06-01 23:41:47 -04:00
|
|
|
expect(response).to include_pagination_headers
|
|
|
|
expect(json_response).to be_an Array
|
|
|
|
expect(json_response.size).to eq(1)
|
|
|
|
end
|
|
|
|
|
2017-05-29 01:49:17 -04:00
|
|
|
it 'returns the events' do
|
|
|
|
get api("/users/#{user.id}/events", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-05-29 01:49:17 -04:00
|
|
|
expect(response).to include_pagination_headers
|
|
|
|
expect(json_response).to be_an Array
|
|
|
|
expect(json_response.size).to eq(1)
|
|
|
|
end
|
|
|
|
|
Migrate events into a new format
This commit migrates events data in such a way that push events are
stored much more efficiently. This is done by creating a shadow table
called "events_for_migration", and a table called "push_event_payloads"
which is used for storing push data of push events. The background
migration in this commit will copy events from the "events" table into
the "events_for_migration" table, push events in will also have a row
created in "push_event_payloads".
This approach allows us to reclaim space in the next release by simply
swapping the "events" and "events_for_migration" tables, then dropping
the old events (now "events_for_migration") table.
The new table structure is also optimised for storage space, and does
not include the unused "title" column nor the "data" column (since this
data is moved to "push_event_payloads").
== Newly Created Events
Newly created events are inserted into both "events" and
"events_for_migration", both using the exact same primary key value. The
table "push_event_payloads" in turn has a foreign key to the _shadow_
table. This removes the need for recreating and validating the foreign
key after swapping the tables. Since the shadow table also has a foreign
key to "projects.id" we also don't have to worry about orphaned rows.
This approach however does require some additional storage as we're
duplicating a portion of the events data for at least 1 release. The
exact amount is hard to estimate, but for GitLab.com this is expected to
be between 10 and 20 GB at most. The background migration in this commit
deliberately does _not_ update the "events" table as doing so would put
a lot of pressure on PostgreSQL's auto vacuuming system.
== Supporting Both Old And New Events
Application code has also been adjusted to support push events using
both the old and new data formats. This is done by creating a PushEvent
class which extends the regular Event class. Using Rails' Single Table
Inheritance system we can ensure the right class is used for the right
data, which in this case is based on the value of `events.action`. To
support displaying old and new data at the same time the PushEvent class
re-defines a few methods of the Event class, falling back to their
original implementations for push events in the old format.
Once all existing events have been migrated the various push event
related methods can be removed from the Event model, and the calls to
`super` can be removed from the methods in the PushEvent model.
The UI and event atom feed have also been slightly changed to better
handle this new setup, fortunately only a few changes were necessary to
make this work.
== API Changes
The API only displays push data of events in the new format. Supporting
both formats in the API is a bit more difficult compared to the UI.
Since the old push data was not really well documented (apart from one
example that used an incorrect "action" nmae) I decided that supporting
both was not worth the effort, especially since events will be migrated
in a few days _and_ new events are created in the correct format.
2017-07-10 11:43:57 -04:00
|
|
|
context 'when the list of events includes push events' do
|
|
|
|
let(:event) do
|
|
|
|
create(:push_event, author: user, project: private_project)
|
|
|
|
end
|
|
|
|
|
|
|
|
let!(:payload) { create(:push_event_payload, event: event) }
|
|
|
|
let(:payload_hash) { json_response[0]['push_data'] }
|
|
|
|
|
|
|
|
before do
|
|
|
|
get api("/users/#{user.id}/events?action=pushed", user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'responds with HTTP 200 OK' do
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
Migrate events into a new format
This commit migrates events data in such a way that push events are
stored much more efficiently. This is done by creating a shadow table
called "events_for_migration", and a table called "push_event_payloads"
which is used for storing push data of push events. The background
migration in this commit will copy events from the "events" table into
the "events_for_migration" table, push events in will also have a row
created in "push_event_payloads".
This approach allows us to reclaim space in the next release by simply
swapping the "events" and "events_for_migration" tables, then dropping
the old events (now "events_for_migration") table.
The new table structure is also optimised for storage space, and does
not include the unused "title" column nor the "data" column (since this
data is moved to "push_event_payloads").
== Newly Created Events
Newly created events are inserted into both "events" and
"events_for_migration", both using the exact same primary key value. The
table "push_event_payloads" in turn has a foreign key to the _shadow_
table. This removes the need for recreating and validating the foreign
key after swapping the tables. Since the shadow table also has a foreign
key to "projects.id" we also don't have to worry about orphaned rows.
This approach however does require some additional storage as we're
duplicating a portion of the events data for at least 1 release. The
exact amount is hard to estimate, but for GitLab.com this is expected to
be between 10 and 20 GB at most. The background migration in this commit
deliberately does _not_ update the "events" table as doing so would put
a lot of pressure on PostgreSQL's auto vacuuming system.
== Supporting Both Old And New Events
Application code has also been adjusted to support push events using
both the old and new data formats. This is done by creating a PushEvent
class which extends the regular Event class. Using Rails' Single Table
Inheritance system we can ensure the right class is used for the right
data, which in this case is based on the value of `events.action`. To
support displaying old and new data at the same time the PushEvent class
re-defines a few methods of the Event class, falling back to their
original implementations for push events in the old format.
Once all existing events have been migrated the various push event
related methods can be removed from the Event model, and the calls to
`super` can be removed from the methods in the PushEvent model.
The UI and event atom feed have also been slightly changed to better
handle this new setup, fortunately only a few changes were necessary to
make this work.
== API Changes
The API only displays push data of events in the new format. Supporting
both formats in the API is a bit more difficult compared to the UI.
Since the old push data was not really well documented (apart from one
example that used an incorrect "action" nmae) I decided that supporting
both was not worth the effort, especially since events will be migrated
in a few days _and_ new events are created in the correct format.
2017-07-10 11:43:57 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the push payload as a Hash' do
|
|
|
|
expect(payload_hash).to be_an_instance_of(Hash)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the push payload details' do
|
|
|
|
expect(payload_hash['commit_count']).to eq(payload.commit_count)
|
|
|
|
expect(payload_hash['action']).to eq(payload.action)
|
|
|
|
expect(payload_hash['ref_type']).to eq(payload.ref_type)
|
|
|
|
expect(payload_hash['commit_to']).to eq(payload.commit_to)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-29 01:49:17 -04:00
|
|
|
context 'when there are multiple events from different projects' do
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:second_note) { create(:note_on_issue, project: create(:project)) }
|
2017-05-29 01:49:17 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
second_note.project.add_user(user, :developer)
|
|
|
|
|
|
|
|
[second_note].each do |note|
|
|
|
|
EventCreateService.new.leave_note(note, user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns events in the correct order (from newest to oldest)' do
|
|
|
|
get api("/users/#{user.id}/events", user)
|
|
|
|
|
|
|
|
comment_events = json_response.select { |e| e['action_name'] == 'commented on' }
|
|
|
|
close_events = json_response.select { |e| e['action_name'] == 'closed' }
|
|
|
|
|
|
|
|
expect(comment_events[0]['target_id']).to eq(second_note.id)
|
|
|
|
expect(close_events[0]['target_id']).to eq(closed_issue.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'accepts filter parameters' do
|
|
|
|
get api("/users/#{user.id}/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31", user)
|
|
|
|
|
|
|
|
expect(json_response.size).to eq(1)
|
|
|
|
expect(json_response[0]['target_id']).to eq(closed_issue.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a 404 error if not found' do
|
|
|
|
get api('/users/42/events', user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2017-05-29 01:49:17 -04:00
|
|
|
expect(json_response['message']).to eq('404 User Not Found')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET /projects/:id/events' do
|
|
|
|
context 'when unauthenticated ' do
|
|
|
|
it 'returns 404 for private project' do
|
|
|
|
get api("/projects/#{private_project.id}/events")
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2017-05-29 01:49:17 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 200 status for a public project' do
|
2017-08-02 15:55:11 -04:00
|
|
|
public_project = create(:project, :public)
|
2017-05-29 01:49:17 -04:00
|
|
|
|
|
|
|
get api("/projects/#{public_project.id}/events")
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-05-29 01:49:17 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when not permitted to read' do
|
|
|
|
it 'returns 404' do
|
|
|
|
get api("/projects/#{private_project.id}/events", non_member)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2017-05-29 01:49:17 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when authenticated' do
|
|
|
|
it 'returns project events' do
|
|
|
|
get api("/projects/#{private_project.id}/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-05-29 01:49:17 -04:00
|
|
|
expect(response).to include_pagination_headers
|
|
|
|
expect(json_response).to be_an Array
|
|
|
|
expect(json_response.size).to eq(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 404 if project does not exist' do
|
|
|
|
get api("/projects/1234/events", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2017-05-29 01:49:17 -04:00
|
|
|
end
|
|
|
|
end
|
2017-08-08 07:31:55 -04:00
|
|
|
|
|
|
|
context 'when exists some events' do
|
2017-08-08 10:27:38 -04:00
|
|
|
let(:merge_request1) { create(:merge_request, :closed, author: user, assignee: user, source_project: private_project, title: 'Test') }
|
|
|
|
let(:merge_request2) { create(:merge_request, :closed, author: user, assignee: user, source_project: private_project, title: 'Test') }
|
|
|
|
|
2017-08-08 07:31:55 -04:00
|
|
|
before do
|
|
|
|
create_event(merge_request1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'avoids N+1 queries' do
|
|
|
|
control_count = ActiveRecord::QueryRecorder.new do
|
2017-08-08 10:27:38 -04:00
|
|
|
get api("/projects/#{private_project.id}/events", user), target_type: :merge_request
|
2017-08-08 07:31:55 -04:00
|
|
|
end.count
|
|
|
|
|
|
|
|
create_event(merge_request2)
|
|
|
|
|
|
|
|
expect do
|
2017-08-08 10:27:38 -04:00
|
|
|
get api("/projects/#{private_project.id}/events", user), target_type: :merge_request
|
2017-08-08 07:31:55 -04:00
|
|
|
end.not_to exceed_query_limit(control_count)
|
|
|
|
|
2017-08-08 10:27:38 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2017-08-08 07:31:55 -04:00
|
|
|
expect(response).to include_pagination_headers
|
2017-08-08 10:27:38 -04:00
|
|
|
expect(json_response.size).to eq(2)
|
|
|
|
expect(json_response.map { |r| r['target_id'] }).to match_array([merge_request1.id, merge_request2.id])
|
2017-08-08 07:31:55 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def create_event(target)
|
|
|
|
create(:event, project: private_project, author: user, target: target)
|
|
|
|
end
|
|
|
|
end
|
2017-05-29 01:49:17 -04:00
|
|
|
end
|
|
|
|
end
|