2019-10-16 05:07:51 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-03-21 18:11:24 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-16 14:09:01 -04:00
|
|
|
RSpec.describe GroupProjectsFinder do
|
2019-03-19 13:24:16 -04:00
|
|
|
include_context 'GroupProjectsFinder context'
|
2016-03-21 18:11:24 -04:00
|
|
|
|
2017-03-03 05:35:04 -05:00
|
|
|
subject { finder.execute }
|
|
|
|
|
2016-03-21 18:11:24 -04:00
|
|
|
describe 'with a group member current user' do
|
2017-03-03 05:35:04 -05:00
|
|
|
before do
|
2022-02-10 16:15:20 -05:00
|
|
|
root_group.add_maintainer(current_user)
|
2017-03-03 05:35:04 -05:00
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
|
|
|
|
context "only shared" do
|
2017-03-03 05:35:04 -05:00
|
|
|
let(:options) { { only_shared: true } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1]) }
|
2022-02-10 16:15:20 -05:00
|
|
|
|
|
|
|
context 'with ancestor groups projects' do
|
|
|
|
before do
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with subgroups projects' do
|
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1]) }
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "only owned" do
|
2017-03-03 05:35:04 -05:00
|
|
|
let(:options) { { only_owned: true } }
|
|
|
|
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'with subgroups projects' do
|
2018-01-24 01:06:24 -05:00
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([private_project, public_project, subgroup_project, subgroup_private_project]) }
|
|
|
|
end
|
|
|
|
|
2022-02-10 16:15:20 -05:00
|
|
|
context 'with ancestor group projects' do
|
|
|
|
before do
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([private_project, public_project, root_group_public_project, root_group_private_project, root_group_private_project_2]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with ancestor groups and subgroups projects' do
|
|
|
|
before do
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([private_project, public_project, root_group_public_project, root_group_private_project, root_group_private_project_2, subgroup_private_project, subgroup_project]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without subgroups and ancestor group projects' do
|
2018-01-24 01:06:24 -05:00
|
|
|
it { is_expected.to match_array([private_project, public_project]) }
|
|
|
|
end
|
2022-02-10 16:15:20 -05:00
|
|
|
|
|
|
|
context 'when user is member only of a subgroup' do
|
|
|
|
let(:subgroup_member) { create(:user) }
|
|
|
|
|
|
|
|
context 'with ancestor groups and subgroups projects' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(subgroup_member)
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not return parent group projects' do
|
|
|
|
finder = described_class.new(group: group, current_user: subgroup_member, params: params, options: options)
|
|
|
|
|
|
|
|
projects = finder.execute
|
|
|
|
|
|
|
|
expect(projects).to match_array([private_project, public_project, subgroup_project, subgroup_private_project, root_group_public_project])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "all" do
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'with subgroups projects' do
|
2018-01-24 01:06:24 -05:00
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1, private_project, public_project, subgroup_project, subgroup_private_project]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without subgroups projects' do
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1, private_project, public_project]) }
|
|
|
|
end
|
2020-06-30 17:09:47 -04:00
|
|
|
|
|
|
|
context "with min access level" do
|
|
|
|
let!(:shared_project_4) { create(:project, :internal, path: '8') }
|
|
|
|
|
|
|
|
before do
|
2020-08-04 17:09:56 -04:00
|
|
|
shared_project_4.project_group_links.create!(group_access: Gitlab::Access::REPORTER, group: group)
|
2020-06-30 17:09:47 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
let(:params) { { min_access_level: Gitlab::Access::MAINTAINER } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1, private_project, public_project]) }
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'without group member current_user' do
|
2016-10-11 08:25:17 -04:00
|
|
|
before do
|
2018-07-11 10:36:08 -04:00
|
|
|
shared_project_2.add_maintainer(current_user)
|
2016-10-11 08:25:17 -04:00
|
|
|
current_user.reload
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
|
|
|
|
context "only shared" do
|
2017-03-03 05:35:04 -05:00
|
|
|
let(:options) { { only_shared: true } }
|
|
|
|
|
2016-03-21 18:11:24 -04:00
|
|
|
context "without external user" do
|
2017-03-03 05:35:04 -05:00
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1]) }
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "with external user" do
|
2017-03-03 05:35:04 -05:00
|
|
|
before do
|
2020-08-04 17:09:56 -04:00
|
|
|
current_user.update!(external: true)
|
2017-03-03 05:35:04 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_2, shared_project_1]) }
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "only owned" do
|
2017-03-03 05:35:04 -05:00
|
|
|
let(:options) { { only_owned: true } }
|
|
|
|
|
2016-03-21 18:11:24 -04:00
|
|
|
context "without external user" do
|
2017-03-03 05:35:04 -05:00
|
|
|
before do
|
2018-07-11 10:36:08 -04:00
|
|
|
private_project.add_maintainer(current_user)
|
|
|
|
subgroup_private_project.add_maintainer(current_user)
|
2022-02-10 16:15:20 -05:00
|
|
|
root_group_private_project.add_maintainer(current_user)
|
2017-03-03 05:35:04 -05:00
|
|
|
end
|
|
|
|
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'with subgroups projects' do
|
2018-01-24 01:06:24 -05:00
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([private_project, public_project, subgroup_project, subgroup_private_project]) }
|
|
|
|
end
|
|
|
|
|
2022-02-10 16:15:20 -05:00
|
|
|
context 'with ancestor groups projects' do
|
|
|
|
before do
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([private_project, public_project, root_group_public_project, root_group_private_project]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with ancestor groups and subgroups projects' do
|
|
|
|
before do
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([private_project, public_project, root_group_private_project, root_group_public_project, subgroup_private_project, subgroup_project]) }
|
|
|
|
end
|
|
|
|
|
2018-01-24 01:06:24 -05:00
|
|
|
context 'without subgroups projects' do
|
|
|
|
it { is_expected.to match_array([private_project, public_project]) }
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "with external user" do
|
2017-03-03 05:35:04 -05:00
|
|
|
before do
|
2020-08-04 17:09:56 -04:00
|
|
|
current_user.update!(external: true)
|
2017-03-03 05:35:04 -05:00
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'with subgroups projects' do
|
2018-01-24 01:06:24 -05:00
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([public_project, subgroup_project]) }
|
|
|
|
end
|
|
|
|
|
2022-02-10 16:15:20 -05:00
|
|
|
context 'with ancestor groups projects' do
|
|
|
|
before do
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([public_project, root_group_public_project]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with ancestor groups and subgroups projects' do
|
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
options[:include_ancestor_groups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([public_project, root_group_public_project, subgroup_project]) }
|
|
|
|
end
|
|
|
|
|
2018-01-24 01:06:24 -05:00
|
|
|
context 'without subgroups projects' do
|
|
|
|
it { is_expected.to eq([public_project]) }
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
end
|
2017-03-03 05:35:04 -05:00
|
|
|
|
|
|
|
context "all" do
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'with subgroups projects' do
|
2018-01-24 01:06:24 -05:00
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1, public_project, subgroup_project]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without subgroups projects' do
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_2, shared_project_1, public_project]) }
|
|
|
|
end
|
2017-03-03 05:35:04 -05:00
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
|
2019-03-19 13:24:16 -04:00
|
|
|
describe 'with an admin current user' do
|
|
|
|
let(:current_user) { create(:admin) }
|
|
|
|
|
2021-01-08 10:10:26 -05:00
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
|
|
context "only shared" do
|
|
|
|
let(:options) { { only_shared: true } }
|
2019-12-17 13:07:48 -05:00
|
|
|
|
2021-01-08 10:10:26 -05:00
|
|
|
it { is_expected.to contain_exactly(shared_project_3, shared_project_2, shared_project_1) }
|
|
|
|
end
|
2019-03-19 13:24:16 -04:00
|
|
|
|
2021-01-08 10:10:26 -05:00
|
|
|
context "only owned" do
|
|
|
|
let(:options) { { only_owned: true } }
|
|
|
|
|
|
|
|
it { is_expected.to contain_exactly(private_project, public_project) }
|
|
|
|
end
|
2019-12-17 13:07:48 -05:00
|
|
|
|
2021-01-08 10:10:26 -05:00
|
|
|
context "all" do
|
|
|
|
it { is_expected.to contain_exactly(shared_project_3, shared_project_2, shared_project_1, private_project, public_project) }
|
|
|
|
end
|
2019-03-19 13:24:16 -04:00
|
|
|
end
|
|
|
|
|
2021-01-08 10:10:26 -05:00
|
|
|
context 'when admin mode is disabled' do
|
|
|
|
context "only shared" do
|
|
|
|
let(:options) { { only_shared: true } }
|
|
|
|
|
|
|
|
it { is_expected.to contain_exactly(shared_project_3, shared_project_1) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "only owned" do
|
|
|
|
let(:options) { { only_owned: true } }
|
|
|
|
|
|
|
|
it { is_expected.to contain_exactly(public_project) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "all" do
|
|
|
|
it { is_expected.to contain_exactly(shared_project_3, shared_project_1, public_project) }
|
|
|
|
end
|
2019-03-19 13:24:16 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-21 18:11:24 -04:00
|
|
|
describe "no user" do
|
|
|
|
context "only shared" do
|
2017-03-03 05:35:04 -05:00
|
|
|
let(:options) { { only_shared: true } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([shared_project_3, shared_project_1]) }
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context "only owned" do
|
2017-03-03 05:35:04 -05:00
|
|
|
let(:options) { { only_owned: true } }
|
|
|
|
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'with subgroups projects' do
|
2018-01-24 01:06:24 -05:00
|
|
|
before do
|
|
|
|
options[:include_subgroups] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match_array([public_project, subgroup_project]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without subgroups projects' do
|
|
|
|
it { is_expected.to eq([public_project]) }
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|
|
|
|
end
|
2019-12-07 13:07:50 -05:00
|
|
|
|
2020-06-30 17:09:47 -04:00
|
|
|
describe 'feature availability' do
|
|
|
|
let!(:project_with_issues_disabled) { create(:project, :issues_disabled, :internal, path: '9') }
|
|
|
|
let!(:project_with_merge_request_disabled) { create(:project, :merge_requests_disabled, :internal, path: '10') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project_with_issues_disabled.project_group_links.create!(group_access: Gitlab::Access::REPORTER, group: group)
|
|
|
|
project_with_merge_request_disabled.project_group_links.create!(group_access: Gitlab::Access::REPORTER, group: group)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without issues and merge request enabled' do
|
|
|
|
it { is_expected.to match_array([public_project, shared_project_1, shared_project_3, project_with_issues_disabled, project_with_merge_request_disabled]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with issues enabled' do
|
|
|
|
let(:params) { { with_issues_enabled: true } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([public_project, shared_project_1, shared_project_3, project_with_merge_request_disabled]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with merge request enabled' do
|
|
|
|
let(:params) { { with_merge_requests_enabled: true } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([public_project, shared_project_1, shared_project_3, project_with_issues_disabled]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with issues and merge request enabled' do
|
|
|
|
let(:params) { { with_merge_requests_enabled: true, with_issues_enabled: true } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([public_project, shared_project_1, shared_project_3]) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-07 13:07:50 -05:00
|
|
|
describe 'limiting' do
|
|
|
|
context 'without limiting' do
|
|
|
|
it 'returns all projects' do
|
|
|
|
expect(subject.count).to eq(3)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with limiting' do
|
|
|
|
let(:options) { { limit: 1 } }
|
|
|
|
|
|
|
|
it 'returns only the number of projects specified by the limit' do
|
|
|
|
expect(subject.count).to eq(1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-03-21 18:11:24 -04:00
|
|
|
end
|