gitlab-org--gitlab-foss/spec/controllers/import/gitlab_controller_spec.rb

249 lines
8.2 KiB
Ruby
Raw Normal View History

2015-01-27 18:37:19 -05:00
require 'spec_helper'
2015-02-02 20:01:07 -05:00
describe Import::GitlabController do
include ImportSpecHelper
let(:user) { create(:user) }
let(:token) { "asdasd12345" }
let(:access_params) { { gitlab_access_token: token } }
def assign_session_token
session[:gitlab_access_token] = token
end
2015-01-27 18:37:19 -05:00
before do
sign_in(user)
allow(controller).to receive(:gitlab_import_enabled?).and_return(true)
2015-01-27 18:37:19 -05:00
end
describe "GET callback" do
it "updates access token" do
2017-06-21 09:48:12 -04:00
allow_any_instance_of(Gitlab::GitlabImport::Client)
.to receive(:get_token).and_return(token)
stub_omniauth_provider('gitlab')
2015-01-27 18:37:19 -05:00
get :callback
expect(session[:gitlab_access_token]).to eq(token)
expect(controller).to redirect_to(status_import_gitlab_url)
2015-01-27 18:37:19 -05:00
end
end
describe "GET status" do
before do
@repo = OpenStruct.new(path: 'vim', path_with_namespace: 'asd/vim')
assign_session_token
2015-01-27 18:37:19 -05:00
end
it "assigns variables" do
@project = create(:project, import_type: 'gitlab', creator_id: user.id)
stub_client(projects: [@repo])
2015-01-27 18:37:19 -05:00
get :status
expect(assigns(:already_added_projects)).to eq([@project])
expect(assigns(:repos)).to eq([@repo])
end
it "does not show already added project" do
@project = create(:project, import_type: 'gitlab', creator_id: user.id, import_source: 'asd/vim')
stub_client(projects: [@repo])
2015-01-27 18:37:19 -05:00
get :status
expect(assigns(:already_added_projects)).to eq([@project])
expect(assigns(:repos)).to eq([])
end
end
describe "POST create" do
2015-04-01 11:17:18 -04:00
let(:gitlab_username) { user.username }
2015-06-22 16:00:54 -04:00
let(:gitlab_user) do
{ username: gitlab_username }.with_indifferent_access
end
let(:gitlab_repo) do
2015-04-01 11:17:18 -04:00
{
2015-01-27 18:37:19 -05:00
path: 'vim',
2015-04-01 11:17:18 -04:00
path_with_namespace: "#{gitlab_username}/vim",
owner: { name: gitlab_username },
namespace: { path: gitlab_username }
2015-01-27 18:37:19 -05:00
}.with_indifferent_access
2015-06-22 16:00:54 -04:00
end
2015-04-01 11:17:18 -04:00
before do
stub_client(user: gitlab_user, project: gitlab_repo)
assign_session_token
2015-04-01 11:17:18 -04:00
end
context "when the repository owner is the GitLab.com user" do
context "when the GitLab.com user and GitLab server user's usernames match" do
it "takes the current user's namespace" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, user.namespace, user, access_params)
.and_return(double(execute: true))
2015-04-01 11:17:18 -04:00
post :create, format: :js
end
end
context "when the GitLab.com user and GitLab server user's usernames don't match" do
let(:gitlab_username) { "someone_else" }
it "takes the current user's namespace" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, user.namespace, user, access_params)
.and_return(double(execute: true))
2015-04-01 11:17:18 -04:00
post :create, format: :js
end
end
2015-01-27 18:37:19 -05:00
end
2015-04-01 11:17:18 -04:00
context "when the repository owner is not the GitLab.com user" do
let(:other_username) { "someone_else" }
before do
gitlab_repo["namespace"]["path"] = other_username
assign_session_token
2015-04-01 11:17:18 -04:00
end
context "when a namespace with the GitLab.com user's username already exists" do
let!(:existing_namespace) { create(:group, name: other_username) }
2015-04-01 11:17:18 -04:00
context "when the namespace is owned by the GitLab server user" do
before do
existing_namespace.add_owner(user)
end
2015-04-01 11:17:18 -04:00
it "takes the existing namespace" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, existing_namespace, user, access_params)
.and_return(double(execute: true))
2015-04-01 11:17:18 -04:00
post :create, format: :js
end
end
context "when the namespace is not owned by the GitLab server user" do
it "doesn't create a project" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.not_to receive(:new)
2015-04-01 11:17:18 -04:00
post :create, format: :js
end
end
end
context "when a namespace with the GitLab.com user's username doesn't exist" do
context "when current user can create namespaces" do
it "creates the namespace" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).and_return(double(execute: true))
2015-04-01 11:17:18 -04:00
expect { post :create, format: :js }.to change(Namespace, :count).by(1)
end
it "takes the new namespace" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, an_instance_of(Group), user, access_params)
.and_return(double(execute: true))
2015-04-01 11:17:18 -04:00
post :create, format: :js
end
2015-04-01 11:17:18 -04:00
end
context "when current user can't create namespaces" do
before do
user.update_attribute(:can_create_group, false)
end
2015-01-27 18:37:19 -05:00
it "doesn't create the namespace" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).and_return(double(execute: true))
expect { post :create, format: :js }.not_to change(Namespace, :count)
end
it "takes the current user's namespace" do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, user.namespace, user, access_params)
.and_return(double(execute: true))
post :create, format: :js
end
2015-04-01 11:17:18 -04:00
end
end
2017-05-22 14:31:05 -04:00
context 'user has chosen an existing nested namespace for the project' do
let(:parent_namespace) { create(:group, name: 'foo', owner: user) }
let(:nested_namespace) { create(:group, name: 'bar', parent: parent_namespace) }
before do
nested_namespace.add_owner(user)
end
it 'takes the selected namespace and name' do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, nested_namespace, user, access_params)
.and_return(double(execute: true))
post :create, { target_namespace: nested_namespace.full_path, format: :js }
end
end
context 'user has chosen a non-existent nested namespaces for the project' do
let(:test_name) { 'test_name' }
it 'takes the selected namespace and name' do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, kind_of(Namespace), user, access_params)
.and_return(double(execute: true))
post :create, { target_namespace: 'foo/bar', format: :js }
end
it 'creates the namespaces' do
2017-06-21 09:48:12 -04:00
allow(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, kind_of(Namespace), user, access_params)
.and_return(double(execute: true))
expect { post :create, { target_namespace: 'foo/bar', format: :js } }
.to change { Namespace.count }.by(2)
end
it 'new namespace has the right parent' do
2017-06-21 09:48:12 -04:00
allow(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, kind_of(Namespace), user, access_params)
.and_return(double(execute: true))
post :create, { target_namespace: 'foo/bar', format: :js }
expect(Namespace.find_by_path_or_name('bar').parent.path).to eq('foo')
end
end
context 'user has chosen existent and non-existent nested namespaces and name for the project' do
let(:test_name) { 'test_name' }
let!(:parent_namespace) { create(:group, name: 'foo', owner: user) }
it 'takes the selected namespace and name' do
2017-06-21 09:48:12 -04:00
expect(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, kind_of(Namespace), user, access_params)
.and_return(double(execute: true))
post :create, { target_namespace: 'foo/foobar/bar', format: :js }
end
it 'creates the namespaces' do
2017-06-21 09:48:12 -04:00
allow(Gitlab::GitlabImport::ProjectCreator)
.to receive(:new).with(gitlab_repo, kind_of(Namespace), user, access_params)
.and_return(double(execute: true))
expect { post :create, { target_namespace: 'foo/foobar/bar', format: :js } }
.to change { Namespace.count }.by(2)
end
end
2015-01-27 18:37:19 -05:00
end
end
end