2013-01-03 07:06:07 +00:00
|
|
|
# == Issuable concern
|
2012-12-30 14:19:31 +00:00
|
|
|
#
|
2012-10-09 19:09:46 +00:00
|
|
|
# Contains common functionality shared between Issues and MergeRequests
|
2012-12-30 14:19:31 +00:00
|
|
|
#
|
|
|
|
# Used by Issue, MergeRequest
|
|
|
|
#
|
2013-01-03 07:06:07 +00:00
|
|
|
module Issuable
|
2012-08-09 01:40:57 +00:00
|
|
|
extend ActiveSupport::Concern
|
2017-08-23 10:54:14 +00:00
|
|
|
include Gitlab::SQL::Pattern
|
2016-10-06 21:17:11 +00:00
|
|
|
include CacheMarkdownField
|
2015-04-21 13:23:20 +00:00
|
|
|
include Participable
|
2015-10-14 14:20:11 +00:00
|
|
|
include Mentionable
|
2016-02-12 14:58:39 +00:00
|
|
|
include Subscribable
|
2015-11-26 15:16:50 +00:00
|
|
|
include StripAttribute
|
2016-04-16 19:09:08 +00:00
|
|
|
include Awardable
|
2016-09-26 21:36:11 +00:00
|
|
|
include Taskable
|
2017-03-27 14:43:35 +00:00
|
|
|
include Importable
|
2017-05-18 12:24:34 +00:00
|
|
|
include Editable
|
2017-08-01 12:38:45 +00:00
|
|
|
include AfterCommitQueue
|
2017-11-07 13:34:12 +00:00
|
|
|
include Sortable
|
|
|
|
include CreatedAtFilterable
|
2018-02-28 11:16:29 +00:00
|
|
|
include UpdatedAtFilterable
|
2012-08-09 01:40:57 +00:00
|
|
|
|
2017-01-23 20:40:25 +00:00
|
|
|
# This object is used to gather issuable meta data for displaying
|
2017-02-16 20:03:42 +00:00
|
|
|
# upvotes, downvotes, notes and closing merge requests count for issues and merge requests
|
2017-01-23 20:40:25 +00:00
|
|
|
# lists avoiding n+1 queries and improving performance.
|
2017-02-16 20:03:42 +00:00
|
|
|
IssuableMeta = Struct.new(:upvotes, :downvotes, :notes_count, :merge_requests_count)
|
2017-01-23 20:40:25 +00:00
|
|
|
|
2012-08-09 01:40:57 +00:00
|
|
|
included do
|
2016-10-06 21:17:11 +00:00
|
|
|
cache_markdown_field :title, pipeline: :single_line
|
2017-04-19 14:38:46 +00:00
|
|
|
cache_markdown_field :description, issuable_state_filter_enabled: true
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2012-08-10 22:07:50 +00:00
|
|
|
belongs_to :author, class_name: "User"
|
2015-07-30 12:45:54 +00:00
|
|
|
belongs_to :updated_by, class_name: "User"
|
2017-05-03 05:32:21 +00:00
|
|
|
belongs_to :last_edited_by, class_name: 'User'
|
2012-10-30 07:22:24 +00:00
|
|
|
belongs_to :milestone
|
2017-07-07 15:08:49 +00:00
|
|
|
|
2017-06-08 15:16:27 +00:00
|
|
|
has_many :notes, as: :noteable, inverse_of: :noteable, dependent: :destroy do # rubocop:disable Cop/ActiveRecordDependent
|
2016-06-06 20:19:39 +00:00
|
|
|
def authors_loaded?
|
2016-06-21 05:26:43 +00:00
|
|
|
# We check first if we're loaded to not load unnecessarily.
|
2016-06-06 20:19:39 +00:00
|
|
|
loaded? && to_a.all? { |note| note.association(:author).loaded? }
|
|
|
|
end
|
2016-06-21 05:26:43 +00:00
|
|
|
|
|
|
|
def award_emojis_loaded?
|
|
|
|
# We check first if we're loaded to not load unnecessarily.
|
|
|
|
loaded? && to_a.all? { |note| note.association(:award_emoji).loaded? }
|
|
|
|
end
|
2016-06-06 20:19:39 +00:00
|
|
|
end
|
2016-09-14 14:10:31 +00:00
|
|
|
|
2017-06-08 15:16:27 +00:00
|
|
|
has_many :label_links, as: :target, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
|
2018-04-18 13:41:42 +00:00
|
|
|
has_many :labels, through: :label_links
|
2017-06-08 15:16:27 +00:00
|
|
|
has_many :todos, as: :target, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
|
2012-08-09 01:40:57 +00:00
|
|
|
|
2016-09-20 12:43:11 +00:00
|
|
|
has_one :metrics
|
|
|
|
|
2017-02-22 22:35:08 +00:00
|
|
|
delegate :name,
|
|
|
|
:email,
|
2017-02-16 23:41:34 +00:00
|
|
|
:public_email,
|
2017-02-22 22:35:08 +00:00
|
|
|
to: :author,
|
2017-03-17 18:48:01 +00:00
|
|
|
allow_nil: true,
|
2017-02-22 22:35:08 +00:00
|
|
|
prefix: true
|
|
|
|
|
|
|
|
delegate :name,
|
|
|
|
:email,
|
2017-02-16 23:41:34 +00:00
|
|
|
:public_email,
|
2017-02-22 22:35:08 +00:00
|
|
|
to: :assignee,
|
|
|
|
allow_nil: true,
|
|
|
|
prefix: true
|
|
|
|
|
2012-10-09 00:10:04 +00:00
|
|
|
validates :author, presence: true
|
2016-12-02 12:54:57 +00:00
|
|
|
validates :title, presence: true, length: { maximum: 255 }
|
2012-08-09 01:40:57 +00:00
|
|
|
|
2013-08-10 17:25:53 +00:00
|
|
|
scope :authored, ->(user) { where(author_id: user) }
|
2015-11-11 14:17:12 +00:00
|
|
|
scope :recent, -> { reorder(id: :desc) }
|
2013-08-08 14:29:31 +00:00
|
|
|
scope :of_projects, ->(ids) { where(project_id: ids) }
|
2016-02-23 00:08:00 +00:00
|
|
|
scope :of_milestones, ->(ids) { where(milestone_id: ids) }
|
2016-05-19 22:30:38 +00:00
|
|
|
scope :with_milestone, ->(title) { left_joins_milestones.where(milestones: { title: title }) }
|
2017-07-19 14:03:50 +00:00
|
|
|
scope :opened, -> { with_state(:opened) }
|
2014-06-04 15:10:53 +00:00
|
|
|
scope :only_opened, -> { with_state(:opened) }
|
2014-02-28 20:43:16 +00:00
|
|
|
scope :closed, -> { with_state(:closed) }
|
2013-08-19 19:10:56 +00:00
|
|
|
|
2016-04-27 15:35:30 +00:00
|
|
|
scope :left_joins_milestones, -> { joins("LEFT OUTER JOIN milestones ON #{table_name}.milestone_id = milestones.id") }
|
2016-05-05 19:23:51 +00:00
|
|
|
scope :order_milestone_due_desc, -> { left_joins_milestones.reorder('milestones.due_date IS NULL, milestones.id IS NULL, milestones.due_date DESC') }
|
|
|
|
scope :order_milestone_due_asc, -> { left_joins_milestones.reorder('milestones.due_date IS NULL, milestones.id IS NULL, milestones.due_date ASC') }
|
2013-08-19 19:10:56 +00:00
|
|
|
|
2016-04-27 15:35:30 +00:00
|
|
|
scope :without_label, -> { joins("LEFT OUTER JOIN label_links ON label_links.target_type = '#{name}' AND label_links.target_id = #{table_name}.id").where(label_links: { id: nil }) }
|
2015-11-11 11:50:36 +00:00
|
|
|
scope :join_project, -> { joins(:project) }
|
2017-02-21 23:33:53 +00:00
|
|
|
scope :inc_notes_with_associations, -> { includes(notes: [:project, :author, :award_emoji]) }
|
2015-11-11 11:50:36 +00:00
|
|
|
scope :references_project, -> { references(:project) }
|
2016-04-02 12:36:41 +00:00
|
|
|
scope :non_archived, -> { join_project.where(projects: { archived: false }) }
|
2015-11-11 11:50:36 +00:00
|
|
|
|
2015-10-22 13:40:02 +00:00
|
|
|
attr_mentionable :title, pipeline: :single_line
|
2016-05-26 11:38:28 +00:00
|
|
|
attr_mentionable :description
|
|
|
|
|
|
|
|
participant :author
|
|
|
|
participant :notes_with_associations
|
|
|
|
|
2015-11-26 15:16:50 +00:00
|
|
|
strip_attributes :title
|
2016-03-14 20:46:44 +00:00
|
|
|
|
2017-12-07 17:41:30 +00:00
|
|
|
after_save :ensure_metrics, unless: :imported?
|
2016-06-01 23:27:21 +00:00
|
|
|
|
2016-08-01 15:34:17 +00:00
|
|
|
# We want to use optimistic lock for cases when only title or description are involved
|
|
|
|
# http://api.rubyonrails.org/classes/ActiveRecord/Locking/Optimistic.html
|
|
|
|
def locking_enabled?
|
|
|
|
title_changed? || description_changed?
|
|
|
|
end
|
2017-06-14 20:08:24 +00:00
|
|
|
|
|
|
|
def allows_multiple_assignees?
|
|
|
|
false
|
|
|
|
end
|
|
|
|
|
|
|
|
def has_multiple_assignees?
|
2017-06-20 19:32:49 +00:00
|
|
|
assignees.count > 1
|
2017-06-14 20:08:24 +00:00
|
|
|
end
|
2012-08-09 01:40:57 +00:00
|
|
|
end
|
|
|
|
|
2012-08-09 17:45:12 +00:00
|
|
|
module ClassMethods
|
2016-03-01 15:59:36 +00:00
|
|
|
# Searches for records with a matching title.
|
|
|
|
#
|
|
|
|
# This method uses ILIKE on PostgreSQL and LIKE on MySQL.
|
|
|
|
#
|
|
|
|
# query - The search query as a String
|
|
|
|
#
|
|
|
|
# Returns an ActiveRecord::Relation.
|
2012-08-09 17:45:12 +00:00
|
|
|
def search(query)
|
2017-11-24 11:24:24 +00:00
|
|
|
fuzzy_search(query, [:title])
|
2012-08-09 17:45:12 +00:00
|
|
|
end
|
2014-01-14 18:49:32 +00:00
|
|
|
|
2016-03-01 15:59:36 +00:00
|
|
|
# Searches for records with a matching title or description.
|
|
|
|
#
|
|
|
|
# This method uses ILIKE on PostgreSQL and LIKE on MySQL.
|
|
|
|
#
|
|
|
|
# query - The search query as a String
|
|
|
|
#
|
|
|
|
# Returns an ActiveRecord::Relation.
|
2014-08-27 09:47:30 +00:00
|
|
|
def full_search(query)
|
2017-11-24 11:24:24 +00:00
|
|
|
fuzzy_search(query, [:title, :description])
|
2014-08-27 09:47:30 +00:00
|
|
|
end
|
|
|
|
|
2018-04-04 09:19:47 +00:00
|
|
|
def sort_by_attribute(method, excluded_labels: [])
|
2017-09-23 00:46:53 +00:00
|
|
|
sorted =
|
|
|
|
case method.to_s
|
|
|
|
when 'downvotes_desc' then order_downvotes_desc
|
|
|
|
when 'label_priority' then order_labels_priority(excluded_labels: excluded_labels)
|
|
|
|
when 'milestone' then order_milestone_due_asc
|
|
|
|
when 'milestone_due_asc' then order_milestone_due_asc
|
|
|
|
when 'milestone_due_desc' then order_milestone_due_desc
|
|
|
|
when 'popularity' then order_upvotes_desc
|
|
|
|
when 'priority' then order_due_date_and_labels_priority(excluded_labels: excluded_labels)
|
|
|
|
when 'upvotes_desc' then order_upvotes_desc
|
|
|
|
else order_by(method)
|
|
|
|
end
|
2016-06-23 13:15:46 +00:00
|
|
|
|
|
|
|
# Break ties with the ID column for pagination
|
|
|
|
sorted.order(id: :desc)
|
2014-01-14 18:49:32 +00:00
|
|
|
end
|
2016-05-12 07:23:21 +00:00
|
|
|
|
2017-03-10 11:10:48 +00:00
|
|
|
def order_due_date_and_labels_priority(excluded_labels: [])
|
|
|
|
# The order_ methods also modify the query in other ways:
|
|
|
|
#
|
|
|
|
# - For milestones, we add a JOIN.
|
|
|
|
# - For label priority, we change the SELECT, and add a GROUP BY.#
|
|
|
|
#
|
|
|
|
# After doing those, we need to reorder to the order we want. The existing
|
|
|
|
# ORDER BYs won't work because:
|
|
|
|
#
|
|
|
|
# 1. We need milestone due date first.
|
|
|
|
# 2. We can't ORDER BY a column that isn't in the GROUP BY and doesn't
|
|
|
|
# have an aggregate function applied, so we do a useless MIN() instead.
|
|
|
|
#
|
|
|
|
milestones_due_date = 'MIN(milestones.due_date)'
|
|
|
|
|
2017-06-21 13:48:12 +00:00
|
|
|
order_milestone_due_asc
|
|
|
|
.order_labels_priority(excluded_labels: excluded_labels, extra_select_columns: [milestones_due_date])
|
|
|
|
.reorder(Gitlab::Database.nulls_last_order(milestones_due_date, 'ASC'),
|
2017-03-10 11:10:48 +00:00
|
|
|
Gitlab::Database.nulls_last_order('highest_priority', 'ASC'))
|
|
|
|
end
|
|
|
|
|
|
|
|
def order_labels_priority(excluded_labels: [], extra_select_columns: [])
|
2016-10-17 20:03:06 +00:00
|
|
|
params = {
|
|
|
|
target_type: name,
|
|
|
|
target_column: "#{table_name}.id",
|
2016-10-19 13:49:07 +00:00
|
|
|
project_column: "#{table_name}.#{project_foreign_key}",
|
2016-10-17 20:03:06 +00:00
|
|
|
excluded_labels: excluded_labels
|
|
|
|
}
|
|
|
|
|
|
|
|
highest_priority = highest_label_priority(params).to_sql
|
2016-07-26 21:21:20 +00:00
|
|
|
|
2017-03-10 11:10:48 +00:00
|
|
|
select_columns = [
|
|
|
|
"#{table_name}.*",
|
|
|
|
"(#{highest_priority}) AS highest_priority"
|
|
|
|
] + extra_select_columns
|
|
|
|
|
2017-06-21 13:48:12 +00:00
|
|
|
select(select_columns.join(', '))
|
|
|
|
.group(arel_table[:id])
|
|
|
|
.reorder(Gitlab::Database.nulls_last_order('highest_priority', 'ASC'))
|
2016-05-13 15:26:18 +00:00
|
|
|
end
|
|
|
|
|
2016-05-27 19:53:20 +00:00
|
|
|
def with_label(title, sort = nil)
|
2016-05-12 07:23:21 +00:00
|
|
|
if title.is_a?(Array) && title.size > 1
|
2016-05-31 22:33:46 +00:00
|
|
|
joins(:labels).where(labels: { title: title }).group(*grouping_columns(sort)).having("COUNT(DISTINCT labels.title) = #{title.size}")
|
2016-05-12 07:23:21 +00:00
|
|
|
else
|
|
|
|
joins(:labels).where(labels: { title: title })
|
|
|
|
end
|
|
|
|
end
|
2016-05-27 19:53:20 +00:00
|
|
|
|
|
|
|
# Includes table keys in group by clause when sorting
|
|
|
|
# preventing errors in postgres
|
|
|
|
#
|
|
|
|
# Returns an array of arel columns
|
2016-05-31 22:33:46 +00:00
|
|
|
def grouping_columns(sort)
|
|
|
|
grouping_columns = [arel_table[:id]]
|
2016-05-27 19:53:20 +00:00
|
|
|
|
2017-09-23 00:46:53 +00:00
|
|
|
if %w(milestone_due_desc milestone_due_asc milestone).include?(sort)
|
2016-05-27 19:53:20 +00:00
|
|
|
milestone_table = Milestone.arel_table
|
2016-05-31 22:33:46 +00:00
|
|
|
grouping_columns << milestone_table[:id]
|
|
|
|
grouping_columns << milestone_table[:due_date]
|
2016-05-27 19:53:20 +00:00
|
|
|
end
|
|
|
|
|
2016-05-31 22:33:46 +00:00
|
|
|
grouping_columns
|
2016-05-27 19:53:20 +00:00
|
|
|
end
|
2016-10-26 17:34:06 +00:00
|
|
|
|
|
|
|
def to_ability_name
|
|
|
|
model_name.singular
|
|
|
|
end
|
2018-02-28 07:48:23 +00:00
|
|
|
|
|
|
|
def parent_class
|
|
|
|
::Project
|
|
|
|
end
|
2012-08-09 01:40:57 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def today?
|
|
|
|
Date.today == created_at.to_date
|
|
|
|
end
|
|
|
|
|
|
|
|
def new?
|
|
|
|
today? && created_at == updated_at
|
|
|
|
end
|
2012-10-09 22:25:29 +00:00
|
|
|
|
2015-10-13 07:41:46 +00:00
|
|
|
def open?
|
2017-07-19 14:03:50 +00:00
|
|
|
opened?
|
2015-10-13 07:41:46 +00:00
|
|
|
end
|
|
|
|
|
2016-06-01 09:23:09 +00:00
|
|
|
def user_notes_count
|
2016-06-06 20:19:39 +00:00
|
|
|
if notes.loaded?
|
|
|
|
# Use the in-memory association to select and count to avoid hitting the db
|
|
|
|
notes.to_a.count { |note| !note.system? }
|
|
|
|
else
|
|
|
|
# do the count query
|
|
|
|
notes.user.count
|
|
|
|
end
|
2016-06-01 09:23:09 +00:00
|
|
|
end
|
|
|
|
|
2016-10-31 19:19:14 +00:00
|
|
|
def subscribed_without_subscriptions?(user, project)
|
2016-03-01 16:33:13 +00:00
|
|
|
participants(user).include?(user)
|
|
|
|
end
|
|
|
|
|
2017-11-21 17:13:07 +00:00
|
|
|
def to_hook_data(user, old_associations: {})
|
2017-09-15 17:08:27 +00:00
|
|
|
changes = previous_changes
|
2017-11-21 17:13:07 +00:00
|
|
|
old_labels = old_associations.fetch(:labels, [])
|
|
|
|
old_assignees = old_associations.fetch(:assignees, [])
|
2017-09-19 17:23:15 +00:00
|
|
|
|
2017-09-15 17:08:27 +00:00
|
|
|
if old_labels != labels
|
2017-09-19 17:23:15 +00:00
|
|
|
changes[:labels] = [old_labels.map(&:hook_attrs), labels.map(&:hook_attrs)]
|
2017-09-15 17:08:27 +00:00
|
|
|
end
|
|
|
|
|
2017-09-19 17:23:15 +00:00
|
|
|
if old_assignees != assignees
|
|
|
|
if self.is_a?(Issue)
|
|
|
|
changes[:assignees] = [old_assignees.map(&:hook_attrs), assignees.map(&:hook_attrs)]
|
|
|
|
else
|
|
|
|
changes[:assignee] = [old_assignees&.first&.hook_attrs, assignee&.hook_attrs]
|
|
|
|
end
|
2017-05-04 12:11:15 +00:00
|
|
|
end
|
2015-10-17 22:11:36 +00:00
|
|
|
|
2017-11-21 17:13:07 +00:00
|
|
|
if self.respond_to?(:total_time_spent)
|
|
|
|
old_total_time_spent = old_associations.fetch(:total_time_spent, nil)
|
|
|
|
|
|
|
|
if old_total_time_spent != total_time_spent
|
|
|
|
changes[:total_time_spent] = [old_total_time_spent, total_time_spent]
|
|
|
|
end
|
2017-11-14 17:55:00 +00:00
|
|
|
end
|
|
|
|
|
2017-09-19 17:23:15 +00:00
|
|
|
Gitlab::HookData::IssuableBuilder.new(self).build(user: user, changes: changes)
|
2013-12-03 09:31:56 +00:00
|
|
|
end
|
2014-07-30 14:17:29 +00:00
|
|
|
|
2016-06-02 11:17:54 +00:00
|
|
|
def labels_array
|
|
|
|
labels.to_a
|
|
|
|
end
|
|
|
|
|
2014-07-30 14:17:29 +00:00
|
|
|
def label_names
|
|
|
|
labels.order('title ASC').pluck(:title)
|
|
|
|
end
|
|
|
|
|
2015-07-24 19:31:15 +00:00
|
|
|
# Convert this Issuable class name to a format usable by Ability definitions
|
|
|
|
#
|
|
|
|
# Examples:
|
|
|
|
#
|
|
|
|
# issuable.class # => MergeRequest
|
|
|
|
# issuable.to_ability_name # => "merge_request"
|
|
|
|
def to_ability_name
|
2016-10-26 17:34:06 +00:00
|
|
|
self.class.to_ability_name
|
2015-07-24 19:31:15 +00:00
|
|
|
end
|
|
|
|
|
2015-12-24 22:03:54 +00:00
|
|
|
# Returns a Hash of attributes to be used for Twitter card metadata
|
|
|
|
def card_attributes
|
|
|
|
{
|
|
|
|
'Author' => author.try(:name),
|
|
|
|
'Assignee' => assignee.try(:name)
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2015-10-13 09:49:01 +00:00
|
|
|
def notes_with_associations
|
2016-06-06 20:19:39 +00:00
|
|
|
# If A has_many Bs, and B has_many Cs, and you do
|
|
|
|
# `A.includes(b: :c).each { |a| a.b.includes(:c) }`, sadly ActiveRecord
|
|
|
|
# will do the inclusion again. So, we check if all notes in the relation
|
|
|
|
# already have their authors loaded (possibly because the scope
|
|
|
|
# `inc_notes_with_associations` was used) and skip the inclusion if that's
|
|
|
|
# the case.
|
2016-06-21 05:26:43 +00:00
|
|
|
includes = []
|
|
|
|
includes << :author unless notes.authors_loaded?
|
|
|
|
includes << :award_emoji unless notes.award_emojis_loaded?
|
2018-01-11 16:34:01 +00:00
|
|
|
|
2016-06-21 05:26:43 +00:00
|
|
|
if includes.any?
|
|
|
|
notes.includes(includes)
|
|
|
|
else
|
|
|
|
notes
|
|
|
|
end
|
2015-10-13 09:49:01 +00:00
|
|
|
end
|
|
|
|
|
2015-10-22 15:18:59 +00:00
|
|
|
def updated_tasks
|
|
|
|
Taskable.get_updated_tasks(old_content: previous_changes['description'].first,
|
|
|
|
new_content: description)
|
2014-11-05 20:45:18 +00:00
|
|
|
end
|
2016-03-18 13:48:55 +00:00
|
|
|
|
|
|
|
##
|
|
|
|
# Method that checks if issuable can be moved to another project.
|
|
|
|
#
|
|
|
|
# Should be overridden if issuable can be moved.
|
|
|
|
#
|
|
|
|
def can_move?(*)
|
|
|
|
false
|
|
|
|
end
|
2016-09-20 12:43:11 +00:00
|
|
|
|
2017-08-15 13:21:27 +00:00
|
|
|
##
|
|
|
|
# Override in issuable specialization
|
|
|
|
#
|
2017-08-29 13:46:40 +00:00
|
|
|
def first_contribution?
|
2017-08-15 13:21:27 +00:00
|
|
|
false
|
2017-07-29 15:04:42 +00:00
|
|
|
end
|
2017-11-21 19:25:37 +00:00
|
|
|
|
2017-12-07 17:41:30 +00:00
|
|
|
def ensure_metrics
|
|
|
|
self.metrics || create_metrics
|
|
|
|
end
|
|
|
|
|
2017-11-21 19:25:37 +00:00
|
|
|
##
|
|
|
|
# Overriden in MergeRequest
|
|
|
|
#
|
|
|
|
def wipless_title_changed(old_title)
|
|
|
|
old_title != title
|
|
|
|
end
|
2012-08-09 01:26:56 +00:00
|
|
|
end
|