2019-03-30 03:23:56 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-02-18 12:08:36 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe YoutrackService do
|
|
|
|
describe 'Associations' do
|
|
|
|
it { is_expected.to belong_to :project }
|
|
|
|
it { is_expected.to have_one :service_hook }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'Validations' do
|
|
|
|
context 'when service is active' do
|
|
|
|
before do
|
|
|
|
subject.active = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to validate_presence_of(:project_url) }
|
|
|
|
it { is_expected.to validate_presence_of(:issues_url) }
|
2019-09-16 11:06:26 -04:00
|
|
|
|
2019-02-18 12:08:36 -05:00
|
|
|
it_behaves_like 'issue tracker service URL attribute', :project_url
|
|
|
|
it_behaves_like 'issue tracker service URL attribute', :issues_url
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when service is inactive' do
|
|
|
|
before do
|
|
|
|
subject.active = false
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to validate_presence_of(:project_url) }
|
|
|
|
it { is_expected.not_to validate_presence_of(:issues_url) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.reference_pattern' do
|
|
|
|
it_behaves_like 'allows project key on reference pattern'
|
|
|
|
|
|
|
|
it 'does allow project prefix on the reference' do
|
2019-02-18 12:50:48 -05:00
|
|
|
expect(described_class.reference_pattern.match('YT-123')[:issue]).to eq('YT-123')
|
2019-02-18 12:08:36 -05:00
|
|
|
end
|
2020-02-14 07:09:03 -05:00
|
|
|
|
2020-02-18 07:09:15 -05:00
|
|
|
it 'allows lowercase project key on the reference' do
|
|
|
|
expect(described_class.reference_pattern.match('yt-123')[:issue]).to eq('yt-123')
|
2020-02-14 07:09:03 -05:00
|
|
|
end
|
2019-02-18 12:08:36 -05:00
|
|
|
end
|
2019-06-26 10:03:57 -04:00
|
|
|
|
|
|
|
context 'overriding properties' do
|
|
|
|
let(:url) { 'http://youtrack.example.com' }
|
|
|
|
let(:access_params) do
|
|
|
|
{ project_url: url, issues_url: url, new_issue_url: url }
|
|
|
|
end
|
|
|
|
|
2019-10-07 11:05:59 -04:00
|
|
|
# this will be removed as part of https://gitlab.com/gitlab-org/gitlab/issues/29404
|
2019-06-26 10:03:57 -04:00
|
|
|
context 'when data are stored in properties' do
|
|
|
|
let(:properties) { access_params.merge(title: title, description: description) }
|
2019-07-04 13:09:58 -04:00
|
|
|
let(:service) do
|
|
|
|
create(:youtrack_service, :without_properties_callback, properties: properties)
|
|
|
|
end
|
2019-06-26 10:03:57 -04:00
|
|
|
|
2019-09-16 11:06:26 -04:00
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-06-26 10:03:57 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when data are stored in separated fields' do
|
|
|
|
let(:service) do
|
|
|
|
create(:youtrack_service, title: title, description: description, properties: access_params)
|
|
|
|
end
|
|
|
|
|
2019-09-16 11:06:26 -04:00
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-06-26 10:03:57 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when data are stored in both properties and separated fields' do
|
|
|
|
let(:properties) { access_params.merge(title: 'wrong title', description: 'wrong description') }
|
|
|
|
let(:service) do
|
2019-07-04 13:09:58 -04:00
|
|
|
create(:youtrack_service, :without_properties_callback, title: title, description: description, properties: properties)
|
2019-06-26 10:03:57 -04:00
|
|
|
end
|
|
|
|
|
2019-09-16 11:06:26 -04:00
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-06-26 10:03:57 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no title & description are set' do
|
|
|
|
let(:service) do
|
|
|
|
create(:youtrack_service, properties: access_params)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default values' do
|
|
|
|
expect(service.title).to eq('YouTrack')
|
2019-12-12 07:07:33 -05:00
|
|
|
expect(service.description).to eq(s_('IssueTracker|YouTrack issue tracker'))
|
2019-06-26 10:03:57 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-02-18 12:08:36 -05:00
|
|
|
end
|