2016-12-15 19:30:35 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe GroupPolicy do
|
2016-12-15 19:30:35 +00:00
|
|
|
let(:guest) { create(:user) }
|
|
|
|
let(:reporter) { create(:user) }
|
|
|
|
let(:developer) { create(:user) }
|
2018-07-11 14:36:08 +00:00
|
|
|
let(:maintainer) { create(:user) }
|
2016-12-15 19:30:35 +00:00
|
|
|
let(:owner) { create(:user) }
|
|
|
|
let(:admin) { create(:admin) }
|
2018-04-23 16:12:26 +00:00
|
|
|
let(:group) { create(:group, :private) }
|
2016-12-15 19:30:35 +00:00
|
|
|
|
2018-07-03 12:08:46 +00:00
|
|
|
let(:guest_permissions) do
|
|
|
|
[:read_label, :read_group, :upload_file, :read_namespace, :read_group_activity,
|
|
|
|
:read_group_issues, :read_group_boards, :read_group_labels, :read_group_milestones,
|
|
|
|
:read_group_merge_requests]
|
|
|
|
end
|
2017-12-06 11:36:11 +00:00
|
|
|
|
2017-06-02 14:13:10 +00:00
|
|
|
let(:reporter_permissions) { [:admin_label] }
|
|
|
|
|
2018-08-06 19:02:52 +00:00
|
|
|
let(:developer_permissions) { [:admin_milestone] }
|
2017-09-13 20:32:58 +00:00
|
|
|
|
2018-07-11 14:36:08 +00:00
|
|
|
let(:maintainer_permissions) do
|
2016-12-15 19:30:35 +00:00
|
|
|
[
|
2017-09-13 20:32:58 +00:00
|
|
|
:create_projects
|
2016-12-15 19:30:35 +00:00
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:owner_permissions) do
|
|
|
|
[
|
|
|
|
:admin_group,
|
|
|
|
:admin_namespace,
|
|
|
|
:admin_group_member,
|
2017-04-11 16:36:56 +00:00
|
|
|
:change_visibility_level,
|
2018-08-22 12:10:54 +00:00
|
|
|
:set_note_created_at,
|
2017-09-07 18:35:45 +00:00
|
|
|
(Gitlab::Database.postgresql? ? :create_subgroup : nil)
|
|
|
|
].compact
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_guest(guest)
|
|
|
|
group.add_reporter(reporter)
|
|
|
|
group.add_developer(developer)
|
2018-07-11 14:36:08 +00:00
|
|
|
group.add_maintainer(maintainer)
|
2016-12-15 19:30:35 +00:00
|
|
|
group.add_owner(owner)
|
|
|
|
end
|
|
|
|
|
2017-04-06 21:09:58 +00:00
|
|
|
subject { described_class.new(current_user, group) }
|
|
|
|
|
|
|
|
def expect_allowed(*permissions)
|
|
|
|
permissions.each { |p| is_expected.to be_allowed(p) }
|
|
|
|
end
|
|
|
|
|
|
|
|
def expect_disallowed(*permissions)
|
|
|
|
permissions.each { |p| is_expected.not_to be_allowed(p) }
|
|
|
|
end
|
2016-12-15 19:30:35 +00:00
|
|
|
|
|
|
|
context 'with no user' do
|
2018-04-23 16:12:26 +00:00
|
|
|
let(:group) { create(:group, :public) }
|
2016-12-15 19:30:35 +00:00
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it do
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(:read_group)
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_disallowed(:upload_file)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2017-11-27 20:26:50 +00:00
|
|
|
expect_disallowed(:read_namespace)
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-04-23 16:12:26 +00:00
|
|
|
context 'has projects' do
|
|
|
|
let(:current_user) { create(:user) }
|
|
|
|
let(:project) { create(:project, namespace: group) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it do
|
|
|
|
expect_allowed(:read_group, :read_label)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'in subgroups', :nested_groups do
|
|
|
|
let(:subgroup) { create(:group, :private, parent: group) }
|
|
|
|
let(:project) { create(:project, namespace: subgroup) }
|
|
|
|
|
|
|
|
it do
|
|
|
|
expect_allowed(:read_group, :read_label)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-12-15 19:30:35 +00:00
|
|
|
context 'guests' do
|
|
|
|
let(:current_user) { guest }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'reporter' do
|
|
|
|
let(:current_user) { reporter }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'developer' do
|
|
|
|
let(:current_user) { developer }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-07-11 14:36:08 +00:00
|
|
|
context 'maintainer' do
|
|
|
|
let(:current_user) { maintainer }
|
2016-12-15 19:30:35 +00:00
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'owner' do
|
|
|
|
let(:current_user) { owner }
|
|
|
|
|
|
|
|
it do
|
2017-08-22 17:34:27 +00:00
|
|
|
allow(Group).to receive(:supports_nested_groups?).and_return(true)
|
|
|
|
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*owner_permissions)
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { admin }
|
|
|
|
|
|
|
|
it do
|
2017-08-22 17:34:27 +00:00
|
|
|
allow(Group).to receive(:supports_nested_groups?).and_return(true)
|
|
|
|
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*owner_permissions)
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|
|
|
|
end
|
2016-12-13 18:59:39 +00:00
|
|
|
|
2017-08-09 10:58:00 +00:00
|
|
|
describe 'when nested group support feature is disabled' do
|
|
|
|
before do
|
|
|
|
allow(Group).to receive(:supports_nested_groups?).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { admin }
|
|
|
|
|
|
|
|
it 'allows every owner permission except creating subgroups' do
|
|
|
|
create_subgroup_permission = [:create_subgroup]
|
|
|
|
updated_owner_permissions = owner_permissions - create_subgroup_permission
|
|
|
|
|
|
|
|
expect_disallowed(*create_subgroup_permission)
|
|
|
|
expect_allowed(*updated_owner_permissions)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'owner' do
|
|
|
|
let(:current_user) { owner }
|
|
|
|
|
|
|
|
it 'allows every owner permission except creating subgroups' do
|
|
|
|
create_subgroup_permission = [:create_subgroup]
|
|
|
|
updated_owner_permissions = owner_permissions - create_subgroup_permission
|
|
|
|
|
|
|
|
expect_disallowed(*create_subgroup_permission)
|
|
|
|
expect_allowed(*updated_owner_permissions)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-06-02 14:13:10 +00:00
|
|
|
describe 'private nested group use the highest access level from the group and inherited permissions', :nested_groups do
|
2016-12-13 18:59:39 +00:00
|
|
|
let(:nested_group) { create(:group, :private, parent: group) }
|
|
|
|
|
2017-06-02 14:13:10 +00:00
|
|
|
before do
|
|
|
|
nested_group.add_guest(guest)
|
|
|
|
nested_group.add_guest(reporter)
|
|
|
|
nested_group.add_guest(developer)
|
2018-07-11 14:36:08 +00:00
|
|
|
nested_group.add_guest(maintainer)
|
2017-06-02 14:13:10 +00:00
|
|
|
|
2018-08-16 12:46:40 +00:00
|
|
|
group.owners.destroy_all # rubocop: disable DestroyAll
|
2017-06-02 14:13:10 +00:00
|
|
|
|
|
|
|
group.add_guest(owner)
|
|
|
|
nested_group.add_owner(owner)
|
|
|
|
end
|
|
|
|
|
2017-04-06 21:09:58 +00:00
|
|
|
subject { described_class.new(current_user, nested_group) }
|
2016-12-13 18:59:39 +00:00
|
|
|
|
|
|
|
context 'with no user' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_disallowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 18:59:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'guests' do
|
|
|
|
let(:current_user) { guest }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 18:59:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'reporter' do
|
|
|
|
let(:current_user) { reporter }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 18:59:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'developer' do
|
|
|
|
let(:current_user) { developer }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 18:59:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-07-11 14:36:08 +00:00
|
|
|
context 'maintainer' do
|
|
|
|
let(:current_user) { maintainer }
|
2016-12-13 18:59:39 +00:00
|
|
|
|
|
|
|
it do
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 18:59:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'owner' do
|
|
|
|
let(:current_user) { owner }
|
|
|
|
|
|
|
|
it do
|
2017-08-22 17:34:27 +00:00
|
|
|
allow(Group).to receive(:supports_nested_groups?).and_return(true)
|
|
|
|
|
2017-12-06 11:36:11 +00:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 20:32:58 +00:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 14:36:08 +00:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 21:09:58 +00:00
|
|
|
expect_allowed(*owner_permissions)
|
2016-12-13 18:59:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-09-02 01:00:46 +00:00
|
|
|
|
|
|
|
describe 'change_share_with_group_lock' do
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the current_user owns the group' do
|
|
|
|
let(:current_user) { owner }
|
2017-09-02 01:00:46 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the group share_with_group_lock is enabled' do
|
|
|
|
let(:group) { create(:group, share_with_group_lock: true, parent: parent) }
|
2017-09-02 01:00:46 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the parent group share_with_group_lock is enabled' do
|
|
|
|
context 'when the group has a grandparent' do
|
|
|
|
let(:parent) { create(:group, share_with_group_lock: true, parent: grandparent) }
|
2017-09-02 01:00:46 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the grandparent share_with_group_lock is enabled' do
|
|
|
|
let(:grandparent) { create(:group, share_with_group_lock: true) }
|
|
|
|
|
|
|
|
context 'when the current_user owns the parent' do
|
|
|
|
before do
|
|
|
|
parent.add_owner(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the current_user owns the grandparent' do
|
|
|
|
before do
|
|
|
|
grandparent.add_owner(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the current_user does not own the grandparent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 17:38:24 +00:00
|
|
|
end
|
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the current_user does not own the parent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 17:38:24 +00:00
|
|
|
end
|
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the grandparent share_with_group_lock is disabled' do
|
|
|
|
let(:grandparent) { create(:group) }
|
|
|
|
|
|
|
|
context 'when the current_user owns the parent' do
|
|
|
|
before do
|
|
|
|
parent.add_owner(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
2017-09-05 17:38:24 +00:00
|
|
|
end
|
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the current_user does not own the parent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 17:38:24 +00:00
|
|
|
end
|
|
|
|
end
|
2017-09-02 01:00:46 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the group does not have a grandparent' do
|
|
|
|
let(:parent) { create(:group, share_with_group_lock: true) }
|
2017-09-05 17:38:24 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the current_user owns the parent' do
|
|
|
|
before do
|
|
|
|
parent.add_owner(current_user)
|
|
|
|
end
|
2017-09-05 17:38:24 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 17:38:24 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the current_user does not own the parent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 17:38:24 +00:00
|
|
|
end
|
2017-09-02 01:00:46 +00:00
|
|
|
end
|
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the parent group share_with_group_lock is disabled' do
|
|
|
|
let(:parent) { create(:group) }
|
2017-09-02 01:00:46 +00:00
|
|
|
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-06 06:05:25 +00:00
|
|
|
end
|
2017-09-02 01:00:46 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the group share_with_group_lock is disabled' do
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
2017-09-02 01:00:46 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
context 'when the current_user does not own the group' do
|
|
|
|
let(:current_user) { create(:user) }
|
2017-09-02 01:00:46 +00:00
|
|
|
|
2017-09-06 06:05:25 +00:00
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
2017-09-02 01:00:46 +00:00
|
|
|
end
|
|
|
|
end
|
2016-12-15 19:30:35 +00:00
|
|
|
end
|