gitlab-org--gitlab-foss/config/initializers/deprecations.rb

if Rails.env.development? || ENV['GITLAB_LEGACY_PATH_LOG_MESSAGE']
  deprecator = ActiveSupport::Deprecation.new('11.0', 'GitLab')

  deprecator.behavior = -> (message, callstack) {
    Rails.logger.warn("#{message}: #{callstack[1..20].join}") # rubocop:disable Gitlab/RailsLogger
  }

  ActiveSupport::Deprecation.deprecate_methods(Gitlab::GitalyClient::StorageSettings, :legacy_disk_path, deprecator: deprecator)
end
Conditionally add Gitaly deprecation warnings based on ENV variable 2018-05-17 13:12:48 -04:00			`if Rails.env.development? \|\| ENV['GITLAB_LEGACY_PATH_LOG_MESSAGE']`
More verbose logging for deprecated path access Current logging tells us we've isolated the calls to about 5 call sites, now we'd like to know what is calling these methods. 2018-05-14 09:08:51 -04:00			`deprecator = ActiveSupport::Deprecation.new('11.0', 'GitLab')`

			`deprecator.behavior = -> (message, callstack) {`
Add a rubocop for Rails.logger Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102 2019-07-10 15:26:47 -04:00			`Rails.logger.warn("#{message}: #{callstack[1..20].join}") # rubocop:disable Gitlab/RailsLogger`
More verbose logging for deprecated path access Current logging tells us we've isolated the calls to about 5 call sites, now we'd like to know what is calling these methods. 2018-05-14 09:08:51 -04:00			`}`

Deprecate legacy disk paths Direct disk access is impossible on environments where components run in their own container. There for constructing the path should not be done except for exceptional cases. One of the considerations, instead of logging, was to use Sentry. For now I've chosen not to use this as the impact of this change is hard to determine. Getting this in now will allow us to checkout the impact on dev.gitlab.org and staging. 2018-04-12 03:12:21 -04:00			`ActiveSupport::Deprecation.deprecate_methods(Gitlab::GitalyClient::StorageSettings, :legacy_disk_path, deprecator: deprecator)`
			`end`