2019-03-30 07:23:56 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2012-02-28 13:09:23 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 18:09:03 +00:00
|
|
|
RSpec.describe Event do
|
2012-02-28 14:01:14 +00:00
|
|
|
describe "Associations" do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
it { is_expected.to belong_to(:target) }
|
2012-02-28 14:01:14 +00:00
|
|
|
end
|
|
|
|
|
2012-03-28 19:53:45 +00:00
|
|
|
describe "Respond to" do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to respond_to(:author_name) }
|
|
|
|
it { is_expected.to respond_to(:author_email) }
|
|
|
|
it { is_expected.to respond_to(:issue_title) }
|
|
|
|
it { is_expected.to respond_to(:merge_request_title) }
|
2020-06-01 12:08:28 +00:00
|
|
|
it { is_expected.to respond_to(:design_title) }
|
2012-03-28 19:53:45 +00:00
|
|
|
end
|
|
|
|
|
2016-04-21 07:42:08 +00:00
|
|
|
describe 'Callbacks' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2016-04-21 07:42:08 +00:00
|
|
|
|
2017-05-04 01:44:39 +00:00
|
|
|
describe 'after_create :reset_project_activity' do
|
2016-09-16 14:05:12 +00:00
|
|
|
it 'calls the reset_project_activity method' do
|
2019-11-20 06:06:16 +00:00
|
|
|
expect_next_instance_of(described_class) do |instance|
|
|
|
|
expect(instance).to receive(:reset_project_activity)
|
|
|
|
end
|
2016-04-21 07:42:08 +00:00
|
|
|
|
2017-05-04 01:44:39 +00:00
|
|
|
create_push_event(project, project.owner)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'after_create :set_last_repository_updated_at' do
|
|
|
|
context 'with a push event' do
|
|
|
|
it 'updates the project last_repository_updated_at' do
|
|
|
|
project.update(last_repository_updated_at: 1.year.ago)
|
|
|
|
|
|
|
|
create_push_event(project, project.owner)
|
|
|
|
|
|
|
|
project.reload
|
|
|
|
|
2020-05-22 09:08:09 +00:00
|
|
|
expect(project.last_repository_updated_at).to be_within(1.minute).of(Time.current)
|
2017-05-04 01:44:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without a push event' do
|
|
|
|
it 'does not update the project last_repository_updated_at' do
|
|
|
|
project.update(last_repository_updated_at: 1.year.ago)
|
|
|
|
|
|
|
|
create(:closed_issue_event, project: project, author: project.owner)
|
|
|
|
|
|
|
|
project.reload
|
|
|
|
|
|
|
|
expect(project.last_repository_updated_at).to be_within(1.minute).of(1.year.ago)
|
|
|
|
end
|
2016-04-21 07:42:08 +00:00
|
|
|
end
|
|
|
|
end
|
2018-02-23 19:33:16 +00:00
|
|
|
|
2018-05-28 12:58:23 +00:00
|
|
|
describe '#set_last_repository_updated_at' do
|
|
|
|
it 'only updates once every Event::REPOSITORY_UPDATED_AT_INTERVAL minutes' do
|
|
|
|
last_known_timestamp = (Event::REPOSITORY_UPDATED_AT_INTERVAL - 1.minute).ago
|
|
|
|
project.update(last_repository_updated_at: last_known_timestamp)
|
|
|
|
project.reload # a reload removes fractions of seconds
|
|
|
|
|
|
|
|
expect do
|
|
|
|
create_push_event(project, project.owner)
|
|
|
|
project.reload
|
|
|
|
end.not_to change { project.last_repository_updated_at }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-06-05 15:08:23 +00:00
|
|
|
describe 'after_create UserInteractedProject.track' do
|
2018-02-26 15:44:35 +00:00
|
|
|
let(:event) { build(:push_event, project: project, author: project.owner) }
|
|
|
|
|
2018-03-03 19:00:05 +00:00
|
|
|
it 'passes event to UserInteractedProject.track' do
|
|
|
|
expect(UserInteractedProject).to receive(:track).with(event)
|
2018-02-23 19:33:16 +00:00
|
|
|
event.save
|
|
|
|
end
|
|
|
|
end
|
2016-04-21 07:42:08 +00:00
|
|
|
end
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
describe 'validations' do
|
|
|
|
describe 'action' do
|
|
|
|
context 'for a design' do
|
2020-09-09 21:08:33 +00:00
|
|
|
let_it_be(:author) { create(:user) }
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
where(:action, :valid) do
|
|
|
|
valid = described_class::DESIGN_ACTIONS.map(&:to_s).to_set
|
|
|
|
|
|
|
|
described_class.actions.keys.map do |action|
|
|
|
|
[action, valid.include?(action)]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
2020-09-09 21:08:33 +00:00
|
|
|
let(:event) { build(:design_event, author: author, action: action) }
|
2020-06-01 12:08:28 +00:00
|
|
|
|
|
|
|
specify { expect(event.valid?).to eq(valid) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-05-12 03:09:31 +00:00
|
|
|
describe 'scopes' do
|
|
|
|
describe 'created_at' do
|
|
|
|
it 'can find the right event' do
|
|
|
|
time = 1.day.ago
|
|
|
|
event = create(:event, created_at: time)
|
|
|
|
false_positive = create(:event, created_at: 2.days.ago)
|
|
|
|
|
|
|
|
found = described_class.created_at(time)
|
|
|
|
|
|
|
|
expect(found).to include(event)
|
|
|
|
expect(found).not_to include(false_positive)
|
|
|
|
end
|
2020-07-20 12:09:34 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '.for_fingerprint' do
|
|
|
|
let_it_be(:with_fingerprint) { create(:event, fingerprint: 'aaa') }
|
|
|
|
|
|
|
|
before_all do
|
|
|
|
create(:event)
|
|
|
|
create(:event, fingerprint: 'bbb')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns none if there is no fingerprint' do
|
|
|
|
expect(described_class.for_fingerprint(nil)).to be_empty
|
|
|
|
expect(described_class.for_fingerprint('')).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns none if there is no match' do
|
|
|
|
expect(described_class.for_fingerprint('not-found')).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can find a given event' do
|
|
|
|
expect(described_class.for_fingerprint(with_fingerprint.fingerprint))
|
|
|
|
.to contain_exactly(with_fingerprint)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#fingerprint' do
|
|
|
|
it 'is unique scoped to target' do
|
|
|
|
issue = create(:issue)
|
|
|
|
mr = create(:merge_request)
|
|
|
|
|
|
|
|
expect { create_list(:event, 2, target: issue, fingerprint: '1234') }
|
|
|
|
.to raise_error(include('fingerprint'))
|
|
|
|
|
|
|
|
expect do
|
|
|
|
create(:event, target: mr, fingerprint: 'abcd')
|
|
|
|
create(:event, target: issue, fingerprint: 'abcd')
|
|
|
|
create(:event, target: issue, fingerprint: 'efgh')
|
|
|
|
end.not_to raise_error
|
2020-05-12 03:09:31 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-09-14 22:00:59 +00:00
|
|
|
describe "Push event" do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project, :private) }
|
2016-10-12 06:16:29 +00:00
|
|
|
let(:user) { project.owner }
|
2017-05-04 01:44:39 +00:00
|
|
|
let(:event) { create_push_event(project, user) }
|
2016-10-12 06:16:29 +00:00
|
|
|
|
|
|
|
it do
|
2019-05-13 04:42:06 +00:00
|
|
|
expect(event.push_action?).to be_truthy
|
2016-11-04 14:15:43 +00:00
|
|
|
expect(event.visible_to_user?(user)).to be_truthy
|
|
|
|
expect(event.visible_to_user?(nil)).to be_falsey
|
2016-10-12 06:16:29 +00:00
|
|
|
expect(event.tag?).to be_falsey
|
|
|
|
expect(event.branch_name).to eq("master")
|
|
|
|
expect(event.author).to eq(user)
|
2012-03-28 19:53:45 +00:00
|
|
|
end
|
|
|
|
end
|
2015-11-11 16:14:47 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
describe '#target_title' do
|
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
|
|
|
|
let(:author) { project.owner }
|
|
|
|
let(:target) { nil }
|
|
|
|
|
|
|
|
let(:event) do
|
|
|
|
described_class.new(project: project,
|
|
|
|
target: target,
|
|
|
|
author_id: author.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for an issue' do
|
|
|
|
let(:title) { generate(:title) }
|
|
|
|
let(:issue) { create(:issue, title: title, project: project) }
|
|
|
|
let(:target) { issue }
|
|
|
|
|
|
|
|
it 'delegates to issue title' do
|
|
|
|
expect(event.target_title).to eq(title)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for a wiki page' do
|
|
|
|
let(:title) { generate(:wiki_page_title) }
|
|
|
|
let(:wiki_page) { create(:wiki_page, title: title, project: project) }
|
|
|
|
let(:event) { create(:wiki_page_event, project: project, wiki_page: wiki_page) }
|
|
|
|
|
|
|
|
it 'delegates to wiki page title' do
|
|
|
|
expect(event.target_title).to eq(wiki_page.title)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-10-06 15:19:27 +00:00
|
|
|
describe '#membership_changed?' do
|
|
|
|
context "created" do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { build(:event, :created).membership_changed? }
|
2019-10-18 11:11:44 +00:00
|
|
|
|
2016-10-06 15:19:27 +00:00
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "updated" do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { build(:event, :updated).membership_changed? }
|
2019-10-18 11:11:44 +00:00
|
|
|
|
2016-10-06 15:19:27 +00:00
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "expired" do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { build(:event, :expired).membership_changed? }
|
2019-10-18 11:11:44 +00:00
|
|
|
|
2016-10-06 15:19:27 +00:00
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "left" do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { build(:event, :left).membership_changed? }
|
2019-10-18 11:11:44 +00:00
|
|
|
|
2016-10-06 15:19:27 +00:00
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "joined" do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { build(:event, :joined).membership_changed? }
|
2019-10-18 11:11:44 +00:00
|
|
|
|
2016-10-06 15:19:27 +00:00
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-04 14:29:28 +00:00
|
|
|
describe '#note?' do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { described_class.new(project: target.project, target: target) }
|
2016-07-04 14:29:28 +00:00
|
|
|
|
|
|
|
context 'issue note event' do
|
|
|
|
let(:target) { create(:note_on_issue) }
|
|
|
|
|
|
|
|
it { is_expected.to be_note }
|
|
|
|
end
|
|
|
|
|
2016-07-06 08:08:42 +00:00
|
|
|
context 'merge request diff note event' do
|
2016-07-07 19:57:38 +00:00
|
|
|
let(:target) { create(:legacy_diff_note_on_merge_request) }
|
2016-07-04 14:29:28 +00:00
|
|
|
|
|
|
|
it { is_expected.to be_note }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-24 17:24:22 +00:00
|
|
|
describe '#visible_to_user?' do
|
2020-03-19 12:09:33 +00:00
|
|
|
let_it_be(:non_member) { create(:user) }
|
|
|
|
let_it_be(:member) { create(:user) }
|
|
|
|
let_it_be(:guest) { create(:user) }
|
|
|
|
let_it_be(:author) { create(:author) }
|
|
|
|
let_it_be(:assignee) { create(:user) }
|
|
|
|
let_it_be(:admin) { create(:admin) }
|
|
|
|
let_it_be(:public_project) { create(:project, :public) }
|
|
|
|
let_it_be(:private_project) { create(:project, :private) }
|
|
|
|
|
|
|
|
let(:project) { public_project }
|
2017-05-04 12:11:15 +00:00
|
|
|
let(:issue) { create(:issue, project: project, author: author, assignees: [assignee]) }
|
|
|
|
let(:confidential_issue) { create(:issue, :confidential, project: project, author: author, assignees: [assignee]) }
|
2018-09-21 15:16:13 +00:00
|
|
|
let(:project_snippet) { create(:project_snippet, :public, project: project, author: author) }
|
|
|
|
let(:personal_snippet) { create(:personal_snippet, :public, author: author) }
|
2020-05-07 12:09:46 +00:00
|
|
|
let(:design) { create(:design, issue: issue, project: project) }
|
2016-11-16 14:17:09 +00:00
|
|
|
let(:note_on_commit) { create(:note_on_commit, project: project) }
|
2016-03-24 17:20:47 +00:00
|
|
|
let(:note_on_issue) { create(:note_on_issue, noteable: issue, project: project) }
|
|
|
|
let(:note_on_confidential_issue) { create(:note_on_issue, noteable: confidential_issue, project: project) }
|
2018-09-21 15:16:13 +00:00
|
|
|
let(:note_on_project_snippet) { create(:note_on_project_snippet, author: author, noteable: project_snippet, project: project) }
|
|
|
|
let(:note_on_personal_snippet) { create(:note_on_personal_snippet, author: author, noteable: personal_snippet, project: nil) }
|
2020-05-07 12:09:46 +00:00
|
|
|
let(:note_on_design) { create(:note_on_design, author: author, noteable: design, project: project) }
|
2018-09-21 14:13:15 +00:00
|
|
|
let(:milestone_on_project) { create(:milestone, project: project) }
|
2020-03-19 12:09:33 +00:00
|
|
|
let(:event) do
|
|
|
|
described_class.new(project: project,
|
|
|
|
target: target,
|
|
|
|
author_id: author.id)
|
|
|
|
end
|
2016-03-24 17:20:47 +00:00
|
|
|
|
|
|
|
before do
|
2017-12-22 08:18:28 +00:00
|
|
|
project.add_developer(member)
|
|
|
|
project.add_guest(guest)
|
2016-03-24 17:20:47 +00:00
|
|
|
end
|
2016-03-17 21:03:10 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
def visible_to_all
|
|
|
|
{
|
|
|
|
logged_out: true,
|
|
|
|
non_member: true,
|
|
|
|
guest: true,
|
|
|
|
member: true,
|
|
|
|
admin: true
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
def visible_to_none
|
|
|
|
visible_to_all.transform_values { |_| false }
|
|
|
|
end
|
|
|
|
|
|
|
|
def visible_to_none_except(*roles)
|
|
|
|
visible_to_none.merge(roles.map { |role| [role, true] }.to_h)
|
|
|
|
end
|
|
|
|
|
|
|
|
def visible_to_all_except(*roles)
|
|
|
|
visible_to_all.merge(roles.map { |role| [role, false] }.to_h)
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'visibility examples' do
|
|
|
|
it 'has the correct visibility' do
|
|
|
|
expect({
|
|
|
|
logged_out: event.visible_to_user?(nil),
|
|
|
|
non_member: event.visible_to_user?(non_member),
|
|
|
|
guest: event.visible_to_user?(guest),
|
|
|
|
member: event.visible_to_user?(member),
|
|
|
|
admin: event.visible_to_user?(admin)
|
|
|
|
}).to match(visibility)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'visible to assignee' do |visible|
|
|
|
|
it { expect(event.visible_to_user?(assignee)).to eq(visible) }
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'visible to author' do |visible|
|
|
|
|
it { expect(event.visible_to_user?(author)).to eq(visible) }
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'visible to assignee and author' do |visible|
|
|
|
|
include_examples 'visible to assignee', visible
|
|
|
|
include_examples 'visible to author', visible
|
|
|
|
end
|
|
|
|
|
2016-11-16 14:17:09 +00:00
|
|
|
context 'commit note event' do
|
2020-02-14 00:09:07 +00:00
|
|
|
let(:project) { create(:project, :public, :repository) }
|
2016-11-16 14:17:09 +00:00
|
|
|
let(:target) { note_on_commit }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
2016-11-16 14:17:09 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'private project' do
|
2020-02-14 00:09:07 +00:00
|
|
|
let(:project) { create(:project, :private, :repository) }
|
2016-11-16 14:17:09 +00:00
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member, :admin) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member) }
|
|
|
|
end
|
2016-11-16 14:17:09 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-03-24 17:20:47 +00:00
|
|
|
context 'issue event' do
|
2016-03-17 21:03:10 +00:00
|
|
|
context 'for non confidential issues' do
|
2016-03-24 17:20:47 +00:00
|
|
|
let(:target) { issue }
|
2016-03-17 21:03:10 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
2016-10-12 06:16:29 +00:00
|
|
|
end
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to assignee and author', true
|
2016-03-17 21:03:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'for confidential issues' do
|
2016-03-24 17:20:47 +00:00
|
|
|
let(:target) { confidential_issue }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member, :admin) }
|
2016-10-12 06:16:29 +00:00
|
|
|
end
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to assignee and author', true
|
2016-03-24 17:20:47 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-04 14:29:28 +00:00
|
|
|
context 'issue note event' do
|
2016-03-24 17:20:47 +00:00
|
|
|
context 'on non confidential issues' do
|
|
|
|
let(:target) { note_on_issue }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
2016-10-12 06:16:29 +00:00
|
|
|
end
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to assignee and author', true
|
2016-03-24 17:20:47 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'on confidential issues' do
|
|
|
|
let(:target) { note_on_confidential_issue }
|
2016-03-17 21:03:10 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member, :admin) }
|
2016-10-12 06:16:29 +00:00
|
|
|
end
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to assignee and author', true
|
2016-03-17 21:03:10 +00:00
|
|
|
end
|
2018-12-07 15:48:38 +00:00
|
|
|
|
|
|
|
context 'private project' do
|
2020-03-19 12:09:33 +00:00
|
|
|
let(:project) { private_project }
|
2018-12-07 15:48:38 +00:00
|
|
|
let(:target) { note_on_issue }
|
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:guest, :member, :admin) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:guest, :member) }
|
|
|
|
end
|
2018-12-07 15:48:38 +00:00
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
|
|
|
|
include_examples 'visible to assignee and author', false
|
2018-12-07 15:48:38 +00:00
|
|
|
end
|
2016-03-17 21:03:10 +00:00
|
|
|
end
|
2016-07-04 14:29:28 +00:00
|
|
|
|
2016-07-06 08:08:42 +00:00
|
|
|
context 'merge request diff note event' do
|
2019-04-07 18:35:16 +00:00
|
|
|
let(:merge_request) { create(:merge_request, source_project: project, author: author, assignees: [assignee]) }
|
2016-07-07 19:57:38 +00:00
|
|
|
let(:note_on_merge_request) { create(:legacy_diff_note_on_merge_request, noteable: merge_request, project: project) }
|
2016-07-04 14:29:28 +00:00
|
|
|
let(:target) { note_on_merge_request }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
context 'public project' do
|
|
|
|
let(:project) { public_project }
|
|
|
|
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'visible to assignee', true
|
2016-10-12 06:16:29 +00:00
|
|
|
end
|
2016-10-04 12:52:08 +00:00
|
|
|
|
|
|
|
context 'private project' do
|
2020-03-19 12:09:33 +00:00
|
|
|
let(:project) { private_project }
|
2016-10-04 12:52:08 +00:00
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member, :admin) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member) }
|
|
|
|
end
|
2016-10-12 06:16:29 +00:00
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
|
|
|
|
include_examples 'visible to assignee', false
|
2016-10-04 12:52:08 +00:00
|
|
|
end
|
2016-07-04 14:29:28 +00:00
|
|
|
end
|
2018-09-21 14:13:15 +00:00
|
|
|
|
|
|
|
context 'milestone event' do
|
|
|
|
let(:target) { milestone_on_project }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
2018-09-21 14:13:15 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'on public project with private issue tracker and merge requests' do
|
|
|
|
let(:project) { create(:project, :public, :issues_private, :merge_requests_private) }
|
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all_except(:logged_out, :non_member) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all_except(:logged_out, :non_member, :admin) }
|
|
|
|
end
|
2018-09-21 14:13:15 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on private project' do
|
|
|
|
let(:project) { create(:project, :private) }
|
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all_except(:logged_out, :non_member) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all_except(:logged_out, :non_member, :admin) }
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'wiki-page event', :aggregate_failures do
|
|
|
|
let(:event) { create(:wiki_page_event, project: project) }
|
|
|
|
|
|
|
|
context 'on private project', :aggregate_failures do
|
|
|
|
let(:project) { create(:project, :wiki_repo) }
|
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all_except(:logged_out, :non_member) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all_except(:logged_out, :non_member, :admin) }
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'wiki-page event on public project', :aggregate_failures do
|
|
|
|
let(:project) { create(:project, :public, :wiki_repo) }
|
|
|
|
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
2018-09-21 14:13:15 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-09-21 15:16:13 +00:00
|
|
|
|
|
|
|
context 'project snippet note event' do
|
|
|
|
let(:target) { note_on_project_snippet }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'on public project with private snippets' do
|
|
|
|
let(:project) { create(:project, :public, :snippets_private) }
|
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:guest, :member, :admin) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:guest, :member) }
|
|
|
|
end
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
2020-05-15 15:08:04 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
# Normally, we'd expect the author of a comment to be able to view it.
|
|
|
|
# However, this doesn't seem to be the case for comments on snippets.
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to author', false
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'on private project' do
|
|
|
|
let(:project) { create(:project, :private) }
|
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:guest, :member, :admin) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:guest, :member) }
|
|
|
|
end
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
2020-05-15 15:08:04 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
# Normally, we'd expect the author of a comment to be able to view it.
|
|
|
|
# However, this doesn't seem to be the case for comments on snippets.
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to author', false
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'personal snippet note event' do
|
|
|
|
let(:target) { note_on_personal_snippet }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to author', true
|
2018-09-21 15:16:13 +00:00
|
|
|
|
|
|
|
context 'on internal snippet' do
|
|
|
|
let(:personal_snippet) { create(:personal_snippet, :internal, author: author) }
|
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all_except(:logged_out) }
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'on private snippet' do
|
|
|
|
let(:personal_snippet) { create(:personal_snippet, :private, author: author) }
|
|
|
|
|
2020-05-15 15:08:04 +00:00
|
|
|
context 'when admin mode enabled', :enable_admin_mode do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:admin) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when admin mode disabled' do
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none }
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
end
|
2020-05-15 12:08:28 +00:00
|
|
|
|
2020-03-19 12:09:33 +00:00
|
|
|
include_examples 'visible to author', true
|
|
|
|
end
|
|
|
|
end
|
2020-05-07 12:09:46 +00:00
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
context 'design note event' do
|
2020-05-07 12:09:46 +00:00
|
|
|
include DesignManagementTestHelpers
|
|
|
|
|
|
|
|
let(:target) { note_on_design }
|
|
|
|
|
|
|
|
before do
|
|
|
|
enable_design_management
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'visible to assignee and author', true
|
|
|
|
|
|
|
|
context 'the event refers to a design on a confidential issue' do
|
|
|
|
let(:design) { create(:design, issue: confidential_issue, project: project) }
|
|
|
|
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member, :admin) }
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'visible to assignee and author', true
|
|
|
|
end
|
|
|
|
end
|
2020-06-01 12:08:28 +00:00
|
|
|
|
|
|
|
context 'design event' do
|
|
|
|
include DesignManagementTestHelpers
|
|
|
|
|
|
|
|
let(:target) { design }
|
|
|
|
|
|
|
|
before do
|
|
|
|
enable_design_management
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_all }
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'visible to assignee and author', true
|
|
|
|
|
|
|
|
context 'the event refers to a design on a confidential issue' do
|
|
|
|
let(:design) { create(:design, issue: confidential_issue, project: project) }
|
|
|
|
|
|
|
|
include_examples 'visibility examples' do
|
|
|
|
let(:visibility) { visible_to_none_except(:member, :admin) }
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'visible to assignee and author', true
|
|
|
|
end
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
end
|
|
|
|
|
2020-03-24 12:09:42 +00:00
|
|
|
describe 'wiki_page predicate scopes' do
|
2020-03-19 12:09:33 +00:00
|
|
|
let_it_be(:events) do
|
|
|
|
[
|
2020-03-24 12:09:42 +00:00
|
|
|
create(:push_event),
|
2020-03-19 12:09:33 +00:00
|
|
|
create(:closed_issue_event),
|
|
|
|
create(:wiki_page_event),
|
|
|
|
create(:closed_issue_event),
|
|
|
|
create(:event, :created),
|
2020-06-01 12:08:28 +00:00
|
|
|
create(:design_event, :destroyed),
|
|
|
|
create(:wiki_page_event),
|
|
|
|
create(:design_event)
|
2020-03-19 12:09:33 +00:00
|
|
|
]
|
|
|
|
end
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
describe '.for_design' do
|
|
|
|
it 'only includes design events' do
|
|
|
|
design_events = events.select(&:design?)
|
|
|
|
|
|
|
|
expect(described_class.for_design)
|
|
|
|
.to be_present
|
|
|
|
.and match_array(design_events)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-24 12:09:42 +00:00
|
|
|
describe '.for_wiki_page' do
|
|
|
|
it 'only contains the wiki page events' do
|
|
|
|
wiki_events = events.select(&:wiki_page?)
|
2020-03-19 12:09:33 +00:00
|
|
|
|
2020-03-24 12:09:42 +00:00
|
|
|
expect(events).not_to match_array(wiki_events)
|
|
|
|
expect(described_class.for_wiki_page).to match_array(wiki_events)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-05-12 03:09:31 +00:00
|
|
|
describe '.for_wiki_meta' do
|
|
|
|
it 'finds events for a given wiki page metadata object' do
|
|
|
|
event = events.select(&:wiki_page?).first
|
|
|
|
|
|
|
|
expect(described_class.for_wiki_meta(event.target)).to contain_exactly(event)
|
|
|
|
end
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
end
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
describe 'categorization' do
|
2020-03-19 12:09:33 +00:00
|
|
|
let_it_be(:project) { create(:project, :repository) }
|
2020-06-01 12:08:28 +00:00
|
|
|
let_it_be(:all_valid_events) do
|
|
|
|
# mapping from factory name to whether we need to supply the project
|
|
|
|
valid_target_factories = {
|
|
|
|
issue: true,
|
|
|
|
note_on_issue: true,
|
|
|
|
user: false,
|
|
|
|
merge_request: true,
|
|
|
|
note_on_merge_request: true,
|
|
|
|
project_snippet: true,
|
|
|
|
personal_snippet: false,
|
|
|
|
note_on_project_snippet: true,
|
|
|
|
note_on_personal_snippet: false,
|
|
|
|
wiki_page_meta: true,
|
|
|
|
milestone: true,
|
|
|
|
project: false,
|
|
|
|
design: true,
|
|
|
|
note_on_design: true,
|
|
|
|
note_on_commit: true
|
|
|
|
}
|
|
|
|
valid_target_factories.map do |kind, needs_project|
|
2020-09-04 12:08:27 +00:00
|
|
|
extra_data = if kind == :merge_request
|
|
|
|
{ source_project: project }
|
|
|
|
elsif needs_project
|
|
|
|
{ project: project }
|
|
|
|
else
|
|
|
|
{}
|
|
|
|
end
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
target = kind == :project ? nil : build(kind, **extra_data)
|
2020-09-09 21:08:33 +00:00
|
|
|
|
|
|
|
[kind, build(:event, :created, author: project.owner, project: project, target: target)]
|
2020-06-01 12:08:28 +00:00
|
|
|
end.to_h
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'passes a sanity check', :aggregate_failures do
|
|
|
|
expect(all_valid_events.values).to all(be_valid)
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
describe '#wiki_page and #wiki_page?' do
|
|
|
|
context 'for a wiki page event' do
|
2021-02-15 00:09:04 +00:00
|
|
|
let(:wiki_page) { create(:wiki_page, project: project) }
|
2020-06-01 12:08:28 +00:00
|
|
|
|
|
|
|
subject(:event) { create(:wiki_page_event, project: project, wiki_page: wiki_page) }
|
|
|
|
|
|
|
|
it { is_expected.to have_attributes(wiki_page?: be_truthy, wiki_page: wiki_page) }
|
2021-02-15 00:09:04 +00:00
|
|
|
|
|
|
|
context 'title is empty' do
|
|
|
|
before do
|
|
|
|
expect(event.target).to receive(:canonical_slug).and_return('')
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to have_attributes(wiki_page?: be_truthy, wiki_page: nil) }
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
end
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
context 'for any other event' do
|
|
|
|
it 'has no wiki_page and is not a wiki_page', :aggregate_failures do
|
|
|
|
all_valid_events.each do |k, event|
|
|
|
|
next if k == :wiki_page_meta
|
2020-03-19 12:09:33 +00:00
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
expect(event).to have_attributes(wiki_page: be_nil, wiki_page?: be_falsy)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-03-19 12:09:33 +00:00
|
|
|
end
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
describe '#design and #design?' do
|
|
|
|
context 'for a design event' do
|
|
|
|
let(:design) { build(:design, project: project) }
|
|
|
|
|
|
|
|
subject(:event) { build(:design_event, target: design, project: project) }
|
|
|
|
|
|
|
|
it { is_expected.to have_attributes(design?: be_truthy, design: design) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for any other event' do
|
|
|
|
it 'has no design and is not a design', :aggregate_failures do
|
|
|
|
all_valid_events.each do |k, event|
|
|
|
|
next if k == :design
|
2020-03-19 12:09:33 +00:00
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
expect(event).to have_attributes(design: be_nil, design?: be_falsy)
|
|
|
|
end
|
2018-09-21 15:16:13 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-03-17 21:03:10 +00:00
|
|
|
end
|
|
|
|
|
2015-11-18 11:25:37 +00:00
|
|
|
describe '.limit_recent' do
|
|
|
|
let!(:event1) { create(:closed_issue_event) }
|
|
|
|
let!(:event2) { create(:closed_issue_event) }
|
|
|
|
|
|
|
|
describe 'without an explicit limit' do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { described_class.limit_recent }
|
2015-11-18 11:25:37 +00:00
|
|
|
|
|
|
|
it { is_expected.to eq([event2, event1]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'with an explicit limit' do
|
2017-01-29 22:37:24 +00:00
|
|
|
subject { described_class.limit_recent(1) }
|
2015-11-18 11:25:37 +00:00
|
|
|
|
|
|
|
it { is_expected.to eq([event2]) }
|
|
|
|
end
|
|
|
|
end
|
2016-04-21 07:42:08 +00:00
|
|
|
|
2016-09-16 14:05:12 +00:00
|
|
|
describe '#reset_project_activity' do
|
2017-08-02 19:55:11 +00:00
|
|
|
let(:project) { create(:project) }
|
2016-09-16 14:05:12 +00:00
|
|
|
|
|
|
|
context 'when a project was updated less than 1 hour ago' do
|
|
|
|
it 'does not update the project' do
|
2020-05-22 09:08:09 +00:00
|
|
|
project.update(last_activity_at: Time.current)
|
2016-09-16 14:05:12 +00:00
|
|
|
|
2017-06-21 13:48:12 +00:00
|
|
|
expect(project).not_to receive(:update_column)
|
|
|
|
.with(:last_activity_at, a_kind_of(Time))
|
2016-09-16 14:05:12 +00:00
|
|
|
|
2017-05-04 01:44:39 +00:00
|
|
|
create_push_event(project, project.owner)
|
2016-09-16 14:05:12 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a project was updated more than 1 hour ago' do
|
|
|
|
it 'updates the project' do
|
|
|
|
project.update(last_activity_at: 1.year.ago)
|
|
|
|
|
2017-05-04 01:44:39 +00:00
|
|
|
create_push_event(project, project.owner)
|
2016-09-16 14:05:12 +00:00
|
|
|
|
2016-10-04 15:22:58 +00:00
|
|
|
project.reload
|
2016-09-16 14:05:12 +00:00
|
|
|
|
2020-05-22 09:08:09 +00:00
|
|
|
expect(project.last_activity_at).to be_within(1.minute).of(Time.current)
|
2016-09-16 14:05:12 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-24 10:25:23 +00:00
|
|
|
describe '#authored_by?' do
|
|
|
|
let(:event) { build(:event) }
|
|
|
|
|
|
|
|
it 'returns true when the event author and user are the same' do
|
|
|
|
expect(event.authored_by?(event.author)).to eq(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false when passing nil as an argument' do
|
|
|
|
expect(event.authored_by?(nil)).to eq(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false when the given user is not the author of the event' do
|
|
|
|
user = double(:user, id: -1)
|
|
|
|
|
|
|
|
expect(event.authored_by?(user)).to eq(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-21 15:27:06 +00:00
|
|
|
describe '#body?' do
|
|
|
|
let(:push_event) do
|
|
|
|
event = build(:push_event)
|
|
|
|
|
|
|
|
allow(event).to receive(:push?).and_return(true)
|
|
|
|
|
|
|
|
event
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true for a push event with commits' do
|
|
|
|
allow(push_event).to receive(:push_with_commits?).and_return(true)
|
|
|
|
|
|
|
|
expect(push_event).to be_body
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false for a push event without a valid commit range' do
|
|
|
|
allow(push_event).to receive(:push_with_commits?).and_return(false)
|
|
|
|
|
|
|
|
expect(push_event).not_to be_body
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true for a Note event' do
|
|
|
|
event = build(:event)
|
|
|
|
|
|
|
|
allow(event).to receive(:note?).and_return(true)
|
|
|
|
|
|
|
|
expect(event).to be_body
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true if the target responds to #title' do
|
|
|
|
event = build(:event)
|
|
|
|
|
|
|
|
allow(event).to receive(:target).and_return(double(:target, title: 'foo'))
|
|
|
|
|
|
|
|
expect(event).to be_body
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false for a regular event without a target' do
|
|
|
|
event = build(:event)
|
|
|
|
|
|
|
|
expect(event).not_to be_body
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-01-03 16:44:29 +00:00
|
|
|
describe '#target' do
|
|
|
|
it 'eager loads the author of an event target' do
|
|
|
|
create(:closed_issue_event)
|
|
|
|
|
|
|
|
events = described_class.preload(:target).all.to_a
|
|
|
|
count = ActiveRecord::QueryRecorder
|
|
|
|
.new { events.first.target.author }.count
|
|
|
|
|
|
|
|
# This expectation exists to make sure the test doesn't pass when the
|
|
|
|
# author is for some reason not loaded at all.
|
|
|
|
expect(events.first.target.author).to be_an_instance_of(User)
|
|
|
|
|
|
|
|
expect(count).to be_zero
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-02-12 12:09:02 +00:00
|
|
|
context 'with snippet note' do
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:note_on_project_snippet) { create(:note_on_project_snippet, author: user) }
|
|
|
|
let_it_be(:note_on_personal_snippet) { create(:note_on_personal_snippet, author: user) }
|
|
|
|
let_it_be(:other_note) { create(:note_on_issue, author: user)}
|
|
|
|
let_it_be(:personal_snippet_event) { create(:event, :commented, project: nil, target: note_on_personal_snippet, author: user) }
|
|
|
|
let_it_be(:project_snippet_event) { create(:event, :commented, project: note_on_project_snippet.project, target: note_on_project_snippet, author: user) }
|
|
|
|
let_it_be(:other_event) { create(:event, :commented, project: other_note.project, target: other_note, author: user) }
|
|
|
|
|
|
|
|
describe '#snippet_note?' do
|
|
|
|
it 'returns true for a project snippet event' do
|
|
|
|
expect(project_snippet_event.snippet_note?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true for a personal snippet event' do
|
|
|
|
expect(personal_snippet_event.snippet_note?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false for a other kinds of event' do
|
|
|
|
expect(other_event.snippet_note?).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#personal_snippet_note?' do
|
|
|
|
it 'returns false for a project snippet event' do
|
|
|
|
expect(project_snippet_event.personal_snippet_note?).to be false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true for a personal snippet event' do
|
|
|
|
expect(personal_snippet_event.personal_snippet_note?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false for a other kinds of event' do
|
|
|
|
expect(other_event.personal_snippet_note?).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#project_snippet_note?' do
|
|
|
|
it 'returns true for a project snippet event' do
|
|
|
|
expect(project_snippet_event.project_snippet_note?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false for a personal snippet event' do
|
|
|
|
expect(personal_snippet_event.project_snippet_note?).to be false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false for a other kinds of event' do
|
|
|
|
expect(other_event.project_snippet_note?).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-06-01 12:08:28 +00:00
|
|
|
describe '#action_name' do
|
|
|
|
it 'handles all valid design events' do
|
|
|
|
created, updated, destroyed, archived = %i[created updated destroyed archived].map do |trait|
|
|
|
|
build(:design_event, trait).action_name
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(created).to eq('uploaded')
|
|
|
|
expect(updated).to eq('revised')
|
|
|
|
expect(destroyed).to eq('deleted')
|
|
|
|
expect(archived).to eq('archived')
|
|
|
|
end
|
2020-09-30 12:09:53 +00:00
|
|
|
|
|
|
|
it 'handles correct push_action' do
|
|
|
|
project = create(:project)
|
|
|
|
user = create(:user)
|
|
|
|
project.add_developer(user)
|
|
|
|
push_event = create_push_event(project, user)
|
|
|
|
|
|
|
|
expect(push_event.push_action?).to be true
|
|
|
|
expect(push_event.action_name).to eq('pushed to')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'handles correct base actions' do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
where(:trait, :action_name) do
|
|
|
|
:created | 'created'
|
|
|
|
:updated | 'opened'
|
|
|
|
:closed | 'closed'
|
|
|
|
:reopened | 'opened'
|
|
|
|
:commented | 'commented on'
|
|
|
|
:merged | 'accepted'
|
|
|
|
:joined | 'joined'
|
|
|
|
:left | 'left'
|
|
|
|
:destroyed | 'destroyed'
|
|
|
|
:expired | 'removed due to membership expiration from'
|
|
|
|
:approved | 'approved'
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
it 'with correct name and method' do
|
|
|
|
event = build(:event, trait)
|
|
|
|
|
|
|
|
expect(event.action_name).to eq(action_name)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for created_project_action?' do
|
|
|
|
it 'returns created for created event' do
|
|
|
|
action = build(:project_created_event)
|
|
|
|
|
|
|
|
expect(action.action_name).to eq('created')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns imported for imported event' do
|
|
|
|
action = build(:project_imported_event)
|
|
|
|
|
|
|
|
expect(action.action_name).to eq('imported')
|
|
|
|
end
|
|
|
|
end
|
2020-06-01 12:08:28 +00:00
|
|
|
end
|
|
|
|
|
Migrate events into a new format
This commit migrates events data in such a way that push events are
stored much more efficiently. This is done by creating a shadow table
called "events_for_migration", and a table called "push_event_payloads"
which is used for storing push data of push events. The background
migration in this commit will copy events from the "events" table into
the "events_for_migration" table, push events in will also have a row
created in "push_event_payloads".
This approach allows us to reclaim space in the next release by simply
swapping the "events" and "events_for_migration" tables, then dropping
the old events (now "events_for_migration") table.
The new table structure is also optimised for storage space, and does
not include the unused "title" column nor the "data" column (since this
data is moved to "push_event_payloads").
== Newly Created Events
Newly created events are inserted into both "events" and
"events_for_migration", both using the exact same primary key value. The
table "push_event_payloads" in turn has a foreign key to the _shadow_
table. This removes the need for recreating and validating the foreign
key after swapping the tables. Since the shadow table also has a foreign
key to "projects.id" we also don't have to worry about orphaned rows.
This approach however does require some additional storage as we're
duplicating a portion of the events data for at least 1 release. The
exact amount is hard to estimate, but for GitLab.com this is expected to
be between 10 and 20 GB at most. The background migration in this commit
deliberately does _not_ update the "events" table as doing so would put
a lot of pressure on PostgreSQL's auto vacuuming system.
== Supporting Both Old And New Events
Application code has also been adjusted to support push events using
both the old and new data formats. This is done by creating a PushEvent
class which extends the regular Event class. Using Rails' Single Table
Inheritance system we can ensure the right class is used for the right
data, which in this case is based on the value of `events.action`. To
support displaying old and new data at the same time the PushEvent class
re-defines a few methods of the Event class, falling back to their
original implementations for push events in the old format.
Once all existing events have been migrated the various push event
related methods can be removed from the Event model, and the calls to
`super` can be removed from the methods in the PushEvent model.
The UI and event atom feed have also been slightly changed to better
handle this new setup, fortunately only a few changes were necessary to
make this work.
== API Changes
The API only displays push data of events in the new format. Supporting
both formats in the API is a bit more difficult compared to the UI.
Since the old push data was not really well documented (apart from one
example that used an incorrect "action" nmae) I decided that supporting
both was not worth the effort, especially since events will be migrated
in a few days _and_ new events are created in the correct format.
2017-07-10 15:43:57 +00:00
|
|
|
def create_push_event(project, user)
|
|
|
|
event = create(:push_event, project: project, author: user)
|
|
|
|
|
|
|
|
create(:push_event_payload,
|
|
|
|
event: event,
|
|
|
|
commit_to: '1cf19a015df3523caf0a1f9d40c98a267d6a2fc2',
|
|
|
|
commit_count: 0,
|
|
|
|
ref: 'master')
|
|
|
|
|
|
|
|
event
|
2016-04-21 07:42:08 +00:00
|
|
|
end
|
2012-02-28 13:09:23 +00:00
|
|
|
end
|