2020-07-14 09:09:02 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe Namespace::TraversalHierarchy, type: :model do
|
2021-03-01 15:10:53 +00:00
|
|
|
let_it_be(:root, reload: true) { create(:group, :with_hierarchy) }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
describe '.for_namespace' do
|
2021-03-01 15:10:53 +00:00
|
|
|
let(:hierarchy) { described_class.for_namespace(group) }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
context 'with root group' do
|
2021-03-01 15:10:53 +00:00
|
|
|
let(:group) { root }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
it { expect(hierarchy.root).to eq root }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with child group' do
|
2021-03-01 15:10:53 +00:00
|
|
|
let(:group) { root.children.first.children.first }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
it { expect(hierarchy.root).to eq root }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with group outside of hierarchy' do
|
2021-03-01 15:10:53 +00:00
|
|
|
let(:group) { create(:namespace) }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
it { expect(hierarchy.root).not_to eq root }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.new' do
|
2021-03-01 15:10:53 +00:00
|
|
|
let(:hierarchy) { described_class.new(group) }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
context 'with root group' do
|
2021-03-01 15:10:53 +00:00
|
|
|
let(:group) { root }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
it { expect(hierarchy.root).to eq root }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with child group' do
|
2021-03-01 15:10:53 +00:00
|
|
|
let(:group) { root.children.first }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
it { expect { hierarchy }.to raise_error(StandardError, 'Must specify a root node') }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-03-19 21:08:58 +00:00
|
|
|
shared_examples 'locked update query' do
|
|
|
|
it 'locks query with FOR UPDATE' do
|
|
|
|
qr = ActiveRecord::QueryRecorder.new do
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
expect(qr.count).to eq 1
|
|
|
|
expect(qr.log.first).to match /FOR UPDATE/
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-07-14 09:09:02 +00:00
|
|
|
describe '#incorrect_traversal_ids' do
|
2021-03-19 21:08:58 +00:00
|
|
|
let!(:hierarchy) { described_class.new(root) }
|
|
|
|
|
|
|
|
subject { hierarchy.incorrect_traversal_ids }
|
|
|
|
|
|
|
|
before do
|
|
|
|
Namespace.update_all(traversal_ids: [])
|
|
|
|
end
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
it { is_expected.to match_array Namespace.all }
|
2021-03-19 21:08:58 +00:00
|
|
|
|
|
|
|
context 'when lock is true' do
|
|
|
|
subject { hierarchy.incorrect_traversal_ids(lock: true).load }
|
|
|
|
|
|
|
|
it_behaves_like 'locked update query'
|
|
|
|
end
|
2020-07-14 09:09:02 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#sync_traversal_ids!' do
|
2021-03-19 21:08:58 +00:00
|
|
|
let!(:hierarchy) { described_class.new(root) }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
2021-03-19 21:08:58 +00:00
|
|
|
subject { hierarchy.sync_traversal_ids! }
|
2020-07-14 09:09:02 +00:00
|
|
|
|
|
|
|
it { expect(hierarchy.incorrect_traversal_ids).to be_empty }
|
2021-03-19 21:08:58 +00:00
|
|
|
|
|
|
|
it_behaves_like 'hierarchy with traversal_ids'
|
|
|
|
it_behaves_like 'locked update query'
|
|
|
|
|
|
|
|
context 'when deadlocked' do
|
|
|
|
before do
|
|
|
|
connection_double = double(:connection)
|
|
|
|
|
|
|
|
allow(Namespace).to receive(:connection).and_return(connection_double)
|
2021-05-04 15:10:36 +00:00
|
|
|
allow(connection_double).to receive(:exec_query) { raise ActiveRecord::Deadlocked }
|
2021-03-19 21:08:58 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it { expect { subject }.to raise_error(ActiveRecord::Deadlocked) }
|
|
|
|
|
|
|
|
it 'increment db_deadlock counter' do
|
|
|
|
expect { subject rescue nil }.to change { db_deadlock_total('Namespace#sync_traversal_ids!') }.by(1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def db_deadlock_total(source)
|
|
|
|
Gitlab::Metrics
|
|
|
|
.counter(:db_deadlock, 'Counts the times we have deadlocked in the database')
|
|
|
|
.get(source: source)
|
2020-07-14 09:09:02 +00:00
|
|
|
end
|
|
|
|
end
|