Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Groups::MilestonesController do
|
|
|
|
let(:group) { create(:group) }
|
2017-01-25 21:44:33 +00:00
|
|
|
let(:project) { create(:empty_project, group: group) }
|
Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
let(:project2) { create(:empty_project, group: group) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:title) { '肯定不是中文的问题' }
|
2017-04-26 10:32:21 +00:00
|
|
|
let(:milestone) do
|
|
|
|
project_milestone = create(:milestone, project: project)
|
|
|
|
|
|
|
|
GroupMilestone.build(
|
|
|
|
group,
|
|
|
|
[project],
|
|
|
|
project_milestone.title
|
|
|
|
)
|
|
|
|
end
|
|
|
|
let(:milestone_path) { group_milestone_path(group, milestone.safe_title, title: milestone.title) }
|
Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
group.add_owner(user)
|
|
|
|
project.team << [user, :master]
|
|
|
|
end
|
|
|
|
|
2017-04-26 10:32:21 +00:00
|
|
|
it_behaves_like 'milestone tabs'
|
|
|
|
|
Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
describe "#create" do
|
2016-07-25 18:16:19 +00:00
|
|
|
it "creates group milestone with Chinese title" do
|
Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
post :create,
|
2017-05-18 23:23:05 +00:00
|
|
|
group_id: group.to_param,
|
Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
milestone: { project_ids: [project.id, project2.id], title: title }
|
|
|
|
|
|
|
|
expect(response).to redirect_to(group_milestone_path(group, title.to_slug.to_s, title: title))
|
|
|
|
expect(Milestone.where(title: title).count).to eq(2)
|
|
|
|
end
|
2016-03-31 19:11:49 +00:00
|
|
|
|
|
|
|
it "redirects to new when there are no project ids" do
|
2017-05-18 23:23:05 +00:00
|
|
|
post :create, group_id: group.to_param, milestone: { title: title, project_ids: [""] }
|
2016-03-31 19:11:49 +00:00
|
|
|
expect(response).to render_template :new
|
2016-04-05 14:51:19 +00:00
|
|
|
expect(assigns(:milestone).errors).not_to be_nil
|
2016-03-31 19:11:49 +00:00
|
|
|
end
|
Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
end
|
2017-05-18 23:23:05 +00:00
|
|
|
|
|
|
|
describe '#ensure_canonical_path' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for a GET request' do
|
|
|
|
context 'when requesting the canonical path' do
|
|
|
|
context 'non-show path' do
|
|
|
|
context 'with exactly matching casing' do
|
|
|
|
it 'does not redirect' do
|
|
|
|
get :index, group_id: group.to_param
|
|
|
|
|
|
|
|
expect(response).not_to have_http_status(301)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with different casing' do
|
|
|
|
it 'redirects to the correct casing' do
|
|
|
|
get :index, group_id: group.to_param.upcase
|
|
|
|
|
|
|
|
expect(response).to redirect_to(group_milestones_path(group.to_param))
|
|
|
|
expect(controller).not_to set_flash[:notice]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'show path' do
|
|
|
|
context 'with exactly matching casing' do
|
|
|
|
it 'does not redirect' do
|
|
|
|
get :show, group_id: group.to_param, id: title
|
|
|
|
|
|
|
|
expect(response).not_to have_http_status(301)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with different casing' do
|
|
|
|
it 'redirects to the correct casing' do
|
|
|
|
get :show, group_id: group.to_param.upcase, id: title
|
|
|
|
|
|
|
|
expect(response).to redirect_to(group_milestone_path(group.to_param, title))
|
|
|
|
expect(controller).not_to set_flash[:notice]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when requesting a redirected path' do
|
|
|
|
let(:redirect_route) { group.redirect_routes.create(path: 'old-path') }
|
|
|
|
|
|
|
|
it 'redirects to the canonical path' do
|
|
|
|
get :merge_requests, group_id: redirect_route.path, id: title
|
|
|
|
|
|
|
|
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
|
|
|
|
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the old group path is a substring of the scheme or host' do
|
|
|
|
let(:redirect_route) { group.redirect_routes.create(path: 'http') }
|
|
|
|
|
|
|
|
it 'does not modify the requested host' do
|
|
|
|
get :merge_requests, group_id: redirect_route.path, id: title
|
|
|
|
|
|
|
|
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
|
|
|
|
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the old group path is substring of groups' do
|
|
|
|
# I.e. /groups/oups should not become /grfoo/oups
|
|
|
|
let(:redirect_route) { group.redirect_routes.create(path: 'oups') }
|
|
|
|
|
|
|
|
it 'does not modify the /groups part of the path' do
|
|
|
|
get :merge_requests, group_id: redirect_route.path, id: title
|
|
|
|
|
|
|
|
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
|
|
|
|
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the old group path is substring of groups plus the new path' do
|
|
|
|
# I.e. /groups/oups/oup should not become /grfoos
|
|
|
|
let(:redirect_route) { group.redirect_routes.create(path: 'oups/oup') }
|
|
|
|
|
|
|
|
it 'does not modify the /groups part of the path' do
|
|
|
|
get :merge_requests, group_id: redirect_route.path, id: title
|
|
|
|
|
|
|
|
expect(response).to redirect_to(merge_requests_group_milestone_path(group.to_param, title))
|
|
|
|
expect(controller).to set_flash[:notice].to(group_moved_message(redirect_route, group))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for a non-GET request' do
|
|
|
|
context 'when requesting the canonical path with different casing' do
|
|
|
|
it 'does not 404' do
|
|
|
|
post :create,
|
|
|
|
group_id: group.to_param,
|
|
|
|
milestone: { project_ids: [project.id, project2.id], title: title }
|
|
|
|
|
|
|
|
expect(response).not_to have_http_status(404)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not redirect to the correct casing' do
|
|
|
|
post :create,
|
|
|
|
group_id: group.to_param,
|
|
|
|
milestone: { project_ids: [project.id, project2.id], title: title }
|
|
|
|
|
|
|
|
expect(response).not_to have_http_status(301)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when requesting a redirected path' do
|
|
|
|
let(:redirect_route) { group.redirect_routes.create(path: 'old-path') }
|
|
|
|
|
|
|
|
it 'returns not found' do
|
|
|
|
post :create,
|
|
|
|
group_id: redirect_route.path,
|
|
|
|
milestone: { project_ids: [project.id, project2.id], title: title }
|
|
|
|
|
|
|
|
expect(response).to have_http_status(404)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def group_moved_message(redirect_route, group)
|
|
|
|
"Group '#{redirect_route.path}' was moved to '#{group.full_path}'. Please update any links and bookmarks that may still have the old path."
|
|
|
|
end
|
Fix Error 500 when creating global milestones with Unicode characters
Two issues:
1. The constraints in the resources were incorrect. Here's what it was before:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
In this case, id is actually the title of the milestone, which can be anything at the moment.
After:
```
group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/}
```
2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like:
ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]):
This change uses the babosa library to create a better slug, which surprisingly
isn't actually used by the global milestone controllers. Instead, they use the
title passed as a query string for some reason.
Closes https://github.com/gitlabhq/gitlabhq/issues/9881
Fix constraints
2015-12-04 07:33:52 +00:00
|
|
|
end
|