gitlab-org--gitlab-foss/spec/services/notification_service_spec.rb

483 lines
16 KiB
Ruby
Raw Normal View History

require 'spec_helper'
2015-12-09 05:55:49 -05:00
describe NotificationService, services: true do
let(:notification) { NotificationService.new }
2013-08-08 10:42:27 -04:00
2015-11-30 04:21:10 -05:00
around(:each) do |example|
perform_enqueued_jobs do
example.run
end
end
describe 'Keys' do
describe :new_key do
let!(:key) { create(:personal_key) }
it { expect(notification.new_key(key)).to be_truthy }
it 'should sent email to key owner' do
2015-11-30 04:21:10 -05:00
expect{ notification.new_key(key) }.to change{ ActionMailer::Base.deliveries.size }.by(1)
end
end
end
describe 'Email' do
describe :new_email do
let!(:email) { create(:email) }
it { expect(notification.new_email(email)).to be_truthy }
it 'should send email to email owner' do
2015-11-30 04:21:10 -05:00
expect{ notification.new_email(email) }.to change{ ActionMailer::Base.deliveries.size }.by(1)
end
end
end
2013-03-28 08:39:59 -04:00
describe 'Notes' do
context 'issue note' do
let(:project) { create(:empty_project, :private) }
2015-05-15 09:38:05 -04:00
let(:issue) { create(:issue, project: project, assignee: create(:user)) }
let(:mentioned_issue) { create(:issue, assignee: issue.assignee) }
let(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@mention referenced, @outsider also') }
2013-03-28 08:39:59 -04:00
before do
build_team(note.project)
project.team << [issue.author, :master]
project.team << [issue.assignee, :master]
project.team << [note.author, :master]
create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@subscribed_participant cc this guy')
2013-03-28 08:39:59 -04:00
end
describe :new_note do
it do
2015-03-16 11:20:17 -04:00
add_users_with_subscription(note.project, issue)
# Ensure create SentNotification by noteable = issue 6 times, not noteable = note
2016-01-05 12:17:55 -05:00
expect(SentNotification).to receive(:record).with(issue, any_args).exactly(7).times
2015-11-30 04:21:10 -05:00
ActionMailer::Base.deliveries.clear
2015-03-16 11:20:17 -04:00
notification.new_note(note)
2015-11-30 04:21:10 -05:00
should_email(@u_watcher)
should_email(note.noteable.author)
should_email(note.noteable.assignee)
should_email(@u_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
should_email(@subscribed_participant)
2015-11-30 04:21:10 -05:00
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@unsubscriber)
should_not_email(@u_outsider_mentioned)
end
it 'filters out "mentioned in" notes' do
mentioned_note = SystemNoteService.cross_reference(mentioned_issue, issue, issue.author)
expect(Notify).not_to receive(:note_issue_email)
notification.new_note(mentioned_note)
end
2014-03-28 12:15:58 -04:00
end
describe 'new note on issue in project that belongs to a group' do
let(:group) { create(:group) }
2014-03-28 12:15:58 -04:00
before do
note.project.namespace_id = group.id
note.project.group.add_user(@u_watcher, GroupMember::MASTER)
2014-03-28 12:15:58 -04:00
note.project.save
user_project = note.project.project_members.find_by_user_id(@u_watcher.id)
2014-03-28 12:15:58 -04:00
user_project.notification_level = Notification::N_PARTICIPATING
user_project.save
group_member = note.project.group.group_members.find_by_user_id(@u_watcher.id)
group_member.notification_level = Notification::N_GLOBAL
group_member.save
2015-11-30 04:21:10 -05:00
ActionMailer::Base.deliveries.clear
end
2014-03-28 12:15:58 -04:00
it do
notification.new_note(note)
2015-11-30 04:21:10 -05:00
should_email(note.noteable.author)
should_email(note.noteable.assignee)
should_email(@u_mentioned)
should_not_email(@u_watcher)
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
2014-03-28 12:15:58 -04:00
end
end
2013-03-28 08:39:59 -04:00
2014-06-23 08:02:09 -04:00
context 'issue note mention' do
2015-05-15 09:38:05 -04:00
let(:project) { create(:empty_project, :public) }
let(:issue) { create(:issue, project: project, assignee: create(:user)) }
2014-06-23 08:02:09 -04:00
let(:mentioned_issue) { create(:issue, assignee: issue.assignee) }
let(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@all mentioned') }
before do
build_team(note.project)
2015-12-24 14:34:13 -05:00
note.project.team << [note.author, :master]
2015-11-30 04:21:10 -05:00
ActionMailer::Base.deliveries.clear
2014-06-23 08:02:09 -04:00
end
describe :new_note do
it do
2015-11-30 04:21:10 -05:00
notification.new_note(note)
2014-06-23 08:02:09 -04:00
# Notify all team members
note.project.team.members.each do |member|
# User with disabled notification should not be notified
next if member.id == @u_disabled.id
2015-12-25 07:20:20 -05:00
# Author should not be notified
next if member.id == note.author.id
2015-11-30 04:21:10 -05:00
should_email(member)
2014-06-23 08:02:09 -04:00
end
2015-11-30 04:21:10 -05:00
should_email(note.noteable.author)
should_email(note.noteable.assignee)
should_not_email(note.author)
should_email(@u_mentioned)
should_not_email(@u_disabled)
should_email(@u_not_mentioned)
2014-06-23 08:02:09 -04:00
end
it 'filters out "mentioned in" notes' do
mentioned_note = SystemNoteService.cross_reference(mentioned_issue, issue, issue.author)
2014-06-23 08:02:09 -04:00
expect(Notify).not_to receive(:note_issue_email)
2014-06-23 08:02:09 -04:00
notification.new_note(mentioned_note)
end
end
end
context 'commit note' do
2015-05-15 09:38:05 -04:00
let(:project) { create(:project, :public) }
let(:note) { create(:note_on_commit, project: project) }
before do
build_team(note.project)
2015-11-30 04:21:10 -05:00
ActionMailer::Base.deliveries.clear
2015-04-15 15:09:14 -04:00
allow_any_instance_of(Commit).to receive(:author).and_return(@u_committer)
2013-03-28 08:39:59 -04:00
end
2015-11-30 04:21:10 -05:00
describe :new_note, :perform_enqueued_jobs do
it do
notification.new_note(note)
2015-11-30 04:21:10 -05:00
should_email(@u_committer)
should_email(@u_watcher)
should_not_email(@u_mentioned)
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
it do
note.update_attribute(:note, '@mention referenced')
notification.new_note(note)
2015-11-30 04:21:10 -05:00
should_email(@u_committer)
should_email(@u_watcher)
should_email(@u_mentioned)
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
it do
@u_committer.update_attributes(notification_level: Notification::N_MENTION)
notification.new_note(note)
2015-11-30 04:21:10 -05:00
should_not_email(@u_committer)
end
2013-03-28 08:39:59 -04:00
end
end
end
describe 'Issues' do
2015-05-15 09:38:05 -04:00
let(:project) { create(:empty_project, :public) }
let(:issue) { create :issue, project: project, assignee: create(:user), description: 'cc @participant' }
before do
build_team(issue.project)
2015-03-16 11:20:17 -04:00
add_users_with_subscription(issue.project, issue)
2015-11-30 04:21:10 -05:00
ActionMailer::Base.deliveries.clear
end
describe :new_issue do
2013-03-28 06:24:04 -04:00
it do
notification.new_issue(issue, @u_disabled)
2015-11-30 04:21:10 -05:00
should_email(issue.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_not_email(@u_mentioned)
should_not_email(@u_participating)
should_not_email(@u_disabled)
2013-03-28 06:24:04 -04:00
end
it do
issue.assignee.update_attributes(notification_level: Notification::N_MENTION)
notification.new_issue(issue, @u_disabled)
2013-03-28 06:24:04 -04:00
2015-11-30 04:21:10 -05:00
should_not_email(issue.assignee)
end
end
describe :reassigned_issue do
it 'emails new assignee' do
notification.reassigned_issue(issue, @u_disabled)
should_email(issue.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
it 'emails previous assignee even if he has the "on mention" notif level' do
issue.update_attribute(:assignee, @u_mentioned)
issue.update_attributes(assignee: @u_watcher)
notification.reassigned_issue(issue, @u_disabled)
should_email(@u_mentioned)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
it 'emails new assignee even if he has the "on mention" notif level' do
issue.update_attributes(assignee: @u_mentioned)
notification.reassigned_issue(issue, @u_disabled)
expect(issue.assignee).to be @u_mentioned
should_email(issue.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
it 'emails new assignee' do
issue.update_attribute(:assignee, @u_mentioned)
notification.reassigned_issue(issue, @u_disabled)
expect(issue.assignee).to be @u_mentioned
2015-11-30 04:21:10 -05:00
should_email(issue.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
it 'does not email new assignee if they are the current user' do
issue.update_attribute(:assignee, @u_mentioned)
notification.reassigned_issue(issue, @u_mentioned)
expect(issue.assignee).to be @u_mentioned
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_not_email(issue.assignee)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
end
describe :close_issue do
it 'should sent email to issue assignee and issue author' do
notification.close_issue(issue, @u_disabled)
2015-11-30 04:21:10 -05:00
should_email(issue.assignee)
should_email(issue.author)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-11-30 04:21:10 -05:00
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
end
2014-07-03 08:05:07 -04:00
describe :reopen_issue do
it 'should send email to issue assignee and issue author' do
notification.reopen_issue(issue, @u_disabled)
2015-11-30 04:21:10 -05:00
should_email(issue.assignee)
should_email(issue.author)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-11-30 04:21:10 -05:00
should_not_email(@unsubscriber)
should_not_email(@u_participating)
2014-07-03 08:05:07 -04:00
end
end
end
describe 'Merge Requests' do
2015-05-15 09:38:05 -04:00
let(:project) { create(:project, :public) }
let(:merge_request) { create :merge_request, source_project: project, assignee: create(:user), description: 'cc @participant' }
before do
Merge Request on forked projects The good: - You can do a merge request for a forked commit and it will merge properly (i.e. it does work). - Push events take into account merge requests on forked projects - Tests around merge_actions now present, spinach, and other rspec tests - Satellites now clean themselves up rather then recreate The questionable: - Events only know about target projects - Project's merge requests only hold on to MR's where they are the target - All operations performed in the satellite The bad: - Duplication between project's repositories and satellites (e.g. commits_between) (for reference: http://feedback.gitlab.com/forums/176466-general/suggestions/3456722-merge-requests-between-projects-repos) Fixes: Make test repos/satellites only create when needed -Spinach/Rspec now only initialize test directory, and setup stubs (things that are relatively cheap) -project_with_code, source_project_with_code, and target_project_with_code now create/destroy their repos individually -fixed remote removal -How to merge renders properly -Update emails to show project/branches -Edit MR doesn't set target branch -Fix some failures on editing/creating merge requests, added a test -Added back a test around merge request observer -Clean up project_transfer_spec, Remove duplicate enable/disable observers -Ensure satellite lock files are cleaned up, Attempted to add some testing around these as well -Signifant speed ups for tests -Update formatting ordering in notes_on_merge_requests -Remove wiki schema update Fixes for search/search results -Search results was using by_project for a list of projects, updated this to use in_projects -updated search results to reference the correct (target) project -udpated search results to print both sides of the merge request Change-Id: I19407990a0950945cc95d62089cbcc6262dab1a8
2013-04-25 10:15:33 -04:00
build_team(merge_request.target_project)
2015-03-16 11:20:17 -04:00
add_users_with_subscription(merge_request.target_project, merge_request)
2015-11-30 04:21:10 -05:00
ActionMailer::Base.deliveries.clear
end
describe :new_merge_request do
it do
notification.new_merge_request(merge_request, @u_disabled)
2015-11-30 04:21:10 -05:00
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@watcher_and_subscriber)
2015-11-30 04:21:10 -05:00
should_email(@u_participant_mentioned)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
end
describe :reassigned_merge_request do
it do
notification.reassigned_merge_request(merge_request, merge_request.author)
2015-11-30 04:21:10 -05:00
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-11-30 04:21:10 -05:00
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
end
describe :closed_merge_request do
it do
notification.close_mr(merge_request, @u_disabled)
2015-11-30 04:21:10 -05:00
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-11-30 04:21:10 -05:00
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
end
describe :merged_merge_request do
it do
notification.merge_mr(merge_request, @u_disabled)
2015-11-30 04:21:10 -05:00
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-11-30 04:21:10 -05:00
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
end
end
2014-07-03 08:05:07 -04:00
describe :reopen_merge_request do
it do
notification.reopen_mr(merge_request, @u_disabled)
2015-11-30 04:21:10 -05:00
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-11-30 04:21:10 -05:00
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
2014-07-03 08:05:07 -04:00
end
end
end
describe 'Projects' do
let(:project) { create :project }
before do
build_team(project)
2015-11-30 04:21:10 -05:00
ActionMailer::Base.deliveries.clear
end
describe :project_was_moved do
it do
notification.project_was_moved(project, "gitlab/gitlab")
2015-11-30 04:21:10 -05:00
should_email(@u_watcher)
should_email(@u_participating)
should_not_email(@u_disabled)
end
end
end
def build_team(project)
2013-08-08 10:42:27 -04:00
@u_watcher = create(:user, notification_level: Notification::N_WATCH)
@u_participating = create(:user, notification_level: Notification::N_PARTICIPATING)
@u_participant_mentioned = create(:user, username: 'participant', notification_level: Notification::N_PARTICIPATING)
2013-08-08 10:42:27 -04:00
@u_disabled = create(:user, notification_level: Notification::N_DISABLED)
@u_mentioned = create(:user, username: 'mention', notification_level: Notification::N_MENTION)
@u_committer = create(:user, username: 'committer')
2014-06-23 08:02:09 -04:00
@u_not_mentioned = create(:user, username: 'regular', notification_level: Notification::N_PARTICIPATING)
@u_outsider_mentioned = create(:user, username: 'outsider')
project.team << [@u_watcher, :master]
project.team << [@u_participating, :master]
project.team << [@u_participant_mentioned, :master]
project.team << [@u_disabled, :master]
project.team << [@u_mentioned, :master]
project.team << [@u_committer, :master]
project.team << [@u_not_mentioned, :master]
end
2015-03-16 11:20:17 -04:00
def add_users_with_subscription(project, issuable)
@subscriber = create :user
@unsubscriber = create :user
@subscribed_participant = create(:user, username: 'subscribed_participant', notification_level: Notification::N_PARTICIPATING)
@watcher_and_subscriber = create(:user, notification_level: Notification::N_WATCH)
2015-03-16 11:20:17 -04:00
project.team << [@subscribed_participant, :master]
2015-03-16 11:20:17 -04:00
project.team << [@subscriber, :master]
project.team << [@unsubscriber, :master]
project.team << [@watcher_and_subscriber, :master]
2015-03-16 11:20:17 -04:00
issuable.subscriptions.create(user: @subscriber, subscribed: true)
issuable.subscriptions.create(user: @subscribed_participant, subscribed: true)
2015-03-16 11:20:17 -04:00
issuable.subscriptions.create(user: @unsubscriber, subscribed: false)
# Make the watcher a subscriber to detect dupes
issuable.subscriptions.create(user: @watcher_and_subscriber, subscribed: true)
2015-03-16 11:20:17 -04:00
end
2015-11-30 04:21:10 -05:00
def sent_to_user?(user)
ActionMailer::Base.deliveries.map(&:to).flatten.count(user.email) == 1
2015-11-30 04:21:10 -05:00
end
def should_email(user)
expect(sent_to_user?(user)).to be_truthy
end
def should_not_email(user)
expect(sent_to_user?(user)).to be_falsey
end
end