kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/rubocop/rubocop.rb

50 lines
2.4 KiB
Ruby
Raw Normal View History

Move ModuleWithInstanceVariables to Gitlab namespace And use .rubocop.yml to exclude paths we don't care, rather than using the cop itself to exclude.
2017-11-22 02:50:36 -05:00
require_relative 'cop/gitlab/module_with_instance_variables'
Introduce PredicateMemoization cop and fix offenses with StrongMemoize
2018-01-09 12:30:04 -05:00
require_relative 'cop/gitlab/predicate_memoization'
Revert the addition of goldiloader This reverts the addition of the "goldiloader" Gem and all use of it. While this Gem is very promising it's causing a variety of problems on GitLab.com due to it eager-loading too much data in places where we don't expect/can handle this. At least for the time being this means we have to go back to manually fixing N+1 query problems, but at least those should not cause a negative impact on availability.
2018-04-18 09:41:42 -04:00
require_relative 'cop/gitlab/httparty'
Add a cop for `FinderMethods` This notifies developers when calling `find(_by!)` chained on `execute`. And suggests using the methods from `FinderMethods`. These will perform the correct authorization checks on the resource when it is found.
2018-06-18 04:31:41 -04:00
require_relative 'cop/gitlab/finder_with_find_by'
Added FromUnion to easily select from a UNION This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
2018-09-11 11:31:34 -04:00
require_relative 'cop/gitlab/union'
Add a rubocop for Rails.logger Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
2019-07-10 15:26:47 -04:00
require_relative 'cop/gitlab/rails_logger'
Add Rubocop rule to ban include ActionView::Context
2019-04-28 02:38:05 -04:00
require_relative 'cop/include_action_view_context'
Use gitlab-styles Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-09-19 11:25:42 -04:00
require_relative 'cop/include_sidekiq_worker'
Add cop prohibiting params argument in url_for
2018-11-15 04:50:04 -05:00
require_relative 'cop/safe_params'
Forbid the use of `#reload` and prefer `#reset` The `#reload` makes to load all objects into memory, and the main purpose of `#reload` is to drop the association cache. The `#reset` seems to solve exactly that case.
2019-04-08 09:33:36 -04:00
require_relative 'cop/active_record_association_reload'
Resolve "Make a Rubocop that forbids returning from a block"
2018-04-18 05:19:40 -04:00
require_relative 'cop/avoid_return_from_blocks'
require_relative 'cop/avoid_break_from_strong_memoize'
Fix leading slash in redirects and add cop
2018-09-21 10:10:20 -04:00
require_relative 'cop/avoid_route_redirect_leading_slash'
Adds Rubocop rule for line break around conditionals
2018-01-11 11:34:01 -05:00
require_relative 'cop/line_break_around_conditional_block'
Adds Rubocop rule to enforce class_methods over module ClassMethods
2018-08-24 18:08:34 -04:00
require_relative 'cop/prefer_class_methods_over_module'
Add cop that checks if add_column_with_default is used with up/down methods
2017-02-08 17:17:15 -05:00
require_relative 'cop/migration/add_column'
Enforce use of add_concurrent_foreign_key This adds a Rubocop rule to enforce the use of add_concurrent_foreign_key instead of the regular add_foreign_key method. This cop has been disabled for existing migrations so we don't need to change those.
2017-02-09 10:52:43 -05:00
require_relative 'cop/migration/add_concurrent_foreign_key'
Add cop to ensure reversibility of add_concurrent_index
2017-03-07 11:08:53 -05:00
require_relative 'cop/migration/add_concurrent_index'
Add a spec for our custom GemFetcher cop
2017-02-08 16:22:36 -05:00
require_relative 'cop/migration/add_index'
Adds cop to enforce string limits on migrations This cop will analyze migrations that add columns with string, and report an offense if the string has no limit enforced Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505
2019-08-23 17:36:12 -04:00
require_relative 'cop/migration/add_limit_to_string_columns'
Add rubocop check for add_reference to require index.
2018-08-01 11:52:54 -04:00
require_relative 'cop/migration/add_reference'
Add database helpers 'add_timestamps_with_timezone' and 'timestamps_with_timezone'
2017-06-13 07:44:13 -04:00
require_relative 'cop/migration/add_timestamps'
require_relative 'cop/migration/datetime'
Added cop to blacklist the use of hash indexes These indexes are not recorded in the WAL (at least until PostgreSQL 10) and this isn't worth the minor performance improvement over btree indexes.
2017-07-14 07:19:00 -04:00
require_relative 'cop/migration/hash_index'
Add cop for use of remove_column remove_column should only be used in the up (or change) step of a migration if it's a post-deployment migration. Otherwise there will be downtime due to the ActiveRecord column cache, which we can avoid by using the IgnorableColumn concern in combination with a post-deployment migration.
2017-12-11 11:34:51 -05:00
require_relative 'cop/migration/remove_column'
Add remove_concurrent_index to database helper
2017-04-05 18:53:57 -04:00
require_relative 'cop/migration/remove_concurrent_index'
require_relative 'cop/migration/remove_index'
Rename AddColumnWithDefault to ReversibleAddColumnWithDefault We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them.
2017-04-24 13:16:33 -04:00
require_relative 'cop/migration/reversible_add_column_with_default'
Add a new RSpec::EnvAssignment cop to prevent assigning to ENV in specs Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-11 07:25:40 -04:00
require_relative 'cop/migration/safer_boolean_column'
Add database helpers 'add_timestamps_with_timezone' and 'timestamps_with_timezone'
2017-06-13 07:44:13 -04:00
require_relative 'cop/migration/timestamps'
New Migration/UpdateColumnInBatches cop Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-22 12:31:22 -04:00
require_relative 'cop/migration/update_column_in_batches'
Prevent update_column_in_batches on large tables add_column_with_default is implemented in terms of update_column_in_batches, but update_column_in_batches can be used independently. Neither of these should be used on the specified large tables, because they will cause issues on large instances like GitLab.com. This also ignores the cop for all existing migrations, renaming AddColumnWithDefaultToLargeTable where appropriate.
2017-11-17 08:38:14 -05:00
require_relative 'cop/migration/update_large_table'
Use gitlab-styles Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-09-19 11:25:42 -04:00
require_relative 'cop/project_path_helper'
Add a new RSpec::EnvAssignment cop to prevent assigning to ENV in specs Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-11 07:25:40 -04:00
require_relative 'cop/rspec/env_assignment'
Introduce a new FactoriesInMigrationSpecs cop Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-03-30 11:18:12 -04:00
require_relative 'cop/rspec/factories_in_migration_specs'
Add RSpec/TopLevelDescribePath cop The RSpec/FilePath cop checks that a spec file's path is correct, but only if the file describes a constant. We want to check, for any file with a top-level `describe`, whether the file path ends in `_spec.rb`. We don't care what comes before that; just that it will be executed by RSpec at all.
2019-07-29 11:27:36 -04:00
require_relative 'cop/rspec/top_level_describe_path'
Add a new QA::ElementWithPattern cop This cop forbids the use of `element :foo, 'pattern'` and `element :bar, /pattern/` in QA files. Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-10-11 13:10:42 -04:00
require_relative 'cop/qa/element_with_pattern'
Use gitlab-styles Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-09-19 11:25:42 -04:00
require_relative 'cop/sidekiq_options_queue'
Blacklist the use of "destroy_all" This method usually has really bad performance implications, as it loads rows into memory and deletes them one by one.
2018-08-16 08:28:25 -04:00
require_relative 'cop/destroy_all'
Reject ruby interpolation in externalized strings When using ruby interpolation in externalized strings, they can't be detected. Which means they will never be presented to be translated. To mix variables into translations we need to use `sprintf` instead. Instead of: _("Hello #{subject}") Use: _("Hello %{subject}) % { subject: 'world' }
2018-08-16 08:15:54 -04:00
require_relative 'cop/ruby_interpolation_in_translation'
Added RuboCop cops to enforce code reuse rules These Cops enforces the code reuse rules as defined in merge request https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21254.
2018-08-27 11:30:20 -04:00
require_relative 'code_reuse_helpers'
require_relative 'cop/code_reuse/finder'
require_relative 'cop/code_reuse/service_class'
require_relative 'cop/code_reuse/presenter'
require_relative 'cop/code_reuse/serializer'
require_relative 'cop/code_reuse/active_record'
Applies the CE backport of EE#657
2018-09-07 08:29:19 -04:00
require_relative 'cop/group_public_or_visible_to_user'
Added Cop for injecting EE modules This Cop enforces the rule that injecting EE modules (using prepend, include, or extend) is done by placing the injection on the last line of a file, instead of somewhere in the middle. By placing these lines at the very end, merge conflicts will not happen.
2018-12-13 09:46:01 -05:00
require_relative 'cop/inject_enterprise_edition_module'
Add a cop to ensure we authorize GraphQL types
2019-06-18 10:18:26 -04:00
require_relative 'cop/graphql/authorize_types'
Copy permalink