2015-10-06 10:01:16 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-02-14 14:48:16 +00:00
|
|
|
describe CommitStatus, :models do
|
2017-01-26 22:44:58 +00:00
|
|
|
let(:project) { create(:project, :repository) }
|
2016-06-21 12:26:57 +00:00
|
|
|
|
|
|
|
let(:pipeline) do
|
|
|
|
create(:ci_pipeline, project: project, sha: project.commit.id)
|
|
|
|
end
|
|
|
|
|
2016-10-03 10:56:32 +00:00
|
|
|
let(:commit_status) { create_status }
|
|
|
|
|
|
|
|
def create_status(args = {})
|
|
|
|
create(:commit_status, args.merge(pipeline: pipeline))
|
|
|
|
end
|
2015-10-06 10:01:16 +00:00
|
|
|
|
2016-06-03 12:46:17 +00:00
|
|
|
it { is_expected.to belong_to(:pipeline) }
|
2015-10-06 10:01:16 +00:00
|
|
|
it { is_expected.to belong_to(:user) }
|
2015-12-11 13:37:16 +00:00
|
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
|
2015-10-06 10:01:16 +00:00
|
|
|
it { is_expected.to validate_presence_of(:name) }
|
|
|
|
it { is_expected.to validate_inclusion_of(:status).in_array(%w(pending running failed success canceled)) }
|
|
|
|
|
2016-06-03 12:46:17 +00:00
|
|
|
it { is_expected.to delegate_method(:sha).to(:pipeline) }
|
|
|
|
it { is_expected.to delegate_method(:short_sha).to(:pipeline) }
|
2016-06-21 12:26:57 +00:00
|
|
|
|
2015-10-06 10:01:16 +00:00
|
|
|
it { is_expected.to respond_to :success? }
|
|
|
|
it { is_expected.to respond_to :failed? }
|
|
|
|
it { is_expected.to respond_to :running? }
|
|
|
|
it { is_expected.to respond_to :pending? }
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#author' do
|
2015-10-12 10:15:48 +00:00
|
|
|
subject { commit_status.author }
|
|
|
|
before { commit_status.author = User.new }
|
|
|
|
|
|
|
|
it { is_expected.to eq(commit_status.user) }
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#started?' do
|
2015-10-06 10:01:16 +00:00
|
|
|
subject { commit_status.started? }
|
|
|
|
|
|
|
|
context 'without started_at' do
|
|
|
|
before { commit_status.started_at = nil }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
|
2016-09-13 07:53:10 +00:00
|
|
|
%w[running success failed].each do |status|
|
2015-10-06 10:01:16 +00:00
|
|
|
context "if commit status is #{status}" do
|
|
|
|
before { commit_status.status = status }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-09-13 07:53:10 +00:00
|
|
|
%w[pending canceled].each do |status|
|
2015-10-06 10:01:16 +00:00
|
|
|
context "if commit status is #{status}" do
|
|
|
|
before { commit_status.status = status }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#active?' do
|
2015-10-06 10:01:16 +00:00
|
|
|
subject { commit_status.active? }
|
|
|
|
|
2016-09-13 07:53:10 +00:00
|
|
|
%w[pending running].each do |state|
|
2015-10-06 10:01:16 +00:00
|
|
|
context "if commit_status.status is #{state}" do
|
|
|
|
before { commit_status.status = state }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-09-13 07:53:10 +00:00
|
|
|
%w[success failed canceled].each do |state|
|
2015-10-06 10:01:16 +00:00
|
|
|
context "if commit_status.status is #{state}" do
|
|
|
|
before { commit_status.status = state }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#complete?' do
|
2015-10-06 10:01:16 +00:00
|
|
|
subject { commit_status.complete? }
|
|
|
|
|
2016-09-13 07:53:10 +00:00
|
|
|
%w[success failed canceled].each do |state|
|
2015-10-06 10:01:16 +00:00
|
|
|
context "if commit_status.status is #{state}" do
|
|
|
|
before { commit_status.status = state }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-09-13 07:53:10 +00:00
|
|
|
%w[pending running].each do |state|
|
2015-10-06 10:01:16 +00:00
|
|
|
context "if commit_status.status is #{state}" do
|
|
|
|
before { commit_status.status = state }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '#duration' do
|
2015-10-06 10:01:16 +00:00
|
|
|
subject { commit_status.duration }
|
|
|
|
|
|
|
|
it { is_expected.to eq(120.0) }
|
|
|
|
|
|
|
|
context 'if the building process has not started yet' do
|
|
|
|
before do
|
|
|
|
commit_status.started_at = nil
|
|
|
|
commit_status.finished_at = nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'if the building process has started' do
|
|
|
|
before do
|
|
|
|
commit_status.started_at = Time.now - 1.minute
|
|
|
|
commit_status.finished_at = nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to be_a(Float) }
|
|
|
|
it { is_expected.to be > 0.0 }
|
|
|
|
end
|
|
|
|
end
|
2016-06-21 12:26:57 +00:00
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '.latest' do
|
2017-02-14 14:48:16 +00:00
|
|
|
subject { described_class.latest.order(:id) }
|
2015-10-06 10:01:16 +00:00
|
|
|
|
2016-10-03 10:56:32 +00:00
|
|
|
let(:statuses) do
|
|
|
|
[create_status(name: 'aa', ref: 'bb', status: 'running'),
|
|
|
|
create_status(name: 'cc', ref: 'cc', status: 'pending'),
|
|
|
|
create_status(name: 'aa', ref: 'cc', status: 'success'),
|
|
|
|
create_status(name: 'cc', ref: 'bb', status: 'success'),
|
|
|
|
create_status(name: 'aa', ref: 'bb', status: 'success')]
|
2015-10-06 10:01:16 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns unique statuses' do
|
2016-10-03 10:56:32 +00:00
|
|
|
is_expected.to eq(statuses.values_at(3, 4))
|
2015-10-06 10:01:16 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-07-11 22:12:31 +00:00
|
|
|
describe '.running_or_pending' do
|
2017-02-14 14:48:16 +00:00
|
|
|
subject { described_class.running_or_pending.order(:id) }
|
2015-10-06 10:01:16 +00:00
|
|
|
|
2016-10-03 10:56:32 +00:00
|
|
|
let(:statuses) do
|
|
|
|
[create_status(name: 'aa', ref: 'bb', status: 'running'),
|
|
|
|
create_status(name: 'cc', ref: 'cc', status: 'pending'),
|
|
|
|
create_status(name: 'aa', ref: nil, status: 'success'),
|
|
|
|
create_status(name: 'dd', ref: nil, status: 'failed'),
|
|
|
|
create_status(name: 'ee', ref: nil, status: 'canceled')]
|
2015-10-06 10:01:16 +00:00
|
|
|
end
|
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns statuses that are running or pending' do
|
2016-10-03 10:56:32 +00:00
|
|
|
is_expected.to eq(statuses.values_at(0, 1))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-06 11:43:29 +00:00
|
|
|
describe '.after_stage' do
|
2017-02-14 14:48:16 +00:00
|
|
|
subject { described_class.after_stage(0) }
|
|
|
|
|
|
|
|
let(:statuses) do
|
|
|
|
[create_status(name: 'aa', stage_idx: 0),
|
|
|
|
create_status(name: 'cc', stage_idx: 1),
|
|
|
|
create_status(name: 'aa', stage_idx: 2)]
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns statuses from second and third stage' do
|
|
|
|
is_expected.to eq(statuses.values_at(1, 2))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.exclude_ignored' do
|
|
|
|
subject { described_class.exclude_ignored.order(:id) }
|
2016-10-03 10:56:32 +00:00
|
|
|
|
|
|
|
let(:statuses) do
|
|
|
|
[create_status(when: 'manual', status: 'skipped'),
|
|
|
|
create_status(when: 'manual', status: 'success'),
|
|
|
|
create_status(when: 'manual', status: 'failed'),
|
|
|
|
create_status(when: 'on_failure', status: 'skipped'),
|
|
|
|
create_status(when: 'on_failure', status: 'success'),
|
|
|
|
create_status(when: 'on_failure', status: 'failed'),
|
|
|
|
create_status(allow_failure: true, status: 'success'),
|
|
|
|
create_status(allow_failure: true, status: 'failed'),
|
|
|
|
create_status(allow_failure: false, status: 'success'),
|
2017-03-06 11:52:12 +00:00
|
|
|
create_status(allow_failure: false, status: 'failed'),
|
|
|
|
create_status(allow_failure: true, status: 'manual'),
|
|
|
|
create_status(allow_failure: false, status: 'manual')]
|
2016-10-03 10:56:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns statuses without what we want to ignore' do
|
2017-03-06 11:52:12 +00:00
|
|
|
is_expected.to eq(statuses.values_at(0, 1, 2, 3, 4, 5, 6, 8, 9, 11))
|
2015-10-06 10:01:16 +00:00
|
|
|
end
|
|
|
|
end
|
2016-04-16 20:43:40 +00:00
|
|
|
|
2017-03-06 13:43:32 +00:00
|
|
|
describe '.failed_but_allowed' do
|
|
|
|
subject { described_class.failed_but_allowed.order(:id) }
|
|
|
|
|
|
|
|
let(:statuses) do
|
2017-03-06 13:48:53 +00:00
|
|
|
[create_status(allow_failure: true, status: 'success'),
|
|
|
|
create_status(allow_failure: true, status: 'failed'),
|
|
|
|
create_status(allow_failure: false, status: 'success'),
|
|
|
|
create_status(allow_failure: false, status: 'failed'),
|
|
|
|
create_status(allow_failure: true, status: 'canceled'),
|
|
|
|
create_status(allow_failure: false, status: 'canceled'),
|
|
|
|
create_status(allow_failure: true, status: 'manual'),
|
|
|
|
create_status(allow_failure: false, status: 'manual')]
|
2017-03-06 13:43:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns statuses without what we want to ignore' do
|
|
|
|
is_expected.to eq(statuses.values_at(1, 4))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-04-16 20:43:40 +00:00
|
|
|
describe '#before_sha' do
|
|
|
|
subject { commit_status.before_sha }
|
|
|
|
|
2016-06-03 14:22:26 +00:00
|
|
|
context 'when no before_sha is set for pipeline' do
|
|
|
|
before { pipeline.before_sha = nil }
|
2016-04-16 20:43:40 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns blank sha' do
|
2016-04-16 20:43:40 +00:00
|
|
|
is_expected.to eq(Gitlab::Git::BLANK_SHA)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-03 14:22:26 +00:00
|
|
|
context 'for before_sha set for pipeline' do
|
2016-04-16 20:43:40 +00:00
|
|
|
let(:value) { '1234' }
|
2016-06-03 14:22:26 +00:00
|
|
|
before { pipeline.before_sha = value }
|
2016-04-16 20:43:40 +00:00
|
|
|
|
2016-08-01 15:00:44 +00:00
|
|
|
it 'returns the set value' do
|
2016-04-16 20:43:40 +00:00
|
|
|
is_expected.to eq(value)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-06-21 12:26:57 +00:00
|
|
|
describe '#commit' do
|
|
|
|
it 'returns commit pipeline has been created for' do
|
|
|
|
expect(commit_status.commit).to eq project.commit
|
|
|
|
end
|
|
|
|
end
|
2016-09-14 13:04:12 +00:00
|
|
|
|
|
|
|
describe '#group_name' do
|
|
|
|
subject { commit_status.group_name }
|
|
|
|
|
|
|
|
tests = {
|
|
|
|
'rspec:windows' => 'rspec:windows',
|
|
|
|
'rspec:windows 0' => 'rspec:windows 0',
|
|
|
|
'rspec:windows 0 test' => 'rspec:windows 0 test',
|
|
|
|
'rspec:windows 0 1' => 'rspec:windows',
|
|
|
|
'rspec:windows 0 1 name' => 'rspec:windows name',
|
|
|
|
'rspec:windows 0/1' => 'rspec:windows',
|
|
|
|
'rspec:windows 0/1 name' => 'rspec:windows name',
|
|
|
|
'rspec:windows 0:1' => 'rspec:windows',
|
|
|
|
'rspec:windows 0:1 name' => 'rspec:windows name',
|
|
|
|
'rspec:windows 10000 20000' => 'rspec:windows',
|
|
|
|
'rspec:windows 0 : / 1' => 'rspec:windows',
|
|
|
|
'rspec:windows 0 : / 1 name' => 'rspec:windows name',
|
2016-09-14 13:25:04 +00:00
|
|
|
'0 1 name ruby' => 'name ruby',
|
|
|
|
'0 :/ 1 name ruby' => 'name ruby'
|
2016-09-14 13:04:12 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
tests.each do |name, group_name|
|
|
|
|
it "'#{name}' puts in '#{group_name}'" do
|
|
|
|
commit_status.name = name
|
|
|
|
|
|
|
|
is_expected.to eq(group_name)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-12-14 09:21:16 +00:00
|
|
|
|
|
|
|
describe '#detailed_status' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
it 'returns a detailed status' do
|
|
|
|
expect(commit_status.detailed_status(user))
|
|
|
|
.to be_a Gitlab::Ci::Status::Success
|
|
|
|
end
|
|
|
|
end
|
2017-01-02 17:42:08 +00:00
|
|
|
|
|
|
|
describe '#sortable_name' do
|
|
|
|
tests = {
|
|
|
|
'karma' => ['karma'],
|
|
|
|
'karma 0 20' => ['karma ', 0, ' ', 20],
|
|
|
|
'karma 10 20' => ['karma ', 10, ' ', 20],
|
|
|
|
'karma 50:100' => ['karma ', 50, ':', 100],
|
|
|
|
'karma 1.10' => ['karma ', 1, '.', 10],
|
|
|
|
'karma 1.5.1' => ['karma ', 1, '.', 5, '.', 1],
|
|
|
|
'karma 1 a' => ['karma ', 1, ' a']
|
|
|
|
}
|
|
|
|
|
|
|
|
tests.each do |name, sortable_name|
|
|
|
|
it "'#{name}' sorts as '#{sortable_name}'" do
|
|
|
|
commit_status.name = name
|
2017-01-13 19:54:25 +00:00
|
|
|
expect(commit_status.sortable_name).to eq(sortable_name)
|
2017-01-02 17:42:08 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-10-06 10:01:16 +00:00
|
|
|
end
|