gitlab-org--gitlab-foss/changelogs/unreleased/sh-fix-gitaly-find-commit-c...

---
title: Allow ref name caching CommitService#find_commit
merge_request: 26248
author:
type: performance
Allow ref name caching CommitService#find_commit For a given merge request, it's quite common to see duplicate FindCommit Gitaly requests because the Gitaly CommitService caches the request by the commit SHA, not by the ref name. However, most of the duplicate requests use the ref name, so the cache is never actually used in practice. This leads to unnecessary requests that slow performance. This commit allows certain callers to bypass the ref name to OID conversion in the cache. We don't do this by default because it's possible the tip of the branch changes during the commit, which would cause the caller to get stale data. This commit also forces the Ci::Pipeline to use the full ref name so that caching can work for merge requests. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083 2019-03-17 06:23:11 +00:00			`---`
			`title: Allow ref name caching CommitService#find_commit`
			`merge_request: 26248`
			`author:`
			`type: performance`